diff options
| author | Ilya Dryomov <idryomov@gmail.com> | 2017-01-25 12:16:21 -0500 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2017-02-20 06:16:12 -0500 |
| commit | 431a02cd82dd028f650d588f7cedc78643c5c86a (patch) | |
| tree | ea8d9f35c182ff2b32005ba7c7751fafe17168e6 /drivers/block/rbd.c | |
| parent | 24dca799fdbeeb0c955ef2f56a37461e6566aa07 (diff) | |
rbd: initialize rbd_dev->header_oloc early
No reason to delay it until image_id is known. This will be required
by some rbd_obj_method_sync() callers, after rbd_obj_method_sync() is
changed to take oloc.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Diffstat (limited to 'drivers/block/rbd.c')
| -rw-r--r-- | drivers/block/rbd.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index fa47f53942b7..047e877cacb8 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c | |||
| @@ -4863,7 +4863,7 @@ static struct rbd_device *__rbd_dev_create(struct rbd_client *rbdc, | |||
| 4863 | init_rwsem(&rbd_dev->header_rwsem); | 4863 | init_rwsem(&rbd_dev->header_rwsem); |
| 4864 | 4864 | ||
| 4865 | ceph_oid_init(&rbd_dev->header_oid); | 4865 | ceph_oid_init(&rbd_dev->header_oid); |
| 4866 | ceph_oloc_init(&rbd_dev->header_oloc); | 4866 | rbd_dev->header_oloc.pool = spec->pool_id; |
| 4867 | 4867 | ||
| 4868 | mutex_init(&rbd_dev->watch_mutex); | 4868 | mutex_init(&rbd_dev->watch_mutex); |
| 4869 | rbd_dev->watch_state = RBD_WATCH_STATE_UNREGISTERED; | 4869 | rbd_dev->watch_state = RBD_WATCH_STATE_UNREGISTERED; |
| @@ -6062,8 +6062,6 @@ static int rbd_dev_header_name(struct rbd_device *rbd_dev) | |||
| 6062 | /* Record the header object name for this rbd image. */ | 6062 | /* Record the header object name for this rbd image. */ |
| 6063 | 6063 | ||
| 6064 | rbd_assert(rbd_image_format_valid(rbd_dev->image_format)); | 6064 | rbd_assert(rbd_image_format_valid(rbd_dev->image_format)); |
| 6065 | |||
| 6066 | rbd_dev->header_oloc.pool = rbd_dev->layout.pool_id; | ||
| 6067 | if (rbd_dev->image_format == 1) | 6065 | if (rbd_dev->image_format == 1) |
| 6068 | ret = ceph_oid_aprintf(&rbd_dev->header_oid, GFP_KERNEL, "%s%s", | 6066 | ret = ceph_oid_aprintf(&rbd_dev->header_oid, GFP_KERNEL, "%s%s", |
| 6069 | spec->image_name, RBD_SUFFIX); | 6067 | spec->image_name, RBD_SUFFIX); |
