diff options
author | Daniel Wagner <daniel.wagner@bmw-carit.de> | 2016-11-17 05:00:51 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-11-29 15:28:54 -0500 |
commit | fab82cb3f1e16f22a1910d380ef572e6fe0e9da9 (patch) | |
tree | c631aa32ff548df1b0a7f0f41088172f2be5de92 /drivers/base/firmware_class.c | |
parent | 5b029624948d6864053166da1263df74c0c443df (diff) |
firmware: move fw_state_is_done() into UHM section
fw_state_is_done() is only used for UHM so moved into that section.
Cc: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/firmware_class.c')
-rw-r--r-- | drivers/base/firmware_class.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 95f566c10a55..f8ef983c8a0f 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c | |||
@@ -122,11 +122,6 @@ static void fw_state_init(struct fw_state *fw_st) | |||
122 | fw_st->status = FW_STATUS_UNKNOWN; | 122 | fw_st->status = FW_STATUS_UNKNOWN; |
123 | } | 123 | } |
124 | 124 | ||
125 | static int __fw_state_check(struct fw_state *fw_st, enum fw_status status) | ||
126 | { | ||
127 | return fw_st->status == status; | ||
128 | } | ||
129 | |||
130 | static inline bool __fw_state_is_done(enum fw_status status) | 125 | static inline bool __fw_state_is_done(enum fw_status status) |
131 | { | 126 | { |
132 | return status == FW_STATUS_DONE || status == FW_STATUS_ABORTED; | 127 | return status == FW_STATUS_DONE || status == FW_STATUS_ABORTED; |
@@ -158,8 +153,6 @@ static void __fw_state_set(struct fw_state *fw_st, | |||
158 | __fw_state_set(fw_st, FW_STATUS_LOADING) | 153 | __fw_state_set(fw_st, FW_STATUS_LOADING) |
159 | #define fw_state_done(fw_st) \ | 154 | #define fw_state_done(fw_st) \ |
160 | __fw_state_set(fw_st, FW_STATUS_DONE) | 155 | __fw_state_set(fw_st, FW_STATUS_DONE) |
161 | #define fw_state_is_done(fw_st) \ | ||
162 | __fw_state_check(fw_st, FW_STATUS_DONE) | ||
163 | #define fw_state_wait(fw_st) \ | 156 | #define fw_state_wait(fw_st) \ |
164 | __fw_state_wait_common(fw_st, MAX_SCHEDULE_TIMEOUT) | 157 | __fw_state_wait_common(fw_st, MAX_SCHEDULE_TIMEOUT) |
165 | 158 | ||
@@ -169,8 +162,15 @@ static void __fw_state_set(struct fw_state *fw_st, | |||
169 | 162 | ||
170 | #else /* CONFIG_FW_LOADER_USER_HELPER */ | 163 | #else /* CONFIG_FW_LOADER_USER_HELPER */ |
171 | 164 | ||
165 | static int __fw_state_check(struct fw_state *fw_st, enum fw_status status) | ||
166 | { | ||
167 | return fw_st->status == status; | ||
168 | } | ||
169 | |||
172 | #define fw_state_aborted(fw_st) \ | 170 | #define fw_state_aborted(fw_st) \ |
173 | __fw_state_set(fw_st, FW_STATUS_ABORTED) | 171 | __fw_state_set(fw_st, FW_STATUS_ABORTED) |
172 | #define fw_state_is_done(fw_st) \ | ||
173 | __fw_state_check(fw_st, FW_STATUS_DONE) | ||
174 | #define fw_state_is_loading(fw_st) \ | 174 | #define fw_state_is_loading(fw_st) \ |
175 | __fw_state_check(fw_st, FW_STATUS_LOADING) | 175 | __fw_state_check(fw_st, FW_STATUS_LOADING) |
176 | #define fw_state_is_aborted(fw_st) \ | 176 | #define fw_state_is_aborted(fw_st) \ |