aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/atm
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2017-08-28 14:28:21 -0400
committerKees Cook <keescook@chromium.org>2017-11-21 18:57:05 -0500
commit24ed960abf1d50cb7834e99a0cfc081bc0656712 (patch)
tree9eff9c73720604a2be0358083fb8c3c20a08a499 /drivers/atm
parent6cc73a06da439e80c6686883d45ca32b614a4b97 (diff)
treewide: Switch DEFINE_TIMER callbacks to struct timer_list *
This changes all DEFINE_TIMER() callbacks to use a struct timer_list pointer instead of unsigned long. Since the data argument has already been removed, none of these callbacks are using their argument currently, so this renames the argument to "unused". Done using the following semantic patch: @match_define_timer@ declarer name DEFINE_TIMER; identifier _timer, _callback; @@ DEFINE_TIMER(_timer, _callback); @change_callback depends on match_define_timer@ identifier match_define_timer._callback; type _origtype; identifier _origarg; @@ void -_callback(_origtype _origarg) +_callback(struct timer_list *unused) { ... } Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'drivers/atm')
-rw-r--r--drivers/atm/idt77105.c8
-rw-r--r--drivers/atm/iphase.c4
2 files changed, 6 insertions, 6 deletions
diff --git a/drivers/atm/idt77105.c b/drivers/atm/idt77105.c
index 909744eb7bab..0a67487c0b1d 100644
--- a/drivers/atm/idt77105.c
+++ b/drivers/atm/idt77105.c
@@ -45,8 +45,8 @@ static DEFINE_SPINLOCK(idt77105_priv_lock);
45#define PUT(val,reg) dev->ops->phy_put(dev,val,IDT77105_##reg) 45#define PUT(val,reg) dev->ops->phy_put(dev,val,IDT77105_##reg)
46#define GET(reg) dev->ops->phy_get(dev,IDT77105_##reg) 46#define GET(reg) dev->ops->phy_get(dev,IDT77105_##reg)
47 47
48static void idt77105_stats_timer_func(unsigned long); 48static void idt77105_stats_timer_func(struct timer_list *);
49static void idt77105_restart_timer_func(unsigned long); 49static void idt77105_restart_timer_func(struct timer_list *);
50 50
51 51
52static DEFINE_TIMER(stats_timer, idt77105_stats_timer_func); 52static DEFINE_TIMER(stats_timer, idt77105_stats_timer_func);
@@ -80,7 +80,7 @@ static u16 get_counter(struct atm_dev *dev, int counter)
80 * a separate copy of the stats allows implementation of 80 * a separate copy of the stats allows implementation of
81 * an ioctl which gathers the stats *without* zero'ing them. 81 * an ioctl which gathers the stats *without* zero'ing them.
82 */ 82 */
83static void idt77105_stats_timer_func(unsigned long dummy) 83static void idt77105_stats_timer_func(struct timer_list *unused)
84{ 84{
85 struct idt77105_priv *walk; 85 struct idt77105_priv *walk;
86 struct atm_dev *dev; 86 struct atm_dev *dev;
@@ -109,7 +109,7 @@ static void idt77105_stats_timer_func(unsigned long dummy)
109 * interrupts need to be disabled when the cable is pulled out 109 * interrupts need to be disabled when the cable is pulled out
110 * to avoid lots of spurious cell error interrupts. 110 * to avoid lots of spurious cell error interrupts.
111 */ 111 */
112static void idt77105_restart_timer_func(unsigned long dummy) 112static void idt77105_restart_timer_func(struct timer_list *unused)
113{ 113{
114 struct idt77105_priv *walk; 114 struct idt77105_priv *walk;
115 struct atm_dev *dev; 115 struct atm_dev *dev;
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 12f646760b68..98a3a43484c8 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -75,7 +75,7 @@ static void desc_dbg(IADEV *iadev);
75static IADEV *ia_dev[8]; 75static IADEV *ia_dev[8];
76static struct atm_dev *_ia_dev[8]; 76static struct atm_dev *_ia_dev[8];
77static int iadev_count; 77static int iadev_count;
78static void ia_led_timer(unsigned long arg); 78static void ia_led_timer(struct timer_list *unused);
79static DEFINE_TIMER(ia_timer, ia_led_timer); 79static DEFINE_TIMER(ia_timer, ia_led_timer);
80static int IA_TX_BUF = DFL_TX_BUFFERS, IA_TX_BUF_SZ = DFL_TX_BUF_SZ; 80static int IA_TX_BUF = DFL_TX_BUFFERS, IA_TX_BUF_SZ = DFL_TX_BUF_SZ;
81static int IA_RX_BUF = DFL_RX_BUFFERS, IA_RX_BUF_SZ = DFL_RX_BUF_SZ; 81static int IA_RX_BUF = DFL_RX_BUFFERS, IA_RX_BUF_SZ = DFL_RX_BUF_SZ;
@@ -2432,7 +2432,7 @@ static void ia_update_stats(IADEV *iadev) {
2432 return; 2432 return;
2433} 2433}
2434 2434
2435static void ia_led_timer(unsigned long arg) { 2435static void ia_led_timer(struct timer_list *unused) {
2436 unsigned long flags; 2436 unsigned long flags;
2437 static u_char blinking[8] = {0, 0, 0, 0, 0, 0, 0, 0}; 2437 static u_char blinking[8] = {0, 0, 0, 0, 0, 0, 0, 0};
2438 u_char i; 2438 u_char i;