diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:51:58 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | a44fec1fce5d5d14cc3ac4545b8da346394de666 (patch) | |
tree | fa3d16a4c8f1a6a7e9af867f16f7201a5b5442f9 /drivers/ata/ahci.c | |
parent | 02f8c6aee8df3cdc935e9bdd4f2d020306035dbe (diff) |
ata: Convert dev_printk(KERN_<LEVEL> to dev_<level>(
Saves a bit of text as the call takes fewer args.
Coalesce a few formats.
Convert a few bare printks to pr_cont.
$ size drivers/ata/built-in.o*
text data bss dec hex filename
558429 73893 117864 750186 b726a drivers/ata/built-in.o.allyesconfig.new
559574 73893 117888 751355 b76fb drivers/ata/built-in.o.allyesconfig.old
149567 14689 4220 168476 2921c drivers/ata/built-in.o.defconfig.new
149851 14689 4220 168760 29338 drivers/ata/built-in.o.defconfig.old
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/ahci.c')
-rw-r--r-- | drivers/ata/ahci.c | 44 |
1 files changed, 21 insertions, 23 deletions
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 71afe0371311..dda85116343e 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c | |||
@@ -629,8 +629,8 @@ static int ahci_pci_device_suspend(struct pci_dev *pdev, pm_message_t mesg) | |||
629 | 629 | ||
630 | if (mesg.event & PM_EVENT_SUSPEND && | 630 | if (mesg.event & PM_EVENT_SUSPEND && |
631 | hpriv->flags & AHCI_HFLAG_NO_SUSPEND) { | 631 | hpriv->flags & AHCI_HFLAG_NO_SUSPEND) { |
632 | dev_printk(KERN_ERR, &pdev->dev, | 632 | dev_err(&pdev->dev, |
633 | "BIOS update required for suspend/resume\n"); | 633 | "BIOS update required for suspend/resume\n"); |
634 | return -EIO; | 634 | return -EIO; |
635 | } | 635 | } |
636 | 636 | ||
@@ -681,22 +681,21 @@ static int ahci_configure_dma_masks(struct pci_dev *pdev, int using_dac) | |||
681 | if (rc) { | 681 | if (rc) { |
682 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); | 682 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); |
683 | if (rc) { | 683 | if (rc) { |
684 | dev_printk(KERN_ERR, &pdev->dev, | 684 | dev_err(&pdev->dev, |
685 | "64-bit DMA enable failed\n"); | 685 | "64-bit DMA enable failed\n"); |
686 | return rc; | 686 | return rc; |
687 | } | 687 | } |
688 | } | 688 | } |
689 | } else { | 689 | } else { |
690 | rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); | 690 | rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); |
691 | if (rc) { | 691 | if (rc) { |
692 | dev_printk(KERN_ERR, &pdev->dev, | 692 | dev_err(&pdev->dev, "32-bit DMA enable failed\n"); |
693 | "32-bit DMA enable failed\n"); | ||
694 | return rc; | 693 | return rc; |
695 | } | 694 | } |
696 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); | 695 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); |
697 | if (rc) { | 696 | if (rc) { |
698 | dev_printk(KERN_ERR, &pdev->dev, | 697 | dev_err(&pdev->dev, |
699 | "32-bit consistent DMA enable failed\n"); | 698 | "32-bit consistent DMA enable failed\n"); |
700 | return rc; | 699 | return rc; |
701 | } | 700 | } |
702 | } | 701 | } |
@@ -759,8 +758,8 @@ static void ahci_p5wdh_workaround(struct ata_host *host) | |||
759 | dmi_check_system(sysids)) { | 758 | dmi_check_system(sysids)) { |
760 | struct ata_port *ap = host->ports[1]; | 759 | struct ata_port *ap = host->ports[1]; |
761 | 760 | ||
762 | dev_printk(KERN_INFO, &pdev->dev, "enabling ASUS P5W DH " | 761 | dev_info(&pdev->dev, |
763 | "Deluxe on-board SIMG4726 workaround\n"); | 762 | "enabling ASUS P5W DH Deluxe on-board SIMG4726 workaround\n"); |
764 | 763 | ||
765 | ap->ops = &ahci_p5wdh_ops; | 764 | ap->ops = &ahci_p5wdh_ops; |
766 | ap->link.flags |= ATA_LFLAG_NO_SRST | ATA_LFLAG_ASSUME_ATA; | 765 | ap->link.flags |= ATA_LFLAG_NO_SRST | ATA_LFLAG_ASSUME_ATA; |
@@ -831,14 +830,14 @@ static bool ahci_sb600_enable_64bit(struct pci_dev *pdev) | |||
831 | if (strcmp(buf, match->driver_data) >= 0) | 830 | if (strcmp(buf, match->driver_data) >= 0) |
832 | goto enable_64bit; | 831 | goto enable_64bit; |
833 | else { | 832 | else { |
834 | dev_printk(KERN_WARNING, &pdev->dev, "%s: BIOS too old, " | 833 | dev_warn(&pdev->dev, |
835 | "forcing 32bit DMA, update BIOS\n", match->ident); | 834 | "%s: BIOS too old, forcing 32bit DMA, update BIOS\n", |
835 | match->ident); | ||
836 | return false; | 836 | return false; |
837 | } | 837 | } |
838 | 838 | ||
839 | enable_64bit: | 839 | enable_64bit: |
840 | dev_printk(KERN_WARNING, &pdev->dev, "%s: enabling 64bit DMA\n", | 840 | dev_warn(&pdev->dev, "%s: enabling 64bit DMA\n", match->ident); |
841 | match->ident); | ||
842 | return true; | 841 | return true; |
843 | } | 842 | } |
844 | 843 | ||
@@ -1041,9 +1040,8 @@ static void ahci_gtf_filter_workaround(struct ata_host *host) | |||
1041 | return; | 1040 | return; |
1042 | 1041 | ||
1043 | filter = (unsigned long)dmi->driver_data; | 1042 | filter = (unsigned long)dmi->driver_data; |
1044 | dev_printk(KERN_INFO, host->dev, | 1043 | dev_info(host->dev, "applying extra ACPI _GTF filter 0x%x for %s\n", |
1045 | "applying extra ACPI _GTF filter 0x%x for %s\n", | 1044 | filter, dmi->ident); |
1046 | filter, dmi->ident); | ||
1047 | 1045 | ||
1048 | for (i = 0; i < host->n_ports; i++) { | 1046 | for (i = 0; i < host->n_ports; i++) { |
1049 | struct ata_port *ap = host->ports[i]; | 1047 | struct ata_port *ap = host->ports[i]; |
@@ -1099,8 +1097,8 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
1099 | * that for SAS drives they're out of luck. | 1097 | * that for SAS drives they're out of luck. |
1100 | */ | 1098 | */ |
1101 | if (pdev->vendor == PCI_VENDOR_ID_PROMISE) | 1099 | if (pdev->vendor == PCI_VENDOR_ID_PROMISE) |
1102 | dev_printk(KERN_INFO, &pdev->dev, "PDC42819 " | 1100 | dev_info(&pdev->dev, |
1103 | "can only drive SATA devices with this driver\n"); | 1101 | "PDC42819 can only drive SATA devices with this driver\n"); |
1104 | 1102 | ||
1105 | /* acquire resources */ | 1103 | /* acquire resources */ |
1106 | rc = pcim_enable_device(pdev); | 1104 | rc = pcim_enable_device(pdev); |
@@ -1126,8 +1124,8 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
1126 | */ | 1124 | */ |
1127 | pci_read_config_byte(pdev, ICH_MAP, &map); | 1125 | pci_read_config_byte(pdev, ICH_MAP, &map); |
1128 | if (map & 0x3) { | 1126 | if (map & 0x3) { |
1129 | dev_printk(KERN_INFO, &pdev->dev, "controller is in " | 1127 | dev_info(&pdev->dev, |
1130 | "combined mode, can't enable AHCI mode\n"); | 1128 | "controller is in combined mode, can't enable AHCI mode\n"); |
1131 | return -ENODEV; | 1129 | return -ENODEV; |
1132 | } | 1130 | } |
1133 | } | 1131 | } |
@@ -1184,8 +1182,8 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
1184 | 1182 | ||
1185 | if (ahci_broken_suspend(pdev)) { | 1183 | if (ahci_broken_suspend(pdev)) { |
1186 | hpriv->flags |= AHCI_HFLAG_NO_SUSPEND; | 1184 | hpriv->flags |= AHCI_HFLAG_NO_SUSPEND; |
1187 | dev_printk(KERN_WARNING, &pdev->dev, | 1185 | dev_warn(&pdev->dev, |
1188 | "BIOS update required for suspend/resume\n"); | 1186 | "BIOS update required for suspend/resume\n"); |
1189 | } | 1187 | } |
1190 | 1188 | ||
1191 | if (ahci_broken_online(pdev)) { | 1189 | if (ahci_broken_online(pdev)) { |