diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2018-07-23 17:41:38 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-24 08:23:00 -0400 |
| commit | f371a7c17aaa47dd7aedc89ef3cd1d5638c03f5e (patch) | |
| tree | 72199ebd1c7fb5ed22a74b1e82fa7daef103736e /drivers/android | |
| parent | 1e81c57b598307c5611410fd357554ffacc6290d (diff) | |
android: binder: Include asm/cacheflush.h after linux/ include files
If asm/cacheflush.h is included first, the following build warnings are
seen with sparc32 builds.
In file included from arch/sparc/include/asm/cacheflush.h:11:0,
from drivers/android/binder.c:54:
arch/sparc/include/asm/cacheflush_32.h:40:37: warning:
'struct page' declared inside parameter list will not be visible
outside of this definition or declaration
Moving the asm/ include after linux/ includes solves the problem.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/android')
| -rw-r--r-- | drivers/android/binder.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 95283f3bb51c..1cc2fa16af8b 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c | |||
| @@ -51,7 +51,6 @@ | |||
| 51 | 51 | ||
| 52 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt | 52 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt |
| 53 | 53 | ||
| 54 | #include <asm/cacheflush.h> | ||
| 55 | #include <linux/fdtable.h> | 54 | #include <linux/fdtable.h> |
| 56 | #include <linux/file.h> | 55 | #include <linux/file.h> |
| 57 | #include <linux/freezer.h> | 56 | #include <linux/freezer.h> |
| @@ -73,6 +72,9 @@ | |||
| 73 | #include <linux/spinlock.h> | 72 | #include <linux/spinlock.h> |
| 74 | 73 | ||
| 75 | #include <uapi/linux/android/binder.h> | 74 | #include <uapi/linux/android/binder.h> |
| 75 | |||
| 76 | #include <asm/cacheflush.h> | ||
| 77 | |||
| 76 | #include "binder_alloc.h" | 78 | #include "binder_alloc.h" |
| 77 | #include "binder_trace.h" | 79 | #include "binder_trace.h" |
| 78 | 80 | ||
