diff options
author | Patrick Mochel <mochel@linux.intel.com> | 2006-06-27 00:41:40 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2006-06-27 00:41:40 -0400 |
commit | d550d98d3317378d93a4869db204725d270ec812 (patch) | |
tree | 958a8578babc6f9955f91e21253d1d1b847985ff /drivers/acpi/processor_core.c | |
parent | d7fa2589bbe7ab53fd5eb20e8c7e388d5aff6f16 (diff) |
ACPI: delete tracing macros from drivers/acpi/*.c
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/processor_core.c')
-rw-r--r-- | drivers/acpi/processor_core.c | 111 |
1 files changed, 47 insertions, 64 deletions
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index 80bbf187a37d..52674323b14d 100644 --- a/drivers/acpi/processor_core.c +++ b/drivers/acpi/processor_core.c | |||
@@ -122,10 +122,9 @@ static int acpi_processor_errata_piix4(struct pci_dev *dev) | |||
122 | u8 value1 = 0; | 122 | u8 value1 = 0; |
123 | u8 value2 = 0; | 123 | u8 value2 = 0; |
124 | 124 | ||
125 | ACPI_FUNCTION_TRACE("acpi_processor_errata_piix4"); | ||
126 | 125 | ||
127 | if (!dev) | 126 | if (!dev) |
128 | return_VALUE(-EINVAL); | 127 | return -EINVAL; |
129 | 128 | ||
130 | /* | 129 | /* |
131 | * Note that 'dev' references the PIIX4 ACPI Controller. | 130 | * Note that 'dev' references the PIIX4 ACPI Controller. |
@@ -218,7 +217,7 @@ static int acpi_processor_errata_piix4(struct pci_dev *dev) | |||
218 | ACPI_DEBUG_PRINT((ACPI_DB_INFO, | 217 | ACPI_DEBUG_PRINT((ACPI_DB_INFO, |
219 | "Type-F DMA livelock erratum (C3 disabled)\n")); | 218 | "Type-F DMA livelock erratum (C3 disabled)\n")); |
220 | 219 | ||
221 | return_VALUE(0); | 220 | return 0; |
222 | } | 221 | } |
223 | 222 | ||
224 | static int acpi_processor_errata(struct acpi_processor *pr) | 223 | static int acpi_processor_errata(struct acpi_processor *pr) |
@@ -226,10 +225,9 @@ static int acpi_processor_errata(struct acpi_processor *pr) | |||
226 | int result = 0; | 225 | int result = 0; |
227 | struct pci_dev *dev = NULL; | 226 | struct pci_dev *dev = NULL; |
228 | 227 | ||
229 | ACPI_FUNCTION_TRACE("acpi_processor_errata"); | ||
230 | 228 | ||
231 | if (!pr) | 229 | if (!pr) |
232 | return_VALUE(-EINVAL); | 230 | return -EINVAL; |
233 | 231 | ||
234 | /* | 232 | /* |
235 | * PIIX4 | 233 | * PIIX4 |
@@ -242,7 +240,7 @@ static int acpi_processor_errata(struct acpi_processor *pr) | |||
242 | pci_dev_put(dev); | 240 | pci_dev_put(dev); |
243 | } | 241 | } |
244 | 242 | ||
245 | return_VALUE(result); | 243 | return result; |
246 | } | 244 | } |
247 | 245 | ||
248 | /* -------------------------------------------------------------------------- | 246 | /* -------------------------------------------------------------------------- |
@@ -258,10 +256,9 @@ static int acpi_processor_set_pdc(struct acpi_processor *pr) | |||
258 | struct acpi_object_list *pdc_in = pr->pdc; | 256 | struct acpi_object_list *pdc_in = pr->pdc; |
259 | acpi_status status = AE_OK; | 257 | acpi_status status = AE_OK; |
260 | 258 | ||
261 | ACPI_FUNCTION_TRACE("acpi_processor_set_pdc"); | ||
262 | 259 | ||
263 | if (!pdc_in) | 260 | if (!pdc_in) |
264 | return_VALUE(status); | 261 | return status; |
265 | 262 | ||
266 | status = acpi_evaluate_object(pr->handle, "_PDC", pdc_in, NULL); | 263 | status = acpi_evaluate_object(pr->handle, "_PDC", pdc_in, NULL); |
267 | 264 | ||
@@ -269,7 +266,7 @@ static int acpi_processor_set_pdc(struct acpi_processor *pr) | |||
269 | ACPI_DEBUG_PRINT((ACPI_DB_INFO, | 266 | ACPI_DEBUG_PRINT((ACPI_DB_INFO, |
270 | "Could not evaluate _PDC, using legacy perf. control...\n")); | 267 | "Could not evaluate _PDC, using legacy perf. control...\n")); |
271 | 268 | ||
272 | return_VALUE(status); | 269 | return status; |
273 | } | 270 | } |
274 | 271 | ||
275 | /* -------------------------------------------------------------------------- | 272 | /* -------------------------------------------------------------------------- |
@@ -282,7 +279,6 @@ static int acpi_processor_info_seq_show(struct seq_file *seq, void *offset) | |||
282 | { | 279 | { |
283 | struct acpi_processor *pr = (struct acpi_processor *)seq->private; | 280 | struct acpi_processor *pr = (struct acpi_processor *)seq->private; |
284 | 281 | ||
285 | ACPI_FUNCTION_TRACE("acpi_processor_info_seq_show"); | ||
286 | 282 | ||
287 | if (!pr) | 283 | if (!pr) |
288 | goto end; | 284 | goto end; |
@@ -301,7 +297,7 @@ static int acpi_processor_info_seq_show(struct seq_file *seq, void *offset) | |||
301 | pr->flags.limit ? "yes" : "no"); | 297 | pr->flags.limit ? "yes" : "no"); |
302 | 298 | ||
303 | end: | 299 | end: |
304 | return_VALUE(0); | 300 | return 0; |
305 | } | 301 | } |
306 | 302 | ||
307 | static int acpi_processor_info_open_fs(struct inode *inode, struct file *file) | 303 | static int acpi_processor_info_open_fs(struct inode *inode, struct file *file) |
@@ -314,13 +310,12 @@ static int acpi_processor_add_fs(struct acpi_device *device) | |||
314 | { | 310 | { |
315 | struct proc_dir_entry *entry = NULL; | 311 | struct proc_dir_entry *entry = NULL; |
316 | 312 | ||
317 | ACPI_FUNCTION_TRACE("acpi_processor_add_fs"); | ||
318 | 313 | ||
319 | if (!acpi_device_dir(device)) { | 314 | if (!acpi_device_dir(device)) { |
320 | acpi_device_dir(device) = proc_mkdir(acpi_device_bid(device), | 315 | acpi_device_dir(device) = proc_mkdir(acpi_device_bid(device), |
321 | acpi_processor_dir); | 316 | acpi_processor_dir); |
322 | if (!acpi_device_dir(device)) | 317 | if (!acpi_device_dir(device)) |
323 | return_VALUE(-ENODEV); | 318 | return -ENODEV; |
324 | } | 319 | } |
325 | acpi_device_dir(device)->owner = THIS_MODULE; | 320 | acpi_device_dir(device)->owner = THIS_MODULE; |
326 | 321 | ||
@@ -328,7 +323,7 @@ static int acpi_processor_add_fs(struct acpi_device *device) | |||
328 | entry = create_proc_entry(ACPI_PROCESSOR_FILE_INFO, | 323 | entry = create_proc_entry(ACPI_PROCESSOR_FILE_INFO, |
329 | S_IRUGO, acpi_device_dir(device)); | 324 | S_IRUGO, acpi_device_dir(device)); |
330 | if (!entry) | 325 | if (!entry) |
331 | return_VALUE(-EIO); | 326 | return -EIO; |
332 | else { | 327 | else { |
333 | entry->proc_fops = &acpi_processor_info_fops; | 328 | entry->proc_fops = &acpi_processor_info_fops; |
334 | entry->data = acpi_driver_data(device); | 329 | entry->data = acpi_driver_data(device); |
@@ -340,7 +335,7 @@ static int acpi_processor_add_fs(struct acpi_device *device) | |||
340 | S_IFREG | S_IRUGO | S_IWUSR, | 335 | S_IFREG | S_IRUGO | S_IWUSR, |
341 | acpi_device_dir(device)); | 336 | acpi_device_dir(device)); |
342 | if (!entry) | 337 | if (!entry) |
343 | return_VALUE(-EIO); | 338 | return -EIO; |
344 | else { | 339 | else { |
345 | entry->proc_fops = &acpi_processor_throttling_fops; | 340 | entry->proc_fops = &acpi_processor_throttling_fops; |
346 | entry->data = acpi_driver_data(device); | 341 | entry->data = acpi_driver_data(device); |
@@ -352,19 +347,18 @@ static int acpi_processor_add_fs(struct acpi_device *device) | |||
352 | S_IFREG | S_IRUGO | S_IWUSR, | 347 | S_IFREG | S_IRUGO | S_IWUSR, |
353 | acpi_device_dir(device)); | 348 | acpi_device_dir(device)); |
354 | if (!entry) | 349 | if (!entry) |
355 | return_VALUE( -EIO); | 350 | return -EIO; |
356 | else { | 351 | else { |
357 | entry->proc_fops = &acpi_processor_limit_fops; | 352 | entry->proc_fops = &acpi_processor_limit_fops; |
358 | entry->data = acpi_driver_data(device); | 353 | entry->data = acpi_driver_data(device); |
359 | entry->owner = THIS_MODULE; | 354 | entry->owner = THIS_MODULE; |
360 | } | 355 | } |
361 | 356 | ||
362 | return_VALUE(0); | 357 | return 0; |
363 | } | 358 | } |
364 | 359 | ||
365 | static int acpi_processor_remove_fs(struct acpi_device *device) | 360 | static int acpi_processor_remove_fs(struct acpi_device *device) |
366 | { | 361 | { |
367 | ACPI_FUNCTION_TRACE("acpi_processor_remove_fs"); | ||
368 | 362 | ||
369 | if (acpi_device_dir(device)) { | 363 | if (acpi_device_dir(device)) { |
370 | remove_proc_entry(ACPI_PROCESSOR_FILE_INFO, | 364 | remove_proc_entry(ACPI_PROCESSOR_FILE_INFO, |
@@ -377,7 +371,7 @@ static int acpi_processor_remove_fs(struct acpi_device *device) | |||
377 | acpi_device_dir(device) = NULL; | 371 | acpi_device_dir(device) = NULL; |
378 | } | 372 | } |
379 | 373 | ||
380 | return_VALUE(0); | 374 | return 0; |
381 | } | 375 | } |
382 | 376 | ||
383 | /* Use the acpiid in MADT to map cpus in case of SMP */ | 377 | /* Use the acpiid in MADT to map cpus in case of SMP */ |
@@ -424,10 +418,9 @@ static int acpi_processor_get_info(struct acpi_processor *pr) | |||
424 | int cpu_index; | 418 | int cpu_index; |
425 | static int cpu0_initialized; | 419 | static int cpu0_initialized; |
426 | 420 | ||
427 | ACPI_FUNCTION_TRACE("acpi_processor_get_info"); | ||
428 | 421 | ||
429 | if (!pr) | 422 | if (!pr) |
430 | return_VALUE(-EINVAL); | 423 | return -EINVAL; |
431 | 424 | ||
432 | if (num_online_cpus() > 1) | 425 | if (num_online_cpus() > 1) |
433 | errata.smp = TRUE; | 426 | errata.smp = TRUE; |
@@ -454,7 +447,7 @@ static int acpi_processor_get_info(struct acpi_processor *pr) | |||
454 | status = acpi_evaluate_object(pr->handle, NULL, NULL, &buffer); | 447 | status = acpi_evaluate_object(pr->handle, NULL, NULL, &buffer); |
455 | if (ACPI_FAILURE(status)) { | 448 | if (ACPI_FAILURE(status)) { |
456 | printk(KERN_ERR PREFIX "Evaluating processor object\n"); | 449 | printk(KERN_ERR PREFIX "Evaluating processor object\n"); |
457 | return_VALUE(-ENODEV); | 450 | return -ENODEV; |
458 | } | 451 | } |
459 | 452 | ||
460 | /* | 453 | /* |
@@ -486,7 +479,7 @@ static int acpi_processor_get_info(struct acpi_processor *pr) | |||
486 | printk(KERN_ERR PREFIX | 479 | printk(KERN_ERR PREFIX |
487 | "Getting cpuindex for acpiid 0x%x\n", | 480 | "Getting cpuindex for acpiid 0x%x\n", |
488 | pr->acpi_id); | 481 | pr->acpi_id); |
489 | return_VALUE(-ENODEV); | 482 | return -ENODEV; |
490 | } | 483 | } |
491 | } | 484 | } |
492 | 485 | ||
@@ -521,7 +514,7 @@ static int acpi_processor_get_info(struct acpi_processor *pr) | |||
521 | acpi_processor_get_throttling_info(pr); | 514 | acpi_processor_get_throttling_info(pr); |
522 | acpi_processor_get_limit_info(pr); | 515 | acpi_processor_get_limit_info(pr); |
523 | 516 | ||
524 | return_VALUE(0); | 517 | return 0; |
525 | } | 518 | } |
526 | 519 | ||
527 | static void *processor_device_array[NR_CPUS]; | 520 | static void *processor_device_array[NR_CPUS]; |
@@ -532,14 +525,13 @@ static int acpi_processor_start(struct acpi_device *device) | |||
532 | acpi_status status = AE_OK; | 525 | acpi_status status = AE_OK; |
533 | struct acpi_processor *pr; | 526 | struct acpi_processor *pr; |
534 | 527 | ||
535 | ACPI_FUNCTION_TRACE("acpi_processor_start"); | ||
536 | 528 | ||
537 | pr = acpi_driver_data(device); | 529 | pr = acpi_driver_data(device); |
538 | 530 | ||
539 | result = acpi_processor_get_info(pr); | 531 | result = acpi_processor_get_info(pr); |
540 | if (result) { | 532 | if (result) { |
541 | /* Processor is physically not present */ | 533 | /* Processor is physically not present */ |
542 | return_VALUE(0); | 534 | return 0; |
543 | } | 535 | } |
544 | 536 | ||
545 | BUG_ON((pr->id >= NR_CPUS) || (pr->id < 0)); | 537 | BUG_ON((pr->id >= NR_CPUS) || (pr->id < 0)); |
@@ -553,7 +545,7 @@ static int acpi_processor_start(struct acpi_device *device) | |||
553 | processor_device_array[pr->id] != (void *)device) { | 545 | processor_device_array[pr->id] != (void *)device) { |
554 | printk(KERN_WARNING "BIOS reported wrong ACPI id" | 546 | printk(KERN_WARNING "BIOS reported wrong ACPI id" |
555 | "for the processor\n"); | 547 | "for the processor\n"); |
556 | return_VALUE(-ENODEV); | 548 | return -ENODEV; |
557 | } | 549 | } |
558 | processor_device_array[pr->id] = (void *)device; | 550 | processor_device_array[pr->id] = (void *)device; |
559 | 551 | ||
@@ -581,7 +573,7 @@ static int acpi_processor_start(struct acpi_device *device) | |||
581 | 573 | ||
582 | end: | 574 | end: |
583 | 575 | ||
584 | return_VALUE(result); | 576 | return result; |
585 | } | 577 | } |
586 | 578 | ||
587 | static void acpi_processor_notify(acpi_handle handle, u32 event, void *data) | 579 | static void acpi_processor_notify(acpi_handle handle, u32 event, void *data) |
@@ -589,13 +581,12 @@ static void acpi_processor_notify(acpi_handle handle, u32 event, void *data) | |||
589 | struct acpi_processor *pr = (struct acpi_processor *)data; | 581 | struct acpi_processor *pr = (struct acpi_processor *)data; |
590 | struct acpi_device *device = NULL; | 582 | struct acpi_device *device = NULL; |
591 | 583 | ||
592 | ACPI_FUNCTION_TRACE("acpi_processor_notify"); | ||
593 | 584 | ||
594 | if (!pr) | 585 | if (!pr) |
595 | return_VOID; | 586 | return; |
596 | 587 | ||
597 | if (acpi_bus_get_device(pr->handle, &device)) | 588 | if (acpi_bus_get_device(pr->handle, &device)) |
598 | return_VOID; | 589 | return; |
599 | 590 | ||
600 | switch (event) { | 591 | switch (event) { |
601 | case ACPI_PROCESSOR_NOTIFY_PERFORMANCE: | 592 | case ACPI_PROCESSOR_NOTIFY_PERFORMANCE: |
@@ -613,21 +604,20 @@ static void acpi_processor_notify(acpi_handle handle, u32 event, void *data) | |||
613 | break; | 604 | break; |
614 | } | 605 | } |
615 | 606 | ||
616 | return_VOID; | 607 | return; |
617 | } | 608 | } |
618 | 609 | ||
619 | static int acpi_processor_add(struct acpi_device *device) | 610 | static int acpi_processor_add(struct acpi_device *device) |
620 | { | 611 | { |
621 | struct acpi_processor *pr = NULL; | 612 | struct acpi_processor *pr = NULL; |
622 | 613 | ||
623 | ACPI_FUNCTION_TRACE("acpi_processor_add"); | ||
624 | 614 | ||
625 | if (!device) | 615 | if (!device) |
626 | return_VALUE(-EINVAL); | 616 | return -EINVAL; |
627 | 617 | ||
628 | pr = kmalloc(sizeof(struct acpi_processor), GFP_KERNEL); | 618 | pr = kmalloc(sizeof(struct acpi_processor), GFP_KERNEL); |
629 | if (!pr) | 619 | if (!pr) |
630 | return_VALUE(-ENOMEM); | 620 | return -ENOMEM; |
631 | memset(pr, 0, sizeof(struct acpi_processor)); | 621 | memset(pr, 0, sizeof(struct acpi_processor)); |
632 | 622 | ||
633 | pr->handle = device->handle; | 623 | pr->handle = device->handle; |
@@ -635,7 +625,7 @@ static int acpi_processor_add(struct acpi_device *device) | |||
635 | strcpy(acpi_device_class(device), ACPI_PROCESSOR_CLASS); | 625 | strcpy(acpi_device_class(device), ACPI_PROCESSOR_CLASS); |
636 | acpi_driver_data(device) = pr; | 626 | acpi_driver_data(device) = pr; |
637 | 627 | ||
638 | return_VALUE(0); | 628 | return 0; |
639 | } | 629 | } |
640 | 630 | ||
641 | static int acpi_processor_remove(struct acpi_device *device, int type) | 631 | static int acpi_processor_remove(struct acpi_device *device, int type) |
@@ -643,21 +633,20 @@ static int acpi_processor_remove(struct acpi_device *device, int type) | |||
643 | acpi_status status = AE_OK; | 633 | acpi_status status = AE_OK; |
644 | struct acpi_processor *pr = NULL; | 634 | struct acpi_processor *pr = NULL; |
645 | 635 | ||
646 | ACPI_FUNCTION_TRACE("acpi_processor_remove"); | ||
647 | 636 | ||
648 | if (!device || !acpi_driver_data(device)) | 637 | if (!device || !acpi_driver_data(device)) |
649 | return_VALUE(-EINVAL); | 638 | return -EINVAL; |
650 | 639 | ||
651 | pr = (struct acpi_processor *)acpi_driver_data(device); | 640 | pr = (struct acpi_processor *)acpi_driver_data(device); |
652 | 641 | ||
653 | if (pr->id >= NR_CPUS) { | 642 | if (pr->id >= NR_CPUS) { |
654 | kfree(pr); | 643 | kfree(pr); |
655 | return_VALUE(0); | 644 | return 0; |
656 | } | 645 | } |
657 | 646 | ||
658 | if (type == ACPI_BUS_REMOVAL_EJECT) { | 647 | if (type == ACPI_BUS_REMOVAL_EJECT) { |
659 | if (acpi_processor_handle_eject(pr)) | 648 | if (acpi_processor_handle_eject(pr)) |
660 | return_VALUE(-EINVAL); | 649 | return -EINVAL; |
661 | } | 650 | } |
662 | 651 | ||
663 | acpi_processor_power_exit(pr, device); | 652 | acpi_processor_power_exit(pr, device); |
@@ -671,7 +660,7 @@ static int acpi_processor_remove(struct acpi_device *device, int type) | |||
671 | 660 | ||
672 | kfree(pr); | 661 | kfree(pr); |
673 | 662 | ||
674 | return_VALUE(0); | 663 | return 0; |
675 | } | 664 | } |
676 | 665 | ||
677 | #ifdef CONFIG_ACPI_HOTPLUG_CPU | 666 | #ifdef CONFIG_ACPI_HOTPLUG_CPU |
@@ -686,14 +675,13 @@ static int is_processor_present(acpi_handle handle) | |||
686 | acpi_status status; | 675 | acpi_status status; |
687 | unsigned long sta = 0; | 676 | unsigned long sta = 0; |
688 | 677 | ||
689 | ACPI_FUNCTION_TRACE("is_processor_present"); | ||
690 | 678 | ||
691 | status = acpi_evaluate_integer(handle, "_STA", NULL, &sta); | 679 | status = acpi_evaluate_integer(handle, "_STA", NULL, &sta); |
692 | if (ACPI_FAILURE(status) || !(sta & ACPI_STA_PRESENT)) { | 680 | if (ACPI_FAILURE(status) || !(sta & ACPI_STA_PRESENT)) { |
693 | ACPI_EXCEPTION((AE_INFO, status, "Processor Device is not present")); | 681 | ACPI_EXCEPTION((AE_INFO, status, "Processor Device is not present")); |
694 | return_VALUE(0); | 682 | return 0; |
695 | } | 683 | } |
696 | return_VALUE(1); | 684 | return 1; |
697 | } | 685 | } |
698 | 686 | ||
699 | static | 687 | static |
@@ -703,30 +691,29 @@ int acpi_processor_device_add(acpi_handle handle, struct acpi_device **device) | |||
703 | struct acpi_device *pdev; | 691 | struct acpi_device *pdev; |
704 | struct acpi_processor *pr; | 692 | struct acpi_processor *pr; |
705 | 693 | ||
706 | ACPI_FUNCTION_TRACE("acpi_processor_device_add"); | ||
707 | 694 | ||
708 | if (acpi_get_parent(handle, &phandle)) { | 695 | if (acpi_get_parent(handle, &phandle)) { |
709 | return_VALUE(-ENODEV); | 696 | return -ENODEV; |
710 | } | 697 | } |
711 | 698 | ||
712 | if (acpi_bus_get_device(phandle, &pdev)) { | 699 | if (acpi_bus_get_device(phandle, &pdev)) { |
713 | return_VALUE(-ENODEV); | 700 | return -ENODEV; |
714 | } | 701 | } |
715 | 702 | ||
716 | if (acpi_bus_add(device, pdev, handle, ACPI_BUS_TYPE_PROCESSOR)) { | 703 | if (acpi_bus_add(device, pdev, handle, ACPI_BUS_TYPE_PROCESSOR)) { |
717 | return_VALUE(-ENODEV); | 704 | return -ENODEV; |
718 | } | 705 | } |
719 | 706 | ||
720 | acpi_bus_start(*device); | 707 | acpi_bus_start(*device); |
721 | 708 | ||
722 | pr = acpi_driver_data(*device); | 709 | pr = acpi_driver_data(*device); |
723 | if (!pr) | 710 | if (!pr) |
724 | return_VALUE(-ENODEV); | 711 | return -ENODEV; |
725 | 712 | ||
726 | if ((pr->id >= 0) && (pr->id < NR_CPUS)) { | 713 | if ((pr->id >= 0) && (pr->id < NR_CPUS)) { |
727 | kobject_uevent(&(*device)->kobj, KOBJ_ONLINE); | 714 | kobject_uevent(&(*device)->kobj, KOBJ_ONLINE); |
728 | } | 715 | } |
729 | return_VALUE(0); | 716 | return 0; |
730 | } | 717 | } |
731 | 718 | ||
732 | static void | 719 | static void |
@@ -736,7 +723,6 @@ acpi_processor_hotplug_notify(acpi_handle handle, u32 event, void *data) | |||
736 | struct acpi_device *device = NULL; | 723 | struct acpi_device *device = NULL; |
737 | int result; | 724 | int result; |
738 | 725 | ||
739 | ACPI_FUNCTION_TRACE("acpi_processor_hotplug_notify"); | ||
740 | 726 | ||
741 | switch (event) { | 727 | switch (event) { |
742 | case ACPI_NOTIFY_BUS_CHECK: | 728 | case ACPI_NOTIFY_BUS_CHECK: |
@@ -788,7 +774,7 @@ acpi_processor_hotplug_notify(acpi_handle handle, u32 event, void *data) | |||
788 | if (!pr) { | 774 | if (!pr) { |
789 | printk(KERN_ERR PREFIX | 775 | printk(KERN_ERR PREFIX |
790 | "Driver data is NULL, dropping EJECT\n"); | 776 | "Driver data is NULL, dropping EJECT\n"); |
791 | return_VOID; | 777 | return; |
792 | } | 778 | } |
793 | 779 | ||
794 | if ((pr->id < NR_CPUS) && (cpu_present(pr->id))) | 780 | if ((pr->id < NR_CPUS) && (cpu_present(pr->id))) |
@@ -800,7 +786,7 @@ acpi_processor_hotplug_notify(acpi_handle handle, u32 event, void *data) | |||
800 | break; | 786 | break; |
801 | } | 787 | } |
802 | 788 | ||
803 | return_VOID; | 789 | return; |
804 | } | 790 | } |
805 | 791 | ||
806 | static acpi_status | 792 | static acpi_status |
@@ -839,21 +825,20 @@ processor_walk_namespace_cb(acpi_handle handle, | |||
839 | 825 | ||
840 | static acpi_status acpi_processor_hotadd_init(acpi_handle handle, int *p_cpu) | 826 | static acpi_status acpi_processor_hotadd_init(acpi_handle handle, int *p_cpu) |
841 | { | 827 | { |
842 | ACPI_FUNCTION_TRACE("acpi_processor_hotadd_init"); | ||
843 | 828 | ||
844 | if (!is_processor_present(handle)) { | 829 | if (!is_processor_present(handle)) { |
845 | return_VALUE(AE_ERROR); | 830 | return AE_ERROR; |
846 | } | 831 | } |
847 | 832 | ||
848 | if (acpi_map_lsapic(handle, p_cpu)) | 833 | if (acpi_map_lsapic(handle, p_cpu)) |
849 | return_VALUE(AE_ERROR); | 834 | return AE_ERROR; |
850 | 835 | ||
851 | if (arch_register_cpu(*p_cpu)) { | 836 | if (arch_register_cpu(*p_cpu)) { |
852 | acpi_unmap_lsapic(*p_cpu); | 837 | acpi_unmap_lsapic(*p_cpu); |
853 | return_VALUE(AE_ERROR); | 838 | return AE_ERROR; |
854 | } | 839 | } |
855 | 840 | ||
856 | return_VALUE(AE_OK); | 841 | return AE_OK; |
857 | } | 842 | } |
858 | 843 | ||
859 | static int acpi_processor_handle_eject(struct acpi_processor *pr) | 844 | static int acpi_processor_handle_eject(struct acpi_processor *pr) |
@@ -910,20 +895,19 @@ static int __init acpi_processor_init(void) | |||
910 | { | 895 | { |
911 | int result = 0; | 896 | int result = 0; |
912 | 897 | ||
913 | ACPI_FUNCTION_TRACE("acpi_processor_init"); | ||
914 | 898 | ||
915 | memset(&processors, 0, sizeof(processors)); | 899 | memset(&processors, 0, sizeof(processors)); |
916 | memset(&errata, 0, sizeof(errata)); | 900 | memset(&errata, 0, sizeof(errata)); |
917 | 901 | ||
918 | acpi_processor_dir = proc_mkdir(ACPI_PROCESSOR_CLASS, acpi_root_dir); | 902 | acpi_processor_dir = proc_mkdir(ACPI_PROCESSOR_CLASS, acpi_root_dir); |
919 | if (!acpi_processor_dir) | 903 | if (!acpi_processor_dir) |
920 | return_VALUE(0); | 904 | return 0; |
921 | acpi_processor_dir->owner = THIS_MODULE; | 905 | acpi_processor_dir->owner = THIS_MODULE; |
922 | 906 | ||
923 | result = acpi_bus_register_driver(&acpi_processor_driver); | 907 | result = acpi_bus_register_driver(&acpi_processor_driver); |
924 | if (result < 0) { | 908 | if (result < 0) { |
925 | remove_proc_entry(ACPI_PROCESSOR_CLASS, acpi_root_dir); | 909 | remove_proc_entry(ACPI_PROCESSOR_CLASS, acpi_root_dir); |
926 | return_VALUE(0); | 910 | return 0; |
927 | } | 911 | } |
928 | 912 | ||
929 | acpi_processor_install_hotplug_notify(); | 913 | acpi_processor_install_hotplug_notify(); |
@@ -932,12 +916,11 @@ static int __init acpi_processor_init(void) | |||
932 | 916 | ||
933 | acpi_processor_ppc_init(); | 917 | acpi_processor_ppc_init(); |
934 | 918 | ||
935 | return_VALUE(0); | 919 | return 0; |
936 | } | 920 | } |
937 | 921 | ||
938 | static void __exit acpi_processor_exit(void) | 922 | static void __exit acpi_processor_exit(void) |
939 | { | 923 | { |
940 | ACPI_FUNCTION_TRACE("acpi_processor_exit"); | ||
941 | 924 | ||
942 | acpi_processor_ppc_exit(); | 925 | acpi_processor_ppc_exit(); |
943 | 926 | ||
@@ -949,7 +932,7 @@ static void __exit acpi_processor_exit(void) | |||
949 | 932 | ||
950 | remove_proc_entry(ACPI_PROCESSOR_CLASS, acpi_root_dir); | 933 | remove_proc_entry(ACPI_PROCESSOR_CLASS, acpi_root_dir); |
951 | 934 | ||
952 | return_VOID; | 935 | return; |
953 | } | 936 | } |
954 | 937 | ||
955 | module_init(acpi_processor_init); | 938 | module_init(acpi_processor_init); |