aboutsummaryrefslogtreecommitdiffstats
path: root/block/blk-core.c
diff options
context:
space:
mode:
authorJens Axboe <axboe@fb.com>2015-07-24 14:37:59 -0400
committerJens Axboe <axboe@fb.com>2015-07-29 10:55:20 -0400
commitb7c44ed9d2fc6b461378c65eaf144ccc80a47772 (patch)
tree2f38bdc1cf7ea6c924f6e1d52cf5913c370e08b6 /block/blk-core.c
parent4246a0b63bd8f56a1469b12eafeb875b1041a451 (diff)
block: manipulate bio->bi_flags through helpers
Some places use helpers now, others don't. We only have the 'is set' helper, add helpers for setting and clearing flags too. It was a bit of a mess of atomic vs non-atomic access. With BIO_UPTODATE gone, we don't have any risk of concurrent access to the flags. So relax the restriction and don't make any of them atomic. The flags that do have serialization issues (reffed and chained), we already handle those separately. Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/blk-core.c')
-rw-r--r--block/blk-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-core.c b/block/blk-core.c
index 7ef15b947b91..d1796b54e97a 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -146,7 +146,7 @@ static void req_bio_endio(struct request *rq, struct bio *bio,
146 bio->bi_error = error; 146 bio->bi_error = error;
147 147
148 if (unlikely(rq->cmd_flags & REQ_QUIET)) 148 if (unlikely(rq->cmd_flags & REQ_QUIET))
149 set_bit(BIO_QUIET, &bio->bi_flags); 149 bio_set_flag(bio, BIO_QUIET);
150 150
151 bio_advance(bio, nbytes); 151 bio_advance(bio, nbytes);
152 152