aboutsummaryrefslogtreecommitdiffstats
path: root/block/blk-core.c
diff options
context:
space:
mode:
authorMike Christie <mchristi@redhat.com>2016-06-05 15:31:45 -0400
committerJens Axboe <axboe@fb.com>2016-06-07 15:41:38 -0400
commita8ebb056a8aeb58aafef0af241a6b3ac34ac86bd (patch)
treea656dfc59d3082470756b7828361eedfce5f49a5 /block/blk-core.c
parentdfec8a14fc9043039e3c04807caf39dc71102816 (diff)
block, drivers, cgroup: use op_is_write helper instead of checking for REQ_WRITE
We currently set REQ_WRITE/WRITE for all non READ IOs like discard, flush, writesame, etc. In the next patches where we no longer set up the op as a bitmap, we will not be able to detect a operation direction like writesame by testing if REQ_WRITE is set. This patch converts the drivers and cgroup to use the op_is_write helper. This should just cover the simple cases. I did dm, md and bcache in their own patches because they were more involved. Signed-off-by: Mike Christie <mchristi@redhat.com> Reviewed-by: Hannes Reinecke <hare@suse.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/blk-core.c')
-rw-r--r--block/blk-core.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/block/blk-core.c b/block/blk-core.c
index e95340789592..e8e5865a53e2 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2115,7 +2115,7 @@ blk_qc_t submit_bio(struct bio *bio)
2115 else 2115 else
2116 count = bio_sectors(bio); 2116 count = bio_sectors(bio);
2117 2117
2118 if (bio->bi_rw & WRITE) { 2118 if (op_is_write(bio_op(bio))) {
2119 count_vm_events(PGPGOUT, count); 2119 count_vm_events(PGPGOUT, count);
2120 } else { 2120 } else {
2121 task_io_account_read(bio->bi_iter.bi_size); 2121 task_io_account_read(bio->bi_iter.bi_size);
@@ -2126,7 +2126,7 @@ blk_qc_t submit_bio(struct bio *bio)
2126 char b[BDEVNAME_SIZE]; 2126 char b[BDEVNAME_SIZE];
2127 printk(KERN_DEBUG "%s(%d): %s block %Lu on %s (%u sectors)\n", 2127 printk(KERN_DEBUG "%s(%d): %s block %Lu on %s (%u sectors)\n",
2128 current->comm, task_pid_nr(current), 2128 current->comm, task_pid_nr(current),
2129 (bio->bi_rw & WRITE) ? "WRITE" : "READ", 2129 op_is_write(bio_op(bio)) ? "WRITE" : "READ",
2130 (unsigned long long)bio->bi_iter.bi_sector, 2130 (unsigned long long)bio->bi_iter.bi_sector,
2131 bdevname(bio->bi_bdev, b), 2131 bdevname(bio->bi_bdev, b),
2132 count); 2132 count);