diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2018-12-01 15:35:48 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-12-01 15:35:48 -0500 |
| commit | 4b78317679c4f3782a3cff0ddb269c1fcfde7621 (patch) | |
| tree | fd3d202ef58da346528625067bc139bc19b28726 /arch | |
| parent | 880584176ed7875117a5ba76cf316cb60f7ad30b (diff) | |
| parent | 55a974021ec952ee460dc31ca08722158639de72 (diff) | |
Merge branch 'x86-pti-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull STIBP fallout fixes from Thomas Gleixner:
"The performance destruction department finally got it's act together
and came up with a cure for the STIPB regression:
- Provide a command line option to control the spectre v2 user space
mitigations. Default is either seccomp or prctl (if seccomp is
disabled in Kconfig). prctl allows mitigation opt-in, seccomp
enables the migitation for sandboxed processes.
- Rework the code to handle the conditional STIBP/IBPB control and
remove the now unused ptrace_may_access_sched() optimization
attempt
- Disable STIBP automatically when SMT is disabled
- Optimize the switch_to() logic to avoid MSR writes and invocations
of __switch_to_xtra().
- Make the asynchronous speculation TIF updates synchronous to
prevent stale mitigation state.
As a general cleanup this also makes retpoline directly depend on
compiler support and removes the 'minimal retpoline' option which just
pretended to provide some form of security while providing none"
* 'x86-pti-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (31 commits)
x86/speculation: Provide IBPB always command line options
x86/speculation: Add seccomp Spectre v2 user space protection mode
x86/speculation: Enable prctl mode for spectre_v2_user
x86/speculation: Add prctl() control for indirect branch speculation
x86/speculation: Prepare arch_smt_update() for PRCTL mode
x86/speculation: Prevent stale SPEC_CTRL msr content
x86/speculation: Split out TIF update
ptrace: Remove unused ptrace_may_access_sched() and MODE_IBRS
x86/speculation: Prepare for conditional IBPB in switch_mm()
x86/speculation: Avoid __switch_to_xtra() calls
x86/process: Consolidate and simplify switch_to_xtra() code
x86/speculation: Prepare for per task indirect branch speculation control
x86/speculation: Add command line control for indirect branch speculation
x86/speculation: Unify conditional spectre v2 print functions
x86/speculataion: Mark command line parser data __initdata
x86/speculation: Mark string arrays const correctly
x86/speculation: Reorder the spec_v2 code
x86/l1tf: Show actual SMT state
x86/speculation: Rework SMT state change
sched/smt: Expose sched_smt_present static key
...
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/Kconfig | 12 | ||||
| -rw-r--r-- | arch/x86/Makefile | 5 | ||||
| -rw-r--r-- | arch/x86/include/asm/msr-index.h | 5 | ||||
| -rw-r--r-- | arch/x86/include/asm/nospec-branch.h | 26 | ||||
| -rw-r--r-- | arch/x86/include/asm/spec-ctrl.h | 20 | ||||
| -rw-r--r-- | arch/x86/include/asm/switch_to.h | 3 | ||||
| -rw-r--r-- | arch/x86/include/asm/thread_info.h | 20 | ||||
| -rw-r--r-- | arch/x86/include/asm/tlbflush.h | 8 | ||||
| -rw-r--r-- | arch/x86/kernel/cpu/bugs.c | 525 | ||||
| -rw-r--r-- | arch/x86/kernel/process.c | 101 | ||||
| -rw-r--r-- | arch/x86/kernel/process.h | 39 | ||||
| -rw-r--r-- | arch/x86/kernel/process_32.c | 10 | ||||
| -rw-r--r-- | arch/x86/kernel/process_64.c | 10 | ||||
| -rw-r--r-- | arch/x86/mm/tlb.c | 115 |
14 files changed, 665 insertions, 234 deletions
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 9d734f3c8234..8689e794a43c 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig | |||
| @@ -444,10 +444,6 @@ config RETPOLINE | |||
| 444 | branches. Requires a compiler with -mindirect-branch=thunk-extern | 444 | branches. Requires a compiler with -mindirect-branch=thunk-extern |
| 445 | support for full protection. The kernel may run slower. | 445 | support for full protection. The kernel may run slower. |
| 446 | 446 | ||
| 447 | Without compiler support, at least indirect branches in assembler | ||
| 448 | code are eliminated. Since this includes the syscall entry path, | ||
| 449 | it is not entirely pointless. | ||
| 450 | |||
| 451 | config INTEL_RDT | 447 | config INTEL_RDT |
| 452 | bool "Intel Resource Director Technology support" | 448 | bool "Intel Resource Director Technology support" |
| 453 | depends on X86 && CPU_SUP_INTEL | 449 | depends on X86 && CPU_SUP_INTEL |
| @@ -1004,13 +1000,7 @@ config NR_CPUS | |||
| 1004 | to the kernel image. | 1000 | to the kernel image. |
| 1005 | 1001 | ||
| 1006 | config SCHED_SMT | 1002 | config SCHED_SMT |
| 1007 | bool "SMT (Hyperthreading) scheduler support" | 1003 | def_bool y if SMP |
| 1008 | depends on SMP | ||
| 1009 | ---help--- | ||
| 1010 | SMT scheduler support improves the CPU scheduler's decision making | ||
| 1011 | when dealing with Intel Pentium 4 chips with HyperThreading at a | ||
| 1012 | cost of slightly increased overhead in some places. If unsure say | ||
| 1013 | N here. | ||
| 1014 | 1004 | ||
| 1015 | config SCHED_MC | 1005 | config SCHED_MC |
| 1016 | def_bool y | 1006 | def_bool y |
diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 88398fdf8129..f5d7f4134524 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile | |||
| @@ -220,9 +220,10 @@ KBUILD_CFLAGS += -fno-asynchronous-unwind-tables | |||
| 220 | 220 | ||
| 221 | # Avoid indirect branches in kernel to deal with Spectre | 221 | # Avoid indirect branches in kernel to deal with Spectre |
| 222 | ifdef CONFIG_RETPOLINE | 222 | ifdef CONFIG_RETPOLINE |
| 223 | ifneq ($(RETPOLINE_CFLAGS),) | 223 | ifeq ($(RETPOLINE_CFLAGS),) |
| 224 | KBUILD_CFLAGS += $(RETPOLINE_CFLAGS) -DRETPOLINE | 224 | $(error You are building kernel with non-retpoline compiler, please update your compiler.) |
| 225 | endif | 225 | endif |
| 226 | KBUILD_CFLAGS += $(RETPOLINE_CFLAGS) | ||
| 226 | endif | 227 | endif |
| 227 | 228 | ||
| 228 | archscripts: scripts_basic | 229 | archscripts: scripts_basic |
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 80f4a4f38c79..c8f73efb4ece 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h | |||
| @@ -41,9 +41,10 @@ | |||
| 41 | 41 | ||
| 42 | #define MSR_IA32_SPEC_CTRL 0x00000048 /* Speculation Control */ | 42 | #define MSR_IA32_SPEC_CTRL 0x00000048 /* Speculation Control */ |
| 43 | #define SPEC_CTRL_IBRS (1 << 0) /* Indirect Branch Restricted Speculation */ | 43 | #define SPEC_CTRL_IBRS (1 << 0) /* Indirect Branch Restricted Speculation */ |
| 44 | #define SPEC_CTRL_STIBP (1 << 1) /* Single Thread Indirect Branch Predictors */ | 44 | #define SPEC_CTRL_STIBP_SHIFT 1 /* Single Thread Indirect Branch Predictor (STIBP) bit */ |
| 45 | #define SPEC_CTRL_STIBP (1 << SPEC_CTRL_STIBP_SHIFT) /* STIBP mask */ | ||
| 45 | #define SPEC_CTRL_SSBD_SHIFT 2 /* Speculative Store Bypass Disable bit */ | 46 | #define SPEC_CTRL_SSBD_SHIFT 2 /* Speculative Store Bypass Disable bit */ |
| 46 | #define SPEC_CTRL_SSBD (1 << SPEC_CTRL_SSBD_SHIFT) /* Speculative Store Bypass Disable */ | 47 | #define SPEC_CTRL_SSBD (1 << SPEC_CTRL_SSBD_SHIFT) /* Speculative Store Bypass Disable */ |
| 47 | 48 | ||
| 48 | #define MSR_IA32_PRED_CMD 0x00000049 /* Prediction Command */ | 49 | #define MSR_IA32_PRED_CMD 0x00000049 /* Prediction Command */ |
| 49 | #define PRED_CMD_IBPB (1 << 0) /* Indirect Branch Prediction Barrier */ | 50 | #define PRED_CMD_IBPB (1 << 0) /* Indirect Branch Prediction Barrier */ |
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h index 80dc14422495..032b6009baab 100644 --- a/arch/x86/include/asm/nospec-branch.h +++ b/arch/x86/include/asm/nospec-branch.h | |||
| @@ -3,6 +3,8 @@ | |||
| 3 | #ifndef _ASM_X86_NOSPEC_BRANCH_H_ | 3 | #ifndef _ASM_X86_NOSPEC_BRANCH_H_ |
| 4 | #define _ASM_X86_NOSPEC_BRANCH_H_ | 4 | #define _ASM_X86_NOSPEC_BRANCH_H_ |
| 5 | 5 | ||
| 6 | #include <linux/static_key.h> | ||
| 7 | |||
| 6 | #include <asm/alternative.h> | 8 | #include <asm/alternative.h> |
| 7 | #include <asm/alternative-asm.h> | 9 | #include <asm/alternative-asm.h> |
| 8 | #include <asm/cpufeatures.h> | 10 | #include <asm/cpufeatures.h> |
| @@ -162,11 +164,12 @@ | |||
| 162 | _ASM_PTR " 999b\n\t" \ | 164 | _ASM_PTR " 999b\n\t" \ |
| 163 | ".popsection\n\t" | 165 | ".popsection\n\t" |
| 164 | 166 | ||
| 165 | #if defined(CONFIG_X86_64) && defined(RETPOLINE) | 167 | #ifdef CONFIG_RETPOLINE |
| 168 | #ifdef CONFIG_X86_64 | ||
| 166 | 169 | ||
| 167 | /* | 170 | /* |
| 168 | * Since the inline asm uses the %V modifier which is only in newer GCC, | 171 | * Inline asm uses the %V modifier which is only in newer GCC |
| 169 | * the 64-bit one is dependent on RETPOLINE not CONFIG_RETPOLINE. | 172 | * which is ensured when CONFIG_RETPOLINE is defined. |
| 170 | */ | 173 | */ |
| 171 | # define CALL_NOSPEC \ | 174 | # define CALL_NOSPEC \ |
| 172 | ANNOTATE_NOSPEC_ALTERNATIVE \ | 175 | ANNOTATE_NOSPEC_ALTERNATIVE \ |
| @@ -181,7 +184,7 @@ | |||
| 181 | X86_FEATURE_RETPOLINE_AMD) | 184 | X86_FEATURE_RETPOLINE_AMD) |
| 182 | # define THUNK_TARGET(addr) [thunk_target] "r" (addr) | 185 | # define THUNK_TARGET(addr) [thunk_target] "r" (addr) |
| 183 | 186 | ||
| 184 | #elif defined(CONFIG_X86_32) && defined(CONFIG_RETPOLINE) | 187 | #else /* CONFIG_X86_32 */ |
| 185 | /* | 188 | /* |
| 186 | * For i386 we use the original ret-equivalent retpoline, because | 189 | * For i386 we use the original ret-equivalent retpoline, because |
| 187 | * otherwise we'll run out of registers. We don't care about CET | 190 | * otherwise we'll run out of registers. We don't care about CET |
| @@ -211,6 +214,7 @@ | |||
| 211 | X86_FEATURE_RETPOLINE_AMD) | 214 | X86_FEATURE_RETPOLINE_AMD) |
| 212 | 215 | ||
| 213 | # define THUNK_TARGET(addr) [thunk_target] "rm" (addr) | 216 | # define THUNK_TARGET(addr) [thunk_target] "rm" (addr) |
| 217 | #endif | ||
| 214 | #else /* No retpoline for C / inline asm */ | 218 | #else /* No retpoline for C / inline asm */ |
| 215 | # define CALL_NOSPEC "call *%[thunk_target]\n" | 219 | # define CALL_NOSPEC "call *%[thunk_target]\n" |
| 216 | # define THUNK_TARGET(addr) [thunk_target] "rm" (addr) | 220 | # define THUNK_TARGET(addr) [thunk_target] "rm" (addr) |
| @@ -219,13 +223,19 @@ | |||
| 219 | /* The Spectre V2 mitigation variants */ | 223 | /* The Spectre V2 mitigation variants */ |
| 220 | enum spectre_v2_mitigation { | 224 | enum spectre_v2_mitigation { |
| 221 | SPECTRE_V2_NONE, | 225 | SPECTRE_V2_NONE, |
| 222 | SPECTRE_V2_RETPOLINE_MINIMAL, | ||
| 223 | SPECTRE_V2_RETPOLINE_MINIMAL_AMD, | ||
| 224 | SPECTRE_V2_RETPOLINE_GENERIC, | 226 | SPECTRE_V2_RETPOLINE_GENERIC, |
| 225 | SPECTRE_V2_RETPOLINE_AMD, | 227 | SPECTRE_V2_RETPOLINE_AMD, |
| 226 | SPECTRE_V2_IBRS_ENHANCED, | 228 | SPECTRE_V2_IBRS_ENHANCED, |
| 227 | }; | 229 | }; |
| 228 | 230 | ||
| 231 | /* The indirect branch speculation control variants */ | ||
| 232 | enum spectre_v2_user_mitigation { | ||
| 233 | SPECTRE_V2_USER_NONE, | ||
| 234 | SPECTRE_V2_USER_STRICT, | ||
| 235 | SPECTRE_V2_USER_PRCTL, | ||
| 236 | SPECTRE_V2_USER_SECCOMP, | ||
| 237 | }; | ||
| 238 | |||
| 229 | /* The Speculative Store Bypass disable variants */ | 239 | /* The Speculative Store Bypass disable variants */ |
| 230 | enum ssb_mitigation { | 240 | enum ssb_mitigation { |
| 231 | SPEC_STORE_BYPASS_NONE, | 241 | SPEC_STORE_BYPASS_NONE, |
| @@ -303,6 +313,10 @@ do { \ | |||
| 303 | preempt_enable(); \ | 313 | preempt_enable(); \ |
| 304 | } while (0) | 314 | } while (0) |
| 305 | 315 | ||
| 316 | DECLARE_STATIC_KEY_FALSE(switch_to_cond_stibp); | ||
| 317 | DECLARE_STATIC_KEY_FALSE(switch_mm_cond_ibpb); | ||
| 318 | DECLARE_STATIC_KEY_FALSE(switch_mm_always_ibpb); | ||
| 319 | |||
| 306 | #endif /* __ASSEMBLY__ */ | 320 | #endif /* __ASSEMBLY__ */ |
| 307 | 321 | ||
| 308 | /* | 322 | /* |
diff --git a/arch/x86/include/asm/spec-ctrl.h b/arch/x86/include/asm/spec-ctrl.h index ae7c2c5cd7f0..5393babc0598 100644 --- a/arch/x86/include/asm/spec-ctrl.h +++ b/arch/x86/include/asm/spec-ctrl.h | |||
| @@ -53,12 +53,24 @@ static inline u64 ssbd_tif_to_spec_ctrl(u64 tifn) | |||
| 53 | return (tifn & _TIF_SSBD) >> (TIF_SSBD - SPEC_CTRL_SSBD_SHIFT); | 53 | return (tifn & _TIF_SSBD) >> (TIF_SSBD - SPEC_CTRL_SSBD_SHIFT); |
| 54 | } | 54 | } |
| 55 | 55 | ||
| 56 | static inline u64 stibp_tif_to_spec_ctrl(u64 tifn) | ||
| 57 | { | ||
| 58 | BUILD_BUG_ON(TIF_SPEC_IB < SPEC_CTRL_STIBP_SHIFT); | ||
| 59 | return (tifn & _TIF_SPEC_IB) >> (TIF_SPEC_IB - SPEC_CTRL_STIBP_SHIFT); | ||
| 60 | } | ||
| 61 | |||
| 56 | static inline unsigned long ssbd_spec_ctrl_to_tif(u64 spec_ctrl) | 62 | static inline unsigned long ssbd_spec_ctrl_to_tif(u64 spec_ctrl) |
| 57 | { | 63 | { |
| 58 | BUILD_BUG_ON(TIF_SSBD < SPEC_CTRL_SSBD_SHIFT); | 64 | BUILD_BUG_ON(TIF_SSBD < SPEC_CTRL_SSBD_SHIFT); |
| 59 | return (spec_ctrl & SPEC_CTRL_SSBD) << (TIF_SSBD - SPEC_CTRL_SSBD_SHIFT); | 65 | return (spec_ctrl & SPEC_CTRL_SSBD) << (TIF_SSBD - SPEC_CTRL_SSBD_SHIFT); |
| 60 | } | 66 | } |
| 61 | 67 | ||
| 68 | static inline unsigned long stibp_spec_ctrl_to_tif(u64 spec_ctrl) | ||
| 69 | { | ||
| 70 | BUILD_BUG_ON(TIF_SPEC_IB < SPEC_CTRL_STIBP_SHIFT); | ||
| 71 | return (spec_ctrl & SPEC_CTRL_STIBP) << (TIF_SPEC_IB - SPEC_CTRL_STIBP_SHIFT); | ||
| 72 | } | ||
| 73 | |||
| 62 | static inline u64 ssbd_tif_to_amd_ls_cfg(u64 tifn) | 74 | static inline u64 ssbd_tif_to_amd_ls_cfg(u64 tifn) |
| 63 | { | 75 | { |
| 64 | return (tifn & _TIF_SSBD) ? x86_amd_ls_cfg_ssbd_mask : 0ULL; | 76 | return (tifn & _TIF_SSBD) ? x86_amd_ls_cfg_ssbd_mask : 0ULL; |
| @@ -70,11 +82,7 @@ extern void speculative_store_bypass_ht_init(void); | |||
| 70 | static inline void speculative_store_bypass_ht_init(void) { } | 82 | static inline void speculative_store_bypass_ht_init(void) { } |
| 71 | #endif | 83 | #endif |
| 72 | 84 | ||
| 73 | extern void speculative_store_bypass_update(unsigned long tif); | 85 | extern void speculation_ctrl_update(unsigned long tif); |
| 74 | 86 | extern void speculation_ctrl_update_current(void); | |
| 75 | static inline void speculative_store_bypass_update_current(void) | ||
| 76 | { | ||
| 77 | speculative_store_bypass_update(current_thread_info()->flags); | ||
| 78 | } | ||
| 79 | 87 | ||
| 80 | #endif | 88 | #endif |
diff --git a/arch/x86/include/asm/switch_to.h b/arch/x86/include/asm/switch_to.h index 36bd243843d6..7cf1a270d891 100644 --- a/arch/x86/include/asm/switch_to.h +++ b/arch/x86/include/asm/switch_to.h | |||
| @@ -11,9 +11,6 @@ struct task_struct *__switch_to_asm(struct task_struct *prev, | |||
| 11 | 11 | ||
| 12 | __visible struct task_struct *__switch_to(struct task_struct *prev, | 12 | __visible struct task_struct *__switch_to(struct task_struct *prev, |
| 13 | struct task_struct *next); | 13 | struct task_struct *next); |
| 14 | struct tss_struct; | ||
| 15 | void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p, | ||
| 16 | struct tss_struct *tss); | ||
| 17 | 14 | ||
| 18 | /* This runs runs on the previous thread's stack. */ | 15 | /* This runs runs on the previous thread's stack. */ |
| 19 | static inline void prepare_switch_to(struct task_struct *next) | 16 | static inline void prepare_switch_to(struct task_struct *next) |
diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h index 2ff2a30a264f..82b73b75d67c 100644 --- a/arch/x86/include/asm/thread_info.h +++ b/arch/x86/include/asm/thread_info.h | |||
| @@ -79,10 +79,12 @@ struct thread_info { | |||
| 79 | #define TIF_SIGPENDING 2 /* signal pending */ | 79 | #define TIF_SIGPENDING 2 /* signal pending */ |
| 80 | #define TIF_NEED_RESCHED 3 /* rescheduling necessary */ | 80 | #define TIF_NEED_RESCHED 3 /* rescheduling necessary */ |
| 81 | #define TIF_SINGLESTEP 4 /* reenable singlestep on user return*/ | 81 | #define TIF_SINGLESTEP 4 /* reenable singlestep on user return*/ |
| 82 | #define TIF_SSBD 5 /* Reduced data speculation */ | 82 | #define TIF_SSBD 5 /* Speculative store bypass disable */ |
| 83 | #define TIF_SYSCALL_EMU 6 /* syscall emulation active */ | 83 | #define TIF_SYSCALL_EMU 6 /* syscall emulation active */ |
| 84 | #define TIF_SYSCALL_AUDIT 7 /* syscall auditing active */ | 84 | #define TIF_SYSCALL_AUDIT 7 /* syscall auditing active */ |
| 85 | #define TIF_SECCOMP 8 /* secure computing */ | 85 | #define TIF_SECCOMP 8 /* secure computing */ |
| 86 | #define TIF_SPEC_IB 9 /* Indirect branch speculation mitigation */ | ||
| 87 | #define TIF_SPEC_FORCE_UPDATE 10 /* Force speculation MSR update in context switch */ | ||
| 86 | #define TIF_USER_RETURN_NOTIFY 11 /* notify kernel of userspace return */ | 88 | #define TIF_USER_RETURN_NOTIFY 11 /* notify kernel of userspace return */ |
| 87 | #define TIF_UPROBE 12 /* breakpointed or singlestepping */ | 89 | #define TIF_UPROBE 12 /* breakpointed or singlestepping */ |
| 88 | #define TIF_PATCH_PENDING 13 /* pending live patching update */ | 90 | #define TIF_PATCH_PENDING 13 /* pending live patching update */ |
| @@ -110,6 +112,8 @@ struct thread_info { | |||
| 110 | #define _TIF_SYSCALL_EMU (1 << TIF_SYSCALL_EMU) | 112 | #define _TIF_SYSCALL_EMU (1 << TIF_SYSCALL_EMU) |
| 111 | #define _TIF_SYSCALL_AUDIT (1 << TIF_SYSCALL_AUDIT) | 113 | #define _TIF_SYSCALL_AUDIT (1 << TIF_SYSCALL_AUDIT) |
| 112 | #define _TIF_SECCOMP (1 << TIF_SECCOMP) | 114 | #define _TIF_SECCOMP (1 << TIF_SECCOMP) |
| 115 | #define _TIF_SPEC_IB (1 << TIF_SPEC_IB) | ||
| 116 | #define _TIF_SPEC_FORCE_UPDATE (1 << TIF_SPEC_FORCE_UPDATE) | ||
| 113 | #define _TIF_USER_RETURN_NOTIFY (1 << TIF_USER_RETURN_NOTIFY) | 117 | #define _TIF_USER_RETURN_NOTIFY (1 << TIF_USER_RETURN_NOTIFY) |
| 114 | #define _TIF_UPROBE (1 << TIF_UPROBE) | 118 | #define _TIF_UPROBE (1 << TIF_UPROBE) |
| 115 | #define _TIF_PATCH_PENDING (1 << TIF_PATCH_PENDING) | 119 | #define _TIF_PATCH_PENDING (1 << TIF_PATCH_PENDING) |
| @@ -145,8 +149,18 @@ struct thread_info { | |||
| 145 | _TIF_FSCHECK) | 149 | _TIF_FSCHECK) |
| 146 | 150 | ||
| 147 | /* flags to check in __switch_to() */ | 151 | /* flags to check in __switch_to() */ |
| 148 | #define _TIF_WORK_CTXSW \ | 152 | #define _TIF_WORK_CTXSW_BASE \ |
| 149 | (_TIF_IO_BITMAP|_TIF_NOCPUID|_TIF_NOTSC|_TIF_BLOCKSTEP|_TIF_SSBD) | 153 | (_TIF_IO_BITMAP|_TIF_NOCPUID|_TIF_NOTSC|_TIF_BLOCKSTEP| \ |
| 154 | _TIF_SSBD | _TIF_SPEC_FORCE_UPDATE) | ||
| 155 | |||
| 156 | /* | ||
| 157 | * Avoid calls to __switch_to_xtra() on UP as STIBP is not evaluated. | ||
| 158 | */ | ||
| 159 | #ifdef CONFIG_SMP | ||
| 160 | # define _TIF_WORK_CTXSW (_TIF_WORK_CTXSW_BASE | _TIF_SPEC_IB) | ||
| 161 | #else | ||
| 162 | # define _TIF_WORK_CTXSW (_TIF_WORK_CTXSW_BASE) | ||
| 163 | #endif | ||
| 150 | 164 | ||
| 151 | #define _TIF_WORK_CTXSW_PREV (_TIF_WORK_CTXSW|_TIF_USER_RETURN_NOTIFY) | 165 | #define _TIF_WORK_CTXSW_PREV (_TIF_WORK_CTXSW|_TIF_USER_RETURN_NOTIFY) |
| 152 | #define _TIF_WORK_CTXSW_NEXT (_TIF_WORK_CTXSW) | 166 | #define _TIF_WORK_CTXSW_NEXT (_TIF_WORK_CTXSW) |
diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h index d760611cfc35..f4204bf377fc 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h | |||
| @@ -169,10 +169,14 @@ struct tlb_state { | |||
| 169 | 169 | ||
| 170 | #define LOADED_MM_SWITCHING ((struct mm_struct *)1) | 170 | #define LOADED_MM_SWITCHING ((struct mm_struct *)1) |
| 171 | 171 | ||
| 172 | /* Last user mm for optimizing IBPB */ | ||
| 173 | union { | ||
| 174 | struct mm_struct *last_user_mm; | ||
| 175 | unsigned long last_user_mm_ibpb; | ||
| 176 | }; | ||
| 177 | |||
| 172 | u16 loaded_mm_asid; | 178 | u16 loaded_mm_asid; |
| 173 | u16 next_asid; | 179 | u16 next_asid; |
| 174 | /* last user mm's ctx id */ | ||
| 175 | u64 last_ctx_id; | ||
| 176 | 180 | ||
| 177 | /* | 181 | /* |
| 178 | * We can be in one of several states: | 182 | * We can be in one of several states: |
diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c index c37e66e493bf..500278f5308e 100644 --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c | |||
| @@ -14,6 +14,7 @@ | |||
| 14 | #include <linux/module.h> | 14 | #include <linux/module.h> |
| 15 | #include <linux/nospec.h> | 15 | #include <linux/nospec.h> |
| 16 | #include <linux/prctl.h> | 16 | #include <linux/prctl.h> |
| 17 | #include <linux/sched/smt.h> | ||
| 17 | 18 | ||
| 18 | #include <asm/spec-ctrl.h> | 19 | #include <asm/spec-ctrl.h> |
| 19 | #include <asm/cmdline.h> | 20 | #include <asm/cmdline.h> |
| @@ -53,6 +54,13 @@ static u64 __ro_after_init x86_spec_ctrl_mask = SPEC_CTRL_IBRS; | |||
| 53 | u64 __ro_after_init x86_amd_ls_cfg_base; | 54 | u64 __ro_after_init x86_amd_ls_cfg_base; |
| 54 | u64 __ro_after_init x86_amd_ls_cfg_ssbd_mask; | 55 | u64 __ro_after_init x86_amd_ls_cfg_ssbd_mask; |
| 55 | 56 | ||
| 57 | /* Control conditional STIPB in switch_to() */ | ||
| 58 | DEFINE_STATIC_KEY_FALSE(switch_to_cond_stibp); | ||
| 59 | /* Control conditional IBPB in switch_mm() */ | ||
| 60 | DEFINE_STATIC_KEY_FALSE(switch_mm_cond_ibpb); | ||
| 61 | /* Control unconditional IBPB in switch_mm() */ | ||
| 62 | DEFINE_STATIC_KEY_FALSE(switch_mm_always_ibpb); | ||
| 63 | |||
| 56 | void __init check_bugs(void) | 64 | void __init check_bugs(void) |
| 57 | { | 65 | { |
| 58 | identify_boot_cpu(); | 66 | identify_boot_cpu(); |
| @@ -123,31 +131,6 @@ void __init check_bugs(void) | |||
| 123 | #endif | 131 | #endif |
| 124 | } | 132 | } |
| 125 | 133 | ||
| 126 | /* The kernel command line selection */ | ||
| 127 | enum spectre_v2_mitigation_cmd { | ||
| 128 | SPECTRE_V2_CMD_NONE, | ||
| 129 | SPECTRE_V2_CMD_AUTO, | ||
| 130 | SPECTRE_V2_CMD_FORCE, | ||
| 131 | SPECTRE_V2_CMD_RETPOLINE, | ||
| 132 | SPECTRE_V2_CMD_RETPOLINE_GENERIC, | ||
| 133 | SPECTRE_V2_CMD_RETPOLINE_AMD, | ||
| 134 | }; | ||
| 135 | |||
| 136 | static const char *spectre_v2_strings[] = { | ||
| 137 | [SPECTRE_V2_NONE] = "Vulnerable", | ||
| 138 | [SPECTRE_V2_RETPOLINE_MINIMAL] = "Vulnerable: Minimal generic ASM retpoline", | ||
| 139 | [SPECTRE_V2_RETPOLINE_MINIMAL_AMD] = "Vulnerable: Minimal AMD ASM retpoline", | ||
| 140 | [SPECTRE_V2_RETPOLINE_GENERIC] = "Mitigation: Full generic retpoline", | ||
| 141 | [SPECTRE_V2_RETPOLINE_AMD] = "Mitigation: Full AMD retpoline", | ||
| 142 | [SPECTRE_V2_IBRS_ENHANCED] = "Mitigation: Enhanced IBRS", | ||
| 143 | }; | ||
| 144 | |||
| 145 | #undef pr_fmt | ||
| 146 | #define pr_fmt(fmt) "Spectre V2 : " fmt | ||
| 147 | |||
| 148 | static enum spectre_v2_mitigation spectre_v2_enabled __ro_after_init = | ||
| 149 | SPECTRE_V2_NONE; | ||
| 150 | |||
| 151 | void | 134 | void |
| 152 | x86_virt_spec_ctrl(u64 guest_spec_ctrl, u64 guest_virt_spec_ctrl, bool setguest) | 135 | x86_virt_spec_ctrl(u64 guest_spec_ctrl, u64 guest_virt_spec_ctrl, bool setguest) |
| 153 | { | 136 | { |
| @@ -169,6 +152,10 @@ x86_virt_spec_ctrl(u64 guest_spec_ctrl, u64 guest_virt_spec_ctrl, bool setguest) | |||
| 169 | static_cpu_has(X86_FEATURE_AMD_SSBD)) | 152 | static_cpu_has(X86_FEATURE_AMD_SSBD)) |
| 170 | hostval |= ssbd_tif_to_spec_ctrl(ti->flags); | 153 | hostval |= ssbd_tif_to_spec_ctrl(ti->flags); |
| 171 | 154 | ||
| 155 | /* Conditional STIBP enabled? */ | ||
| 156 | if (static_branch_unlikely(&switch_to_cond_stibp)) | ||
| 157 | hostval |= stibp_tif_to_spec_ctrl(ti->flags); | ||
| 158 | |||
| 172 | if (hostval != guestval) { | 159 | if (hostval != guestval) { |
| 173 | msrval = setguest ? guestval : hostval; | 160 | msrval = setguest ? guestval : hostval; |
| 174 | wrmsrl(MSR_IA32_SPEC_CTRL, msrval); | 161 | wrmsrl(MSR_IA32_SPEC_CTRL, msrval); |
| @@ -202,7 +189,7 @@ x86_virt_spec_ctrl(u64 guest_spec_ctrl, u64 guest_virt_spec_ctrl, bool setguest) | |||
| 202 | tif = setguest ? ssbd_spec_ctrl_to_tif(guestval) : | 189 | tif = setguest ? ssbd_spec_ctrl_to_tif(guestval) : |
| 203 | ssbd_spec_ctrl_to_tif(hostval); | 190 | ssbd_spec_ctrl_to_tif(hostval); |
| 204 | 191 | ||
| 205 | speculative_store_bypass_update(tif); | 192 | speculation_ctrl_update(tif); |
| 206 | } | 193 | } |
| 207 | } | 194 | } |
| 208 | EXPORT_SYMBOL_GPL(x86_virt_spec_ctrl); | 195 | EXPORT_SYMBOL_GPL(x86_virt_spec_ctrl); |
| @@ -217,6 +204,15 @@ static void x86_amd_ssb_disable(void) | |||
| 217 | wrmsrl(MSR_AMD64_LS_CFG, msrval); | 204 | wrmsrl(MSR_AMD64_LS_CFG, msrval); |
| 218 | } | 205 | } |
| 219 | 206 | ||
| 207 | #undef pr_fmt | ||
| 208 | #define pr_fmt(fmt) "Spectre V2 : " fmt | ||
| 209 | |||
| 210 | static enum spectre_v2_mitigation spectre_v2_enabled __ro_after_init = | ||
| 211 | SPECTRE_V2_NONE; | ||
| 212 | |||
| 213 | static enum spectre_v2_user_mitigation spectre_v2_user __ro_after_init = | ||
| 214 | SPECTRE_V2_USER_NONE; | ||
| 215 | |||
| 220 | #ifdef RETPOLINE | 216 | #ifdef RETPOLINE |
| 221 | static bool spectre_v2_bad_module; | 217 | static bool spectre_v2_bad_module; |
| 222 | 218 | ||
| @@ -238,67 +234,217 @@ static inline const char *spectre_v2_module_string(void) | |||
| 238 | static inline const char *spectre_v2_module_string(void) { return ""; } | 234 | static inline const char *spectre_v2_module_string(void) { return ""; } |
| 239 | #endif | 235 | #endif |
| 240 | 236 | ||
| 241 | static void __init spec2_print_if_insecure(const char *reason) | 237 | static inline bool match_option(const char *arg, int arglen, const char *opt) |
| 242 | { | 238 | { |
| 243 | if (boot_cpu_has_bug(X86_BUG_SPECTRE_V2)) | 239 | int len = strlen(opt); |
| 244 | pr_info("%s selected on command line.\n", reason); | 240 | |
| 241 | return len == arglen && !strncmp(arg, opt, len); | ||
| 245 | } | 242 | } |
| 246 | 243 | ||
| 247 | static void __init spec2_print_if_secure(const char *reason) | 244 | /* The kernel command line selection for spectre v2 */ |
| 245 | enum spectre_v2_mitigation_cmd { | ||
| 246 | SPECTRE_V2_CMD_NONE, | ||
| 247 | SPECTRE_V2_CMD_AUTO, | ||
| 248 | SPECTRE_V2_CMD_FORCE, | ||
| 249 | SPECTRE_V2_CMD_RETPOLINE, | ||
| 250 | SPECTRE_V2_CMD_RETPOLINE_GENERIC, | ||
| 251 | SPECTRE_V2_CMD_RETPOLINE_AMD, | ||
| 252 | }; | ||
| 253 | |||
| 254 | enum spectre_v2_user_cmd { | ||
| 255 | SPECTRE_V2_USER_CMD_NONE, | ||
| 256 | SPECTRE_V2_USER_CMD_AUTO, | ||
| 257 | SPECTRE_V2_USER_CMD_FORCE, | ||
| 258 | SPECTRE_V2_USER_CMD_PRCTL, | ||
| 259 | SPECTRE_V2_USER_CMD_PRCTL_IBPB, | ||
| 260 | SPECTRE_V2_USER_CMD_SECCOMP, | ||
| 261 | SPECTRE_V2_USER_CMD_SECCOMP_IBPB, | ||
| 262 | }; | ||
| 263 | |||
| 264 | static const char * const spectre_v2_user_strings[] = { | ||
| 265 | [SPECTRE_V2_USER_NONE] = "User space: Vulnerable", | ||
| 266 | [SPECTRE_V2_USER_STRICT] = "User space: Mitigation: STIBP protection", | ||
| 267 | [SPECTRE_V2_USER_PRCTL] = "User space: Mitigation: STIBP via prctl", | ||
| 268 | [SPECTRE_V2_USER_SECCOMP] = "User space: Mitigation: STIBP via seccomp and prctl", | ||
| 269 | }; | ||
| 270 | |||
| 271 | static const struct { | ||
| 272 | const char *option; | ||
| 273 | enum spectre_v2_user_cmd cmd; | ||
| 274 | bool secure; | ||
| 275 | } v2_user_options[] __initdata = { | ||
| 276 | { "auto", SPECTRE_V2_USER_CMD_AUTO, false }, | ||
| 277 | { "off", SPECTRE_V2_USER_CMD_NONE, false }, | ||
| 278 | { "on", SPECTRE_V2_USER_CMD_FORCE, true }, | ||
| 279 | { "prctl", SPECTRE_V2_USER_CMD_PRCTL, false }, | ||
| 280 | { "prctl,ibpb", SPECTRE_V2_USER_CMD_PRCTL_IBPB, false }, | ||
| 281 | { "seccomp", SPECTRE_V2_USER_CMD_SECCOMP, false }, | ||
| 282 | { "seccomp,ibpb", SPECTRE_V2_USER_CMD_SECCOMP_IBPB, false }, | ||
| 283 | }; | ||
| 284 | |||
| 285 | static void __init spec_v2_user_print_cond(const char *reason, bool secure) | ||
| 248 | { | 286 | { |
| 249 | if (!boot_cpu_has_bug(X86_BUG_SPECTRE_V2)) | 287 | if (boot_cpu_has_bug(X86_BUG_SPECTRE_V2) != secure) |
| 250 | pr_info("%s selected on command line.\n", reason); | 288 | pr_info("spectre_v2_user=%s forced on command line.\n", reason); |
| 251 | } | 289 | } |
| 252 | 290 | ||
| 253 | static inline bool retp_compiler(void) | 291 | static enum spectre_v2_user_cmd __init |
| 292 | spectre_v2_parse_user_cmdline(enum spectre_v2_mitigation_cmd v2_cmd) | ||
| 254 | { | 293 | { |
| 255 | return __is_defined(RETPOLINE); | 294 | char arg[20]; |
| 295 | int ret, i; | ||
| 296 | |||
| 297 | switch (v2_cmd) { | ||
| 298 | case SPECTRE_V2_CMD_NONE: | ||
| 299 | return SPECTRE_V2_USER_CMD_NONE; | ||
| 300 | case SPECTRE_V2_CMD_FORCE: | ||
| 301 | return SPECTRE_V2_USER_CMD_FORCE; | ||
| 302 | default: | ||
| 303 | break; | ||
| 304 | } | ||
| 305 | |||
| 306 | ret = cmdline_find_option(boot_command_line, "spectre_v2_user", | ||
| 307 | arg, sizeof(arg)); | ||
| 308 | if (ret < 0) | ||
| 309 | return SPECTRE_V2_USER_CMD_AUTO; | ||
| 310 | |||
| 311 | for (i = 0; i < ARRAY_SIZE(v2_user_options); i++) { | ||
| 312 | if (match_option(arg, ret, v2_user_options[i].option)) { | ||
| 313 | spec_v2_user_print_cond(v2_user_options[i].option, | ||
| 314 | v2_user_options[i].secure); | ||
| 315 | return v2_user_options[i].cmd; | ||
| 316 | } | ||
| 317 | } | ||
| 318 | |||
| 319 | pr_err("Unknown user space protection option (%s). Switching to AUTO select\n", arg); | ||
| 320 | return SPECTRE_V2_USER_CMD_AUTO; | ||
| 256 | } | 321 | } |
| 257 | 322 | ||
| 258 | static inline bool match_option(const char *arg, int arglen, const char *opt) | 323 | static void __init |
| 324 | spectre_v2_user_select_mitigation(enum spectre_v2_mitigation_cmd v2_cmd) | ||
| 259 | { | 325 | { |
| 260 | int len = strlen(opt); | 326 | enum spectre_v2_user_mitigation mode = SPECTRE_V2_USER_NONE; |
| 327 | bool smt_possible = IS_ENABLED(CONFIG_SMP); | ||
| 328 | enum spectre_v2_user_cmd cmd; | ||
| 261 | 329 | ||
| 262 | return len == arglen && !strncmp(arg, opt, len); | 330 | if (!boot_cpu_has(X86_FEATURE_IBPB) && !boot_cpu_has(X86_FEATURE_STIBP)) |
| 331 | return; | ||
| 332 | |||
| 333 | if (cpu_smt_control == CPU_SMT_FORCE_DISABLED || | ||
| 334 | cpu_smt_control == CPU_SMT_NOT_SUPPORTED) | ||
| 335 | smt_possible = false; | ||
| 336 | |||
| 337 | cmd = spectre_v2_parse_user_cmdline(v2_cmd); | ||
| 338 | switch (cmd) { | ||
| 339 | case SPECTRE_V2_USER_CMD_NONE: | ||
| 340 | goto set_mode; | ||
| 341 | case SPECTRE_V2_USER_CMD_FORCE: | ||
| 342 | mode = SPECTRE_V2_USER_STRICT; | ||
| 343 | break; | ||
| 344 | case SPECTRE_V2_USER_CMD_PRCTL: | ||
| 345 | case SPECTRE_V2_USER_CMD_PRCTL_IBPB: | ||
| 346 | mode = SPECTRE_V2_USER_PRCTL; | ||
| 347 | break; | ||
| 348 | case SPECTRE_V2_USER_CMD_AUTO: | ||
| 349 | case SPECTRE_V2_USER_CMD_SECCOMP: | ||
| 350 | case SPECTRE_V2_USER_CMD_SECCOMP_IBPB: | ||
| 351 | if (IS_ENABLED(CONFIG_SECCOMP)) | ||
| 352 | mode = SPECTRE_V2_USER_SECCOMP; | ||
| 353 | else | ||
| 354 | mode = SPECTRE_V2_USER_PRCTL; | ||
| 355 | break; | ||
| 356 | } | ||
| 357 | |||
| 358 | /* Initialize Indirect Branch Prediction Barrier */ | ||
| 359 | if (boot_cpu_has(X86_FEATURE_IBPB)) { | ||
| 360 | setup_force_cpu_cap(X86_FEATURE_USE_IBPB); | ||
| 361 | |||
| 362 | switch (cmd) { | ||
| 363 | case SPECTRE_V2_USER_CMD_FORCE: | ||
| 364 | case SPECTRE_V2_USER_CMD_PRCTL_IBPB: | ||
| 365 | case SPECTRE_V2_USER_CMD_SECCOMP_IBPB: | ||
| 366 | static_branch_enable(&switch_mm_always_ibpb); | ||
| 367 | break; | ||
| 368 | case SPECTRE_V2_USER_CMD_PRCTL: | ||
| 369 | case SPECTRE_V2_USER_CMD_AUTO: | ||
| 370 | case SPECTRE_V2_USER_CMD_SECCOMP: | ||
| 371 | static_branch_enable(&switch_mm_cond_ibpb); | ||
| 372 | break; | ||
| 373 | default: | ||
| 374 | break; | ||
| 375 | } | ||
| 376 | |||
| 377 | pr_info("mitigation: Enabling %s Indirect Branch Prediction Barrier\n", | ||
| 378 | static_key_enabled(&switch_mm_always_ibpb) ? | ||
| 379 | "always-on" : "conditional"); | ||
| 380 | } | ||
| 381 | |||
| 382 | /* If enhanced IBRS is enabled no STIPB required */ | ||
| 383 | if (spectre_v2_enabled == SPECTRE_V2_IBRS_ENHANCED) | ||
| 384 | return; | ||
| 385 | |||
| 386 | /* | ||
| 387 | * If SMT is not possible or STIBP is not available clear the STIPB | ||
| 388 | * mode. | ||
| 389 | */ | ||
| 390 | if (!smt_possible || !boot_cpu_has(X86_FEATURE_STIBP)) | ||
| 391 | mode = SPECTRE_V2_USER_NONE; | ||
| 392 | set_mode: | ||
| 393 | spectre_v2_user = mode; | ||
| 394 | /* Only print the STIBP mode when SMT possible */ | ||
| 395 | if (smt_possible) | ||
| 396 | pr_info("%s\n", spectre_v2_user_strings[mode]); | ||
| 263 | } | 397 | } |
| 264 | 398 | ||
| 399 | static const char * const spectre_v2_strings[] = { | ||
| 400 | [SPECTRE_V2_NONE] = "Vulnerable", | ||
| 401 | [SPECTRE_V2_RETPOLINE_GENERIC] = "Mitigation: Full generic retpoline", | ||
| 402 | [SPECTRE_V2_RETPOLINE_AMD] = "Mitigation: Full AMD retpoline", | ||
| 403 | [SPECTRE_V2_IBRS_ENHANCED] = "Mitigation: Enhanced IBRS", | ||
| 404 | }; | ||
| 405 | |||
| 265 | static const struct { | 406 | static const struct { |
| 266 | const char *option; | 407 | const char *option; |
| 267 | enum spectre_v2_mitigation_cmd cmd; | 408 | enum spectre_v2_mitigation_cmd cmd; |
| 268 | bool secure; | 409 | bool secure; |
| 269 | } mitigation_options[] = { | 410 | } mitigation_options[] __initdata = { |
| 270 | { "off", SPECTRE_V2_CMD_NONE, false }, | 411 | { "off", SPECTRE_V2_CMD_NONE, false }, |
| 271 | { "on", SPECTRE_V2_CMD_FORCE, true }, | 412 | { "on", SPECTRE_V2_CMD_FORCE, true }, |
| 272 | { "retpoline", SPECTRE_V2_CMD_RETPOLINE, false }, | 413 | { "retpoline", SPECTRE_V2_CMD_RETPOLINE, false }, |
| 273 | { "retpoline,amd", SPECTRE_V2_CMD_RETPOLINE_AMD, false }, | 414 | { "retpoline,amd", SPECTRE_V2_CMD_RETPOLINE_AMD, false }, |
| 274 | { "retpoline,generic", SPECTRE_V2_CMD_RETPOLINE_GENERIC, false }, | 415 | { "retpoline,generic", SPECTRE_V2_CMD_RETPOLINE_GENERIC, false }, |
| 275 | { "auto", SPECTRE_V2_CMD_AUTO, false }, | 416 | { "auto", SPECTRE_V2_CMD_AUTO, false }, |
| 276 | }; | 417 | }; |
| 277 | 418 | ||
| 419 | static void __init spec_v2_print_cond(const char *reason, bool secure) | ||
| 420 | { | ||
| 421 | if (boot_cpu_has_bug(X86_BUG_SPECTRE_V2) != secure) | ||
| 422 | pr_info("%s selected on command line.\n", reason); | ||
| 423 | } | ||
| 424 | |||
| 278 | static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline(void) | 425 | static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline(void) |
| 279 | { | 426 | { |
| 427 | enum spectre_v2_mitigation_cmd cmd = SPECTRE_V2_CMD_AUTO; | ||
| 280 | char arg[20]; | 428 | char arg[20]; |
| 281 | int ret, i; | 429 | int ret, i; |
| 282 | enum spectre_v2_mitigation_cmd cmd = SPECTRE_V2_CMD_AUTO; | ||
| 283 | 430 | ||
| 284 | if (cmdline_find_option_bool(boot_command_line, "nospectre_v2")) | 431 | if (cmdline_find_option_bool(boot_command_line, "nospectre_v2")) |
| 285 | return SPECTRE_V2_CMD_NONE; | 432 | return SPECTRE_V2_CMD_NONE; |
| 286 | else { | ||
| 287 | ret = cmdline_find_option(boot_command_line, "spectre_v2", arg, sizeof(arg)); | ||
| 288 | if (ret < 0) | ||
| 289 | return SPECTRE_V2_CMD_AUTO; | ||
| 290 | 433 | ||
| 291 | for (i = 0; i < ARRAY_SIZE(mitigation_options); i++) { | 434 | ret = cmdline_find_option(boot_command_line, "spectre_v2", arg, sizeof(arg)); |
| 292 | if (!match_option(arg, ret, mitigation_options[i].option)) | 435 | if (ret < 0) |
| 293 | continue; | 436 | return SPECTRE_V2_CMD_AUTO; |
| 294 | cmd = mitigation_options[i].cmd; | ||
| 295 | break; | ||
| 296 | } | ||
| 297 | 437 | ||
| 298 | if (i >= ARRAY_SIZE(mitigation_options)) { | 438 | for (i = 0; i < ARRAY_SIZE(mitigation_options); i++) { |
| 299 | pr_err("unknown option (%s). Switching to AUTO select\n", arg); | 439 | if (!match_option(arg, ret, mitigation_options[i].option)) |
| 300 | return SPECTRE_V2_CMD_AUTO; | 440 | continue; |
| 301 | } | 441 | cmd = mitigation_options[i].cmd; |
| 442 | break; | ||
| 443 | } | ||
| 444 | |||
| 445 | if (i >= ARRAY_SIZE(mitigation_options)) { | ||
| 446 | pr_err("unknown option (%s). Switching to AUTO select\n", arg); | ||
| 447 | return SPECTRE_V2_CMD_AUTO; | ||
| 302 | } | 448 | } |
| 303 | 449 | ||
| 304 | if ((cmd == SPECTRE_V2_CMD_RETPOLINE || | 450 | if ((cmd == SPECTRE_V2_CMD_RETPOLINE || |
| @@ -316,54 +462,11 @@ static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline(void) | |||
| 316 | return SPECTRE_V2_CMD_AUTO; | 462 | return SPECTRE_V2_CMD_AUTO; |
| 317 | } | 463 | } |
| 318 | 464 | ||
| 319 | if (mitigation_options[i].secure) | 465 | spec_v2_print_cond(mitigation_options[i].option, |
| 320 | spec2_print_if_secure(mitigation_options[i].option); | 466 | mitigation_options[i].secure); |
| 321 | else | ||
| 322 | spec2_print_if_insecure(mitigation_options[i].option); | ||
| 323 | |||
| 324 | return cmd; | 467 | return cmd; |
| 325 | } | 468 | } |
| 326 | 469 | ||
| 327 | static bool stibp_needed(void) | ||
| 328 | { | ||
| 329 | if (spectre_v2_enabled == SPECTRE_V2_NONE) | ||
| 330 | return false; | ||
| 331 | |||
| 332 | if (!boot_cpu_has(X86_FEATURE_STIBP)) | ||
| 333 | return false; | ||
| 334 | |||
| 335 | return true; | ||
| 336 | } | ||
| 337 | |||
| 338 | static void update_stibp_msr(void *info) | ||
| 339 | { | ||
| 340 | wrmsrl(MSR_IA32_SPEC_CTRL, x86_spec_ctrl_base); | ||
| 341 | } | ||
| 342 | |||
| 343 | void arch_smt_update(void) | ||
| 344 | { | ||
| 345 | u64 mask; | ||
| 346 | |||
| 347 | if (!stibp_needed()) | ||
| 348 | return; | ||
| 349 | |||
| 350 | mutex_lock(&spec_ctrl_mutex); | ||
| 351 | mask = x86_spec_ctrl_base; | ||
| 352 | if (cpu_smt_control == CPU_SMT_ENABLED) | ||
| 353 | mask |= SPEC_CTRL_STIBP; | ||
| 354 | else | ||
| 355 | mask &= ~SPEC_CTRL_STIBP; | ||
| 356 | |||
| 357 | if (mask != x86_spec_ctrl_base) { | ||
| 358 | pr_info("Spectre v2 cross-process SMT mitigation: %s STIBP\n", | ||
| 359 | cpu_smt_control == CPU_SMT_ENABLED ? | ||
| 360 | "Enabling" : "Disabling"); | ||
| 361 | x86_spec_ctrl_base = mask; | ||
| 362 | on_each_cpu(update_stibp_msr, NULL, 1); | ||
| 363 | } | ||
| 364 | mutex_unlock(&spec_ctrl_mutex); | ||
| 365 | } | ||
| 366 | |||
| 367 | static void __init spectre_v2_select_mitigation(void) | 470 | static void __init spectre_v2_select_mitigation(void) |
| 368 | { | 471 | { |
| 369 | enum spectre_v2_mitigation_cmd cmd = spectre_v2_parse_cmdline(); | 472 | enum spectre_v2_mitigation_cmd cmd = spectre_v2_parse_cmdline(); |
| @@ -417,14 +520,12 @@ retpoline_auto: | |||
| 417 | pr_err("Spectre mitigation: LFENCE not serializing, switching to generic retpoline\n"); | 520 | pr_err("Spectre mitigation: LFENCE not serializing, switching to generic retpoline\n"); |
| 418 | goto retpoline_generic; | 521 | goto retpoline_generic; |
| 419 | } | 522 | } |
| 420 | mode = retp_compiler() ? SPECTRE_V2_RETPOLINE_AMD : | 523 | mode = SPECTRE_V2_RETPOLINE_AMD; |
| 421 | SPECTRE_V2_RETPOLINE_MINIMAL_AMD; | ||
| 422 | setup_force_cpu_cap(X86_FEATURE_RETPOLINE_AMD); | 524 | setup_force_cpu_cap(X86_FEATURE_RETPOLINE_AMD); |
| 423 | setup_force_cpu_cap(X86_FEATURE_RETPOLINE); | 525 | setup_force_cpu_cap(X86_FEATURE_RETPOLINE); |
| 424 | } else { | 526 | } else { |
| 425 | retpoline_generic: | 527 | retpoline_generic: |
| 426 | mode = retp_compiler() ? SPECTRE_V2_RETPOLINE_GENERIC : | 528 | mode = SPECTRE_V2_RETPOLINE_GENERIC; |
| 427 | SPECTRE_V2_RETPOLINE_MINIMAL; | ||
| 428 | setup_force_cpu_cap(X86_FEATURE_RETPOLINE); | 529 | setup_force_cpu_cap(X86_FEATURE_RETPOLINE); |
| 429 | } | 530 | } |
| 430 | 531 | ||
| @@ -443,12 +544,6 @@ specv2_set_mode: | |||
| 443 | setup_force_cpu_cap(X86_FEATURE_RSB_CTXSW); | 544 | setup_force_cpu_cap(X86_FEATURE_RSB_CTXSW); |
| 444 | pr_info("Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch\n"); | 545 | pr_info("Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch\n"); |
| 445 | 546 | ||
| 446 | /* Initialize Indirect Branch Prediction Barrier if supported */ | ||
| 447 | if (boot_cpu_has(X86_FEATURE_IBPB)) { | ||
| 448 | setup_force_cpu_cap(X86_FEATURE_USE_IBPB); | ||
| 449 | pr_info("Spectre v2 mitigation: Enabling Indirect Branch Prediction Barrier\n"); | ||
| 450 | } | ||
| 451 | |||
| 452 | /* | 547 | /* |
| 453 | * Retpoline means the kernel is safe because it has no indirect | 548 | * Retpoline means the kernel is safe because it has no indirect |
| 454 | * branches. Enhanced IBRS protects firmware too, so, enable restricted | 549 | * branches. Enhanced IBRS protects firmware too, so, enable restricted |
| @@ -465,10 +560,67 @@ specv2_set_mode: | |||
| 465 | pr_info("Enabling Restricted Speculation for firmware calls\n"); | 560 | pr_info("Enabling Restricted Speculation for firmware calls\n"); |
| 466 | } | 561 | } |
| 467 | 562 | ||
| 563 | /* Set up IBPB and STIBP depending on the general spectre V2 command */ | ||
| 564 | spectre_v2_user_select_mitigation(cmd); | ||
| 565 | |||
| 468 | /* Enable STIBP if appropriate */ | 566 | /* Enable STIBP if appropriate */ |
| 469 | arch_smt_update(); | 567 | arch_smt_update(); |
| 470 | } | 568 | } |
| 471 | 569 | ||
| 570 | static void update_stibp_msr(void * __unused) | ||
| 571 | { | ||
| 572 | wrmsrl(MSR_IA32_SPEC_CTRL, x86_spec_ctrl_base); | ||
| 573 | } | ||
| 574 | |||
| 575 | /* Update x86_spec_ctrl_base in case SMT state changed. */ | ||
| 576 | static void update_stibp_strict(void) | ||
| 577 | { | ||
| 578 | u64 mask = x86_spec_ctrl_base & ~SPEC_CTRL_STIBP; | ||
| 579 | |||
| 580 | if (sched_smt_active()) | ||
| 581 | mask |= SPEC_CTRL_STIBP; | ||
| 582 | |||
| 583 | if (mask == x86_spec_ctrl_base) | ||
| 584 | return; | ||
| 585 | |||
| 586 | pr_info("Update user space SMT mitigation: STIBP %s\n", | ||
| 587 | mask & SPEC_CTRL_STIBP ? "always-on" : "off"); | ||
| 588 | x86_spec_ctrl_base = mask; | ||
| 589 | on_each_cpu(update_stibp_msr, NULL, 1); | ||
| 590 | } | ||
| 591 | |||
| 592 | /* Update the static key controlling the evaluation of TIF_SPEC_IB */ | ||
| 593 | static void update_indir_branch_cond(void) | ||
| 594 | { | ||
| 595 | if (sched_smt_active()) | ||
| 596 | static_branch_enable(&switch_to_cond_stibp); | ||
| 597 | else | ||
| 598 | static_branch_disable(&switch_to_cond_stibp); | ||
| 599 | } | ||
| 600 | |||
| 601 | void arch_smt_update(void) | ||
| 602 | { | ||
| 603 | /* Enhanced IBRS implies STIBP. No update required. */ | ||
| 604 | if (spectre_v2_enabled == SPECTRE_V2_IBRS_ENHANCED) | ||
| 605 | return; | ||
| 606 | |||
| 607 | mutex_lock(&spec_ctrl_mutex); | ||
| 608 | |||
| 609 | switch (spectre_v2_user) { | ||
| 610 | case SPECTRE_V2_USER_NONE: | ||
| 611 | break; | ||
| 612 | case SPECTRE_V2_USER_STRICT: | ||
| 613 | update_stibp_strict(); | ||
| 614 | break; | ||
| 615 | case SPECTRE_V2_USER_PRCTL: | ||
| 616 | case SPECTRE_V2_USER_SECCOMP: | ||
| 617 | update_indir_branch_cond(); | ||
| 618 | break; | ||
| 619 | } | ||
| 620 | |||
| 621 | mutex_unlock(&spec_ctrl_mutex); | ||
| 622 | } | ||
| 623 | |||
| 472 | #undef pr_fmt | 624 | #undef pr_fmt |
| 473 | #define pr_fmt(fmt) "Speculative Store Bypass: " fmt | 625 | #define pr_fmt(fmt) "Speculative Store Bypass: " fmt |
| 474 | 626 | ||
| @@ -483,7 +635,7 @@ enum ssb_mitigation_cmd { | |||
| 483 | SPEC_STORE_BYPASS_CMD_SECCOMP, | 635 | SPEC_STORE_BYPASS_CMD_SECCOMP, |
| 484 | }; | 636 | }; |
| 485 | 637 | ||
| 486 | static const char *ssb_strings[] = { | 638 | static const char * const ssb_strings[] = { |
| 487 | [SPEC_STORE_BYPASS_NONE] = "Vulnerable", | 639 | [SPEC_STORE_BYPASS_NONE] = "Vulnerable", |
| 488 | [SPEC_STORE_BYPASS_DISABLE] = "Mitigation: Speculative Store Bypass disabled", | 640 | [SPEC_STORE_BYPASS_DISABLE] = "Mitigation: Speculative Store Bypass disabled", |
| 489 | [SPEC_STORE_BYPASS_PRCTL] = "Mitigation: Speculative Store Bypass disabled via prctl", | 641 | [SPEC_STORE_BYPASS_PRCTL] = "Mitigation: Speculative Store Bypass disabled via prctl", |
| @@ -493,7 +645,7 @@ static const char *ssb_strings[] = { | |||
| 493 | static const struct { | 645 | static const struct { |
| 494 | const char *option; | 646 | const char *option; |
| 495 | enum ssb_mitigation_cmd cmd; | 647 | enum ssb_mitigation_cmd cmd; |
| 496 | } ssb_mitigation_options[] = { | 648 | } ssb_mitigation_options[] __initdata = { |
| 497 | { "auto", SPEC_STORE_BYPASS_CMD_AUTO }, /* Platform decides */ | 649 | { "auto", SPEC_STORE_BYPASS_CMD_AUTO }, /* Platform decides */ |
| 498 | { "on", SPEC_STORE_BYPASS_CMD_ON }, /* Disable Speculative Store Bypass */ | 650 | { "on", SPEC_STORE_BYPASS_CMD_ON }, /* Disable Speculative Store Bypass */ |
| 499 | { "off", SPEC_STORE_BYPASS_CMD_NONE }, /* Don't touch Speculative Store Bypass */ | 651 | { "off", SPEC_STORE_BYPASS_CMD_NONE }, /* Don't touch Speculative Store Bypass */ |
| @@ -604,10 +756,25 @@ static void ssb_select_mitigation(void) | |||
| 604 | #undef pr_fmt | 756 | #undef pr_fmt |
| 605 | #define pr_fmt(fmt) "Speculation prctl: " fmt | 757 | #define pr_fmt(fmt) "Speculation prctl: " fmt |
| 606 | 758 | ||
| 607 | static int ssb_prctl_set(struct task_struct *task, unsigned long ctrl) | 759 | static void task_update_spec_tif(struct task_struct *tsk) |
| 608 | { | 760 | { |
| 609 | bool update; | 761 | /* Force the update of the real TIF bits */ |
| 762 | set_tsk_thread_flag(tsk, TIF_SPEC_FORCE_UPDATE); | ||
| 610 | 763 | ||
| 764 | /* | ||
| 765 | * Immediately update the speculation control MSRs for the current | ||
| 766 | * task, but for a non-current task delay setting the CPU | ||
| 767 | * mitigation until it is scheduled next. | ||
| 768 | * | ||
| 769 | * This can only happen for SECCOMP mitigation. For PRCTL it's | ||
| 770 | * always the current task. | ||
| 771 | */ | ||
| 772 | if (tsk == current) | ||
| 773 | speculation_ctrl_update_current(); | ||
| 774 | } | ||
| 775 | |||
| 776 | static int ssb_prctl_set(struct task_struct *task, unsigned long ctrl) | ||
| 777 | { | ||
| 611 | if (ssb_mode != SPEC_STORE_BYPASS_PRCTL && | 778 | if (ssb_mode != SPEC_STORE_BYPASS_PRCTL && |
| 612 | ssb_mode != SPEC_STORE_BYPASS_SECCOMP) | 779 | ssb_mode != SPEC_STORE_BYPASS_SECCOMP) |
| 613 | return -ENXIO; | 780 | return -ENXIO; |
| @@ -618,28 +785,56 @@ static int ssb_prctl_set(struct task_struct *task, unsigned long ctrl) | |||
| 618 | if (task_spec_ssb_force_disable(task)) | 785 | if (task_spec_ssb_force_disable(task)) |
| 619 | return -EPERM; | 786 | return -EPERM; |
| 620 | task_clear_spec_ssb_disable(task); | 787 | task_clear_spec_ssb_disable(task); |
| 621 | update = test_and_clear_tsk_thread_flag(task, TIF_SSBD); | 788 | task_update_spec_tif(task); |
| 622 | break; | 789 | break; |
| 623 | case PR_SPEC_DISABLE: | 790 | case PR_SPEC_DISABLE: |
| 624 | task_set_spec_ssb_disable(task); | 791 | task_set_spec_ssb_disable(task); |
| 625 | update = !test_and_set_tsk_thread_flag(task, TIF_SSBD); | 792 | task_update_spec_tif(task); |
| 626 | break; | 793 | break; |
| 627 | case PR_SPEC_FORCE_DISABLE: | 794 | case PR_SPEC_FORCE_DISABLE: |
| 628 | task_set_spec_ssb_disable(task); | 795 | task_set_spec_ssb_disable(task); |
| 629 | task_set_spec_ssb_force_disable(task); | 796 | task_set_spec_ssb_force_disable(task); |
| 630 | update = !test_and_set_tsk_thread_flag(task, TIF_SSBD); | 797 | task_update_spec_tif(task); |
| 631 | break; | 798 | break; |
| 632 | default: | 799 | default: |
| 633 | return -ERANGE; | 800 | return -ERANGE; |
| 634 | } | 801 | } |
| 802 | return 0; | ||
| 803 | } | ||
| 635 | 804 | ||
| 636 | /* | 805 | static int ib_prctl_set(struct task_struct *task, unsigned long ctrl) |
| 637 | * If being set on non-current task, delay setting the CPU | 806 | { |
| 638 | * mitigation until it is next scheduled. | 807 | switch (ctrl) { |
| 639 | */ | 808 | case PR_SPEC_ENABLE: |
| 640 | if (task == current && update) | 809 | if (spectre_v2_user == SPECTRE_V2_USER_NONE) |
| 641 | speculative_store_bypass_update_current(); | 810 | return 0; |
| 642 | 811 | /* | |
| 812 | * Indirect branch speculation is always disabled in strict | ||
| 813 | * mode. | ||
| 814 | */ | ||
| 815 | if (spectre_v2_user == SPECTRE_V2_USER_STRICT) | ||
| 816 | return -EPERM; | ||
| 817 | task_clear_spec_ib_disable(task); | ||
| 818 | task_update_spec_tif(task); | ||
| 819 | break; | ||
| 820 | case PR_SPEC_DISABLE: | ||
| 821 | case PR_SPEC_FORCE_DISABLE: | ||
| 822 | /* | ||
| 823 | * Indirect branch speculation is always allowed when | ||
| 824 | * mitigation is force disabled. | ||
| 825 | */ | ||
| 826 | if (spectre_v2_user == SPECTRE_V2_USER_NONE) | ||
| 827 | return -EPERM; | ||
| 828 | if (spectre_v2_user == SPECTRE_V2_USER_STRICT) | ||
| 829 | return 0; | ||
| 830 | task_set_spec_ib_disable(task); | ||
| 831 | if (ctrl == PR_SPEC_FORCE_DISABLE) | ||
| 832 | task_set_spec_ib_force_disable(task); | ||
| 833 | task_update_spec_tif(task); | ||
| 834 | break; | ||
| 835 | default: | ||
| 836 | return -ERANGE; | ||
| 837 | } | ||
| 643 | return 0; | 838 | return 0; |
| 644 | } | 839 | } |
| 645 | 840 | ||
| @@ -649,6 +844,8 @@ int arch_prctl_spec_ctrl_set(struct task_struct *task, unsigned long which, | |||
| 649 | switch (which) { | 844 | switch (which) { |
| 650 | case PR_SPEC_STORE_BYPASS: | 845 | case PR_SPEC_STORE_BYPASS: |
| 651 | return ssb_prctl_set(task, ctrl); | 846 | return ssb_prctl_set(task, ctrl); |
| 847 | case PR_SPEC_INDIRECT_BRANCH: | ||
| 848 | return ib_prctl_set(task, ctrl); | ||
| 652 | default: | 849 | default: |
| 653 | return -ENODEV; | 850 | return -ENODEV; |
| 654 | } | 851 | } |
| @@ -659,6 +856,8 @@ void arch_seccomp_spec_mitigate(struct task_struct *task) | |||
| 659 | { | 856 | { |
| 660 | if (ssb_mode == SPEC_STORE_BYPASS_SECCOMP) | 857 | if (ssb_mode == SPEC_STORE_BYPASS_SECCOMP) |
| 661 | ssb_prctl_set(task, PR_SPEC_FORCE_DISABLE); | 858 | ssb_prctl_set(task, PR_SPEC_FORCE_DISABLE); |
| 859 | if (spectre_v2_user == SPECTRE_V2_USER_SECCOMP) | ||
| 860 | ib_prctl_set(task, PR_SPEC_FORCE_DISABLE); | ||
| 662 | } | 861 | } |
| 663 | #endif | 862 | #endif |
| 664 | 863 | ||
| @@ -681,11 +880,35 @@ static int ssb_prctl_get(struct task_struct *task) | |||
| 681 | } | 880 | } |
| 682 | } | 881 | } |
| 683 | 882 | ||
| 883 | static int ib_prctl_get(struct task_struct *task) | ||
| 884 | { | ||
| 885 | if (!boot_cpu_has_bug(X86_BUG_SPECTRE_V2)) | ||
| 886 | return PR_SPEC_NOT_AFFECTED; | ||
| 887 | |||
| 888 | switch (spectre_v2_user) { | ||
| 889 | case SPECTRE_V2_USER_NONE: | ||
| 890 | return PR_SPEC_ENABLE; | ||
| 891 | case SPECTRE_V2_USER_PRCTL: | ||
| 892 | case SPECTRE_V2_USER_SECCOMP: | ||
| 893 | if (task_spec_ib_force_disable(task)) | ||
| 894 | return PR_SPEC_PRCTL | PR_SPEC_FORCE_DISABLE; | ||
| 895 | if (task_spec_ib_disable(task)) | ||
| 896 | return PR_SPEC_PRCTL | PR_SPEC_DISABLE; | ||
| 897 | return PR_SPEC_PRCTL | PR_SPEC_ENABLE; | ||
| 898 | case SPECTRE_V2_USER_STRICT: | ||
| 899 | return PR_SPEC_DISABLE; | ||
| 900 | default: | ||
| 901 | return PR_SPEC_NOT_AFFECTED; | ||
| 902 | } | ||
| 903 | } | ||
| 904 | |||
| 684 | int arch_prctl_spec_ctrl_get(struct task_struct *task, unsigned long which) | 905 | int arch_prctl_spec_ctrl_get(struct task_struct *task, unsigned long which) |
| 685 | { | 906 | { |
| 686 | switch (which) { | 907 | switch (which) { |
| 687 | case PR_SPEC_STORE_BYPASS: | 908 | case PR_SPEC_STORE_BYPASS: |
| 688 | return ssb_prctl_get(task); | 909 | return ssb_prctl_get(task); |
| 910 | case PR_SPEC_INDIRECT_BRANCH: | ||
| 911 | return ib_prctl_get(task); | ||
| 689 | default: | 912 | default: |
| 690 | return -ENODEV; | 913 | return -ENODEV; |
| 691 | } | 914 | } |
| @@ -823,7 +1046,7 @@ early_param("l1tf", l1tf_cmdline); | |||
| 823 | #define L1TF_DEFAULT_MSG "Mitigation: PTE Inversion" | 1046 | #define L1TF_DEFAULT_MSG "Mitigation: PTE Inversion" |
| 824 | 1047 | ||
| 825 | #if IS_ENABLED(CONFIG_KVM_INTEL) | 1048 | #if IS_ENABLED(CONFIG_KVM_INTEL) |
| 826 | static const char *l1tf_vmx_states[] = { | 1049 | static const char * const l1tf_vmx_states[] = { |
| 827 | [VMENTER_L1D_FLUSH_AUTO] = "auto", | 1050 | [VMENTER_L1D_FLUSH_AUTO] = "auto", |
| 828 | [VMENTER_L1D_FLUSH_NEVER] = "vulnerable", | 1051 | [VMENTER_L1D_FLUSH_NEVER] = "vulnerable", |
| 829 | [VMENTER_L1D_FLUSH_COND] = "conditional cache flushes", | 1052 | [VMENTER_L1D_FLUSH_COND] = "conditional cache flushes", |
| @@ -839,13 +1062,14 @@ static ssize_t l1tf_show_state(char *buf) | |||
| 839 | 1062 | ||
| 840 | if (l1tf_vmx_mitigation == VMENTER_L1D_FLUSH_EPT_DISABLED || | 1063 | if (l1tf_vmx_mitigation == VMENTER_L1D_FLUSH_EPT_DISABLED || |
| 841 | (l1tf_vmx_mitigation == VMENTER_L1D_FLUSH_NEVER && | 1064 | (l1tf_vmx_mitigation == VMENTER_L1D_FLUSH_NEVER && |
| 842 | cpu_smt_control == CPU_SMT_ENABLED)) | 1065 | sched_smt_active())) { |
| 843 | return sprintf(buf, "%s; VMX: %s\n", L1TF_DEFAULT_MSG, | 1066 | return sprintf(buf, "%s; VMX: %s\n", L1TF_DEFAULT_MSG, |
| 844 | l1tf_vmx_states[l1tf_vmx_mitigation]); | 1067 | l1tf_vmx_states[l1tf_vmx_mitigation]); |
| 1068 | } | ||
| 845 | 1069 | ||
| 846 | return sprintf(buf, "%s; VMX: %s, SMT %s\n", L1TF_DEFAULT_MSG, | 1070 | return sprintf(buf, "%s; VMX: %s, SMT %s\n", L1TF_DEFAULT_MSG, |
| 847 | l1tf_vmx_states[l1tf_vmx_mitigation], | 1071 | l1tf_vmx_states[l1tf_vmx_mitigation], |
| 848 | cpu_smt_control == CPU_SMT_ENABLED ? "vulnerable" : "disabled"); | 1072 | sched_smt_active() ? "vulnerable" : "disabled"); |
| 849 | } | 1073 | } |
| 850 | #else | 1074 | #else |
| 851 | static ssize_t l1tf_show_state(char *buf) | 1075 | static ssize_t l1tf_show_state(char *buf) |
| @@ -854,11 +1078,39 @@ static ssize_t l1tf_show_state(char *buf) | |||
| 854 | } | 1078 | } |
| 855 | #endif | 1079 | #endif |
| 856 | 1080 | ||
| 1081 | static char *stibp_state(void) | ||
| 1082 | { | ||
| 1083 | if (spectre_v2_enabled == SPECTRE_V2_IBRS_ENHANCED) | ||
| 1084 | return ""; | ||
| 1085 | |||
| 1086 | switch (spectre_v2_user) { | ||
| 1087 | case SPECTRE_V2_USER_NONE: | ||
| 1088 | return ", STIBP: disabled"; | ||
| 1089 | case SPECTRE_V2_USER_STRICT: | ||
| 1090 | return ", STIBP: forced"; | ||
| 1091 | case SPECTRE_V2_USER_PRCTL: | ||
| 1092 | case SPECTRE_V2_USER_SECCOMP: | ||
| 1093 | if (static_key_enabled(&switch_to_cond_stibp)) | ||
| 1094 | return ", STIBP: conditional"; | ||
| 1095 | } | ||
| 1096 | return ""; | ||
| 1097 | } | ||
| 1098 | |||
| 1099 | static char *ibpb_state(void) | ||
| 1100 | { | ||
| 1101 | if (boot_cpu_has(X86_FEATURE_IBPB)) { | ||
| 1102 | if (static_key_enabled(&switch_mm_always_ibpb)) | ||
| 1103 | return ", IBPB: always-on"; | ||
| 1104 | if (static_key_enabled(&switch_mm_cond_ibpb)) | ||
| 1105 | return ", IBPB: conditional"; | ||
| 1106 | return ", IBPB: disabled"; | ||
| 1107 | } | ||
| 1108 | return ""; | ||
| 1109 | } | ||
| 1110 | |||
| 857 | static ssize_t cpu_show_common(struct device *dev, struct device_attribute *attr, | 1111 | static ssize_t cpu_show_common(struct device *dev, struct device_attribute *attr, |
| 858 | char *buf, unsigned int bug) | 1112 | char *buf, unsigned int bug) |
| 859 | { | 1113 | { |
| 860 | int ret; | ||
| 861 | |||
| 862 | if (!boot_cpu_has_bug(bug)) | 1114 | if (!boot_cpu_has_bug(bug)) |
| 863 | return sprintf(buf, "Not affected\n"); | 1115 | return sprintf(buf, "Not affected\n"); |
| 864 | 1116 | ||
| @@ -876,13 +1128,12 @@ static ssize_t cpu_show_common(struct device *dev, struct device_attribute *attr | |||
| 876 | return sprintf(buf, "Mitigation: __user pointer sanitization\n"); | 1128 | return sprintf(buf, "Mitigation: __user pointer sanitization\n"); |
| 877 | 1129 | ||
| 878 | case X86_BUG_SPECTRE_V2: | 1130 | case X86_BUG_SPECTRE_V2: |
| 879 | ret = sprintf(buf, "%s%s%s%s%s%s\n", spectre_v2_strings[spectre_v2_enabled], | 1131 | return sprintf(buf, "%s%s%s%s%s%s\n", spectre_v2_strings[spectre_v2_enabled], |
| 880 | boot_cpu_has(X86_FEATURE_USE_IBPB) ? ", IBPB" : "", | 1132 | ibpb_state(), |
| 881 | boot_cpu_has(X86_FEATURE_USE_IBRS_FW) ? ", IBRS_FW" : "", | 1133 | boot_cpu_has(X86_FEATURE_USE_IBRS_FW) ? ", IBRS_FW" : "", |
| 882 | (x86_spec_ctrl_base & SPEC_CTRL_STIBP) ? ", STIBP" : "", | 1134 | stibp_state(), |
| 883 | boot_cpu_has(X86_FEATURE_RSB_CTXSW) ? ", RSB filling" : "", | 1135 | boot_cpu_has(X86_FEATURE_RSB_CTXSW) ? ", RSB filling" : "", |
| 884 | spectre_v2_module_string()); | 1136 | spectre_v2_module_string()); |
| 885 | return ret; | ||
| 886 | 1137 | ||
| 887 | case X86_BUG_SPEC_STORE_BYPASS: | 1138 | case X86_BUG_SPEC_STORE_BYPASS: |
| 888 | return sprintf(buf, "%s\n", ssb_strings[ssb_mode]); | 1139 | return sprintf(buf, "%s\n", ssb_strings[ssb_mode]); |
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index c93fcfdf1673..7d31192296a8 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c | |||
| @@ -40,6 +40,8 @@ | |||
| 40 | #include <asm/prctl.h> | 40 | #include <asm/prctl.h> |
| 41 | #include <asm/spec-ctrl.h> | 41 | #include <asm/spec-ctrl.h> |
| 42 | 42 | ||
| 43 | #include "process.h" | ||
| 44 | |||
| 43 | /* | 45 | /* |
| 44 | * per-CPU TSS segments. Threads are completely 'soft' on Linux, | 46 | * per-CPU TSS segments. Threads are completely 'soft' on Linux, |
| 45 | * no more per-task TSS's. The TSS size is kept cacheline-aligned | 47 | * no more per-task TSS's. The TSS size is kept cacheline-aligned |
| @@ -252,11 +254,12 @@ void arch_setup_new_exec(void) | |||
| 252 | enable_cpuid(); | 254 | enable_cpuid(); |
| 253 | } | 255 | } |
| 254 | 256 | ||
| 255 | static inline void switch_to_bitmap(struct tss_struct *tss, | 257 | static inline void switch_to_bitmap(struct thread_struct *prev, |
| 256 | struct thread_struct *prev, | ||
| 257 | struct thread_struct *next, | 258 | struct thread_struct *next, |
| 258 | unsigned long tifp, unsigned long tifn) | 259 | unsigned long tifp, unsigned long tifn) |
| 259 | { | 260 | { |
| 261 | struct tss_struct *tss = this_cpu_ptr(&cpu_tss_rw); | ||
| 262 | |||
| 260 | if (tifn & _TIF_IO_BITMAP) { | 263 | if (tifn & _TIF_IO_BITMAP) { |
| 261 | /* | 264 | /* |
| 262 | * Copy the relevant range of the IO bitmap. | 265 | * Copy the relevant range of the IO bitmap. |
| @@ -395,32 +398,85 @@ static __always_inline void amd_set_ssb_virt_state(unsigned long tifn) | |||
| 395 | wrmsrl(MSR_AMD64_VIRT_SPEC_CTRL, ssbd_tif_to_spec_ctrl(tifn)); | 398 | wrmsrl(MSR_AMD64_VIRT_SPEC_CTRL, ssbd_tif_to_spec_ctrl(tifn)); |
| 396 | } | 399 | } |
| 397 | 400 | ||
| 398 | static __always_inline void intel_set_ssb_state(unsigned long tifn) | 401 | /* |
| 402 | * Update the MSRs managing speculation control, during context switch. | ||
| 403 | * | ||
| 404 | * tifp: Previous task's thread flags | ||
| 405 | * tifn: Next task's thread flags | ||
| 406 | */ | ||
| 407 | static __always_inline void __speculation_ctrl_update(unsigned long tifp, | ||
| 408 | unsigned long tifn) | ||
| 399 | { | 409 | { |
| 400 | u64 msr = x86_spec_ctrl_base | ssbd_tif_to_spec_ctrl(tifn); | 410 | unsigned long tif_diff = tifp ^ tifn; |
| 411 | u64 msr = x86_spec_ctrl_base; | ||
| 412 | bool updmsr = false; | ||
| 413 | |||
| 414 | /* | ||
| 415 | * If TIF_SSBD is different, select the proper mitigation | ||
| 416 | * method. Note that if SSBD mitigation is disabled or permanentely | ||
| 417 | * enabled this branch can't be taken because nothing can set | ||
| 418 | * TIF_SSBD. | ||
| 419 | */ | ||
| 420 | if (tif_diff & _TIF_SSBD) { | ||
| 421 | if (static_cpu_has(X86_FEATURE_VIRT_SSBD)) { | ||
| 422 | amd_set_ssb_virt_state(tifn); | ||
| 423 | } else if (static_cpu_has(X86_FEATURE_LS_CFG_SSBD)) { | ||
| 424 | amd_set_core_ssb_state(tifn); | ||
| 425 | } else if (static_cpu_has(X86_FEATURE_SPEC_CTRL_SSBD) || | ||
| 426 | static_cpu_has(X86_FEATURE_AMD_SSBD)) { | ||
| 427 | msr |= ssbd_tif_to_spec_ctrl(tifn); | ||
| 428 | updmsr = true; | ||
| 429 | } | ||
| 430 | } | ||
| 431 | |||
| 432 | /* | ||
| 433 | * Only evaluate TIF_SPEC_IB if conditional STIBP is enabled, | ||
| 434 | * otherwise avoid the MSR write. | ||
| 435 | */ | ||
| 436 | if (IS_ENABLED(CONFIG_SMP) && | ||
| 437 | static_branch_unlikely(&switch_to_cond_stibp)) { | ||
| 438 | updmsr |= !!(tif_diff & _TIF_SPEC_IB); | ||
| 439 | msr |= stibp_tif_to_spec_ctrl(tifn); | ||
| 440 | } | ||
| 401 | 441 | ||
| 402 | wrmsrl(MSR_IA32_SPEC_CTRL, msr); | 442 | if (updmsr) |
| 443 | wrmsrl(MSR_IA32_SPEC_CTRL, msr); | ||
| 403 | } | 444 | } |
| 404 | 445 | ||
| 405 | static __always_inline void __speculative_store_bypass_update(unsigned long tifn) | 446 | static unsigned long speculation_ctrl_update_tif(struct task_struct *tsk) |
| 406 | { | 447 | { |
| 407 | if (static_cpu_has(X86_FEATURE_VIRT_SSBD)) | 448 | if (test_and_clear_tsk_thread_flag(tsk, TIF_SPEC_FORCE_UPDATE)) { |
| 408 | amd_set_ssb_virt_state(tifn); | 449 | if (task_spec_ssb_disable(tsk)) |
| 409 | else if (static_cpu_has(X86_FEATURE_LS_CFG_SSBD)) | 450 | set_tsk_thread_flag(tsk, TIF_SSBD); |
| 410 | amd_set_core_ssb_state(tifn); | 451 | else |
| 411 | else | 452 | clear_tsk_thread_flag(tsk, TIF_SSBD); |
| 412 | intel_set_ssb_state(tifn); | 453 | |
| 454 | if (task_spec_ib_disable(tsk)) | ||
| 455 | set_tsk_thread_flag(tsk, TIF_SPEC_IB); | ||
| 456 | else | ||
| 457 | clear_tsk_thread_flag(tsk, TIF_SPEC_IB); | ||
| 458 | } | ||
| 459 | /* Return the updated threadinfo flags*/ | ||
| 460 | return task_thread_info(tsk)->flags; | ||
| 413 | } | 461 | } |
| 414 | 462 | ||
| 415 | void speculative_store_bypass_update(unsigned long tif) | 463 | void speculation_ctrl_update(unsigned long tif) |
| 416 | { | 464 | { |
| 465 | /* Forced update. Make sure all relevant TIF flags are different */ | ||
| 417 | preempt_disable(); | 466 | preempt_disable(); |
| 418 | __speculative_store_bypass_update(tif); | 467 | __speculation_ctrl_update(~tif, tif); |
| 419 | preempt_enable(); | 468 | preempt_enable(); |
| 420 | } | 469 | } |
| 421 | 470 | ||
| 422 | void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p, | 471 | /* Called from seccomp/prctl update */ |
| 423 | struct tss_struct *tss) | 472 | void speculation_ctrl_update_current(void) |
| 473 | { | ||
| 474 | preempt_disable(); | ||
| 475 | speculation_ctrl_update(speculation_ctrl_update_tif(current)); | ||
| 476 | preempt_enable(); | ||
| 477 | } | ||
| 478 | |||
| 479 | void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p) | ||
| 424 | { | 480 | { |
| 425 | struct thread_struct *prev, *next; | 481 | struct thread_struct *prev, *next; |
| 426 | unsigned long tifp, tifn; | 482 | unsigned long tifp, tifn; |
| @@ -430,7 +486,7 @@ void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p, | |||
| 430 | 486 | ||
| 431 | tifn = READ_ONCE(task_thread_info(next_p)->flags); | 487 | tifn = READ_ONCE(task_thread_info(next_p)->flags); |
| 432 | tifp = READ_ONCE(task_thread_info(prev_p)->flags); | 488 | tifp = READ_ONCE(task_thread_info(prev_p)->flags); |
| 433 | switch_to_bitmap(tss, prev, next, tifp, tifn); | 489 | switch_to_bitmap(prev, next, tifp, tifn); |
| 434 | 490 | ||
| 435 | propagate_user_return_notify(prev_p, next_p); | 491 | propagate_user_return_notify(prev_p, next_p); |
| 436 | 492 | ||
| @@ -451,8 +507,15 @@ void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p, | |||
| 451 | if ((tifp ^ tifn) & _TIF_NOCPUID) | 507 | if ((tifp ^ tifn) & _TIF_NOCPUID) |
| 452 | set_cpuid_faulting(!!(tifn & _TIF_NOCPUID)); | 508 | set_cpuid_faulting(!!(tifn & _TIF_NOCPUID)); |
| 453 | 509 | ||
| 454 | if ((tifp ^ tifn) & _TIF_SSBD) | 510 | if (likely(!((tifp | tifn) & _TIF_SPEC_FORCE_UPDATE))) { |
| 455 | __speculative_store_bypass_update(tifn); | 511 | __speculation_ctrl_update(tifp, tifn); |
| 512 | } else { | ||
| 513 | speculation_ctrl_update_tif(prev_p); | ||
| 514 | tifn = speculation_ctrl_update_tif(next_p); | ||
| 515 | |||
| 516 | /* Enforce MSR update to ensure consistent state */ | ||
| 517 | __speculation_ctrl_update(~tifn, tifn); | ||
| 518 | } | ||
| 456 | } | 519 | } |
| 457 | 520 | ||
| 458 | /* | 521 | /* |
diff --git a/arch/x86/kernel/process.h b/arch/x86/kernel/process.h new file mode 100644 index 000000000000..898e97cf6629 --- /dev/null +++ b/arch/x86/kernel/process.h | |||
| @@ -0,0 +1,39 @@ | |||
| 1 | // SPDX-License-Identifier: GPL-2.0 | ||
| 2 | // | ||
| 3 | // Code shared between 32 and 64 bit | ||
| 4 | |||
| 5 | #include <asm/spec-ctrl.h> | ||
| 6 | |||
| 7 | void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p); | ||
| 8 | |||
| 9 | /* | ||
| 10 | * This needs to be inline to optimize for the common case where no extra | ||
| 11 | * work needs to be done. | ||
| 12 | */ | ||
| 13 | static inline void switch_to_extra(struct task_struct *prev, | ||
| 14 | struct task_struct *next) | ||
| 15 | { | ||
| 16 | unsigned long next_tif = task_thread_info(next)->flags; | ||
| 17 | unsigned long prev_tif = task_thread_info(prev)->flags; | ||
| 18 | |||
| 19 | if (IS_ENABLED(CONFIG_SMP)) { | ||
| 20 | /* | ||
| 21 | * Avoid __switch_to_xtra() invocation when conditional | ||
| 22 | * STIPB is disabled and the only different bit is | ||
| 23 | * TIF_SPEC_IB. For CONFIG_SMP=n TIF_SPEC_IB is not | ||
| 24 | * in the TIF_WORK_CTXSW masks. | ||
| 25 | */ | ||
| 26 | if (!static_branch_likely(&switch_to_cond_stibp)) { | ||
| 27 | prev_tif &= ~_TIF_SPEC_IB; | ||
| 28 | next_tif &= ~_TIF_SPEC_IB; | ||
| 29 | } | ||
| 30 | } | ||
| 31 | |||
| 32 | /* | ||
| 33 | * __switch_to_xtra() handles debug registers, i/o bitmaps, | ||
| 34 | * speculation mitigations etc. | ||
| 35 | */ | ||
| 36 | if (unlikely(next_tif & _TIF_WORK_CTXSW_NEXT || | ||
| 37 | prev_tif & _TIF_WORK_CTXSW_PREV)) | ||
| 38 | __switch_to_xtra(prev, next); | ||
| 39 | } | ||
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c index 5046a3c9dec2..d3e593eb189f 100644 --- a/arch/x86/kernel/process_32.c +++ b/arch/x86/kernel/process_32.c | |||
| @@ -59,6 +59,8 @@ | |||
| 59 | #include <asm/intel_rdt_sched.h> | 59 | #include <asm/intel_rdt_sched.h> |
| 60 | #include <asm/proto.h> | 60 | #include <asm/proto.h> |
| 61 | 61 | ||
| 62 | #include "process.h" | ||
| 63 | |||
| 62 | void __show_regs(struct pt_regs *regs, enum show_regs_mode mode) | 64 | void __show_regs(struct pt_regs *regs, enum show_regs_mode mode) |
| 63 | { | 65 | { |
| 64 | unsigned long cr0 = 0L, cr2 = 0L, cr3 = 0L, cr4 = 0L; | 66 | unsigned long cr0 = 0L, cr2 = 0L, cr3 = 0L, cr4 = 0L; |
| @@ -232,7 +234,6 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) | |||
| 232 | struct fpu *prev_fpu = &prev->fpu; | 234 | struct fpu *prev_fpu = &prev->fpu; |
| 233 | struct fpu *next_fpu = &next->fpu; | 235 | struct fpu *next_fpu = &next->fpu; |
| 234 | int cpu = smp_processor_id(); | 236 | int cpu = smp_processor_id(); |
| 235 | struct tss_struct *tss = &per_cpu(cpu_tss_rw, cpu); | ||
| 236 | 237 | ||
| 237 | /* never put a printk in __switch_to... printk() calls wake_up*() indirectly */ | 238 | /* never put a printk in __switch_to... printk() calls wake_up*() indirectly */ |
| 238 | 239 | ||
| @@ -264,12 +265,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) | |||
| 264 | if (get_kernel_rpl() && unlikely(prev->iopl != next->iopl)) | 265 | if (get_kernel_rpl() && unlikely(prev->iopl != next->iopl)) |
| 265 | set_iopl_mask(next->iopl); | 266 | set_iopl_mask(next->iopl); |
| 266 | 267 | ||
| 267 | /* | 268 | switch_to_extra(prev_p, next_p); |
| 268 | * Now maybe handle debug registers and/or IO bitmaps | ||
| 269 | */ | ||
| 270 | if (unlikely(task_thread_info(prev_p)->flags & _TIF_WORK_CTXSW_PREV || | ||
| 271 | task_thread_info(next_p)->flags & _TIF_WORK_CTXSW_NEXT)) | ||
| 272 | __switch_to_xtra(prev_p, next_p, tss); | ||
| 273 | 269 | ||
| 274 | /* | 270 | /* |
| 275 | * Leave lazy mode, flushing any hypercalls made here. | 271 | * Leave lazy mode, flushing any hypercalls made here. |
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 0e0b4288a4b2..bbfbf017065c 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c | |||
| @@ -60,6 +60,8 @@ | |||
| 60 | #include <asm/unistd_32_ia32.h> | 60 | #include <asm/unistd_32_ia32.h> |
| 61 | #endif | 61 | #endif |
| 62 | 62 | ||
| 63 | #include "process.h" | ||
| 64 | |||
| 63 | /* Prints also some state that isn't saved in the pt_regs */ | 65 | /* Prints also some state that isn't saved in the pt_regs */ |
| 64 | void __show_regs(struct pt_regs *regs, enum show_regs_mode mode) | 66 | void __show_regs(struct pt_regs *regs, enum show_regs_mode mode) |
| 65 | { | 67 | { |
| @@ -553,7 +555,6 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) | |||
| 553 | struct fpu *prev_fpu = &prev->fpu; | 555 | struct fpu *prev_fpu = &prev->fpu; |
| 554 | struct fpu *next_fpu = &next->fpu; | 556 | struct fpu *next_fpu = &next->fpu; |
| 555 | int cpu = smp_processor_id(); | 557 | int cpu = smp_processor_id(); |
| 556 | struct tss_struct *tss = &per_cpu(cpu_tss_rw, cpu); | ||
| 557 | 558 | ||
| 558 | WARN_ON_ONCE(IS_ENABLED(CONFIG_DEBUG_ENTRY) && | 559 | WARN_ON_ONCE(IS_ENABLED(CONFIG_DEBUG_ENTRY) && |
| 559 | this_cpu_read(irq_count) != -1); | 560 | this_cpu_read(irq_count) != -1); |
| @@ -617,12 +618,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) | |||
| 617 | /* Reload sp0. */ | 618 | /* Reload sp0. */ |
| 618 | update_task_stack(next_p); | 619 | update_task_stack(next_p); |
| 619 | 620 | ||
| 620 | /* | 621 | switch_to_extra(prev_p, next_p); |
| 621 | * Now maybe reload the debug registers and handle I/O bitmaps | ||
| 622 | */ | ||
| 623 | if (unlikely(task_thread_info(next_p)->flags & _TIF_WORK_CTXSW_NEXT || | ||
| 624 | task_thread_info(prev_p)->flags & _TIF_WORK_CTXSW_PREV)) | ||
| 625 | __switch_to_xtra(prev_p, next_p, tss); | ||
| 626 | 622 | ||
| 627 | #ifdef CONFIG_XEN_PV | 623 | #ifdef CONFIG_XEN_PV |
| 628 | /* | 624 | /* |
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index bddd6b3cee1d..03b6b4c2238d 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c | |||
| @@ -7,7 +7,6 @@ | |||
| 7 | #include <linux/export.h> | 7 | #include <linux/export.h> |
| 8 | #include <linux/cpu.h> | 8 | #include <linux/cpu.h> |
| 9 | #include <linux/debugfs.h> | 9 | #include <linux/debugfs.h> |
| 10 | #include <linux/ptrace.h> | ||
| 11 | 10 | ||
| 12 | #include <asm/tlbflush.h> | 11 | #include <asm/tlbflush.h> |
| 13 | #include <asm/mmu_context.h> | 12 | #include <asm/mmu_context.h> |
| @@ -31,6 +30,12 @@ | |||
| 31 | */ | 30 | */ |
| 32 | 31 | ||
| 33 | /* | 32 | /* |
| 33 | * Use bit 0 to mangle the TIF_SPEC_IB state into the mm pointer which is | ||
| 34 | * stored in cpu_tlb_state.last_user_mm_ibpb. | ||
| 35 | */ | ||
| 36 | #define LAST_USER_MM_IBPB 0x1UL | ||
| 37 | |||
| 38 | /* | ||
| 34 | * We get here when we do something requiring a TLB invalidation | 39 | * We get here when we do something requiring a TLB invalidation |
| 35 | * but could not go invalidate all of the contexts. We do the | 40 | * but could not go invalidate all of the contexts. We do the |
| 36 | * necessary invalidation by clearing out the 'ctx_id' which | 41 | * necessary invalidation by clearing out the 'ctx_id' which |
| @@ -181,17 +186,87 @@ static void sync_current_stack_to_mm(struct mm_struct *mm) | |||
| 181 | } | 186 | } |
| 182 | } | 187 | } |
| 183 | 188 | ||
| 184 | static bool ibpb_needed(struct task_struct *tsk, u64 last_ctx_id) | 189 | static inline unsigned long mm_mangle_tif_spec_ib(struct task_struct *next) |
| 190 | { | ||
| 191 | unsigned long next_tif = task_thread_info(next)->flags; | ||
| 192 | unsigned long ibpb = (next_tif >> TIF_SPEC_IB) & LAST_USER_MM_IBPB; | ||
| 193 | |||
| 194 | return (unsigned long)next->mm | ibpb; | ||
| 195 | } | ||
| 196 | |||
| 197 | static void cond_ibpb(struct task_struct *next) | ||
| 185 | { | 198 | { |
| 199 | if (!next || !next->mm) | ||
| 200 | return; | ||
| 201 | |||
| 186 | /* | 202 | /* |
| 187 | * Check if the current (previous) task has access to the memory | 203 | * Both, the conditional and the always IBPB mode use the mm |
| 188 | * of the @tsk (next) task. If access is denied, make sure to | 204 | * pointer to avoid the IBPB when switching between tasks of the |
| 189 | * issue a IBPB to stop user->user Spectre-v2 attacks. | 205 | * same process. Using the mm pointer instead of mm->context.ctx_id |
| 190 | * | 206 | * opens a hypothetical hole vs. mm_struct reuse, which is more or |
| 191 | * Note: __ptrace_may_access() returns 0 or -ERRNO. | 207 | * less impossible to control by an attacker. Aside of that it |
| 208 | * would only affect the first schedule so the theoretically | ||
| 209 | * exposed data is not really interesting. | ||
| 192 | */ | 210 | */ |
| 193 | return (tsk && tsk->mm && tsk->mm->context.ctx_id != last_ctx_id && | 211 | if (static_branch_likely(&switch_mm_cond_ibpb)) { |
| 194 | ptrace_may_access_sched(tsk, PTRACE_MODE_SPEC_IBPB)); | 212 | unsigned long prev_mm, next_mm; |
| 213 | |||
| 214 | /* | ||
| 215 | * This is a bit more complex than the always mode because | ||
| 216 | * it has to handle two cases: | ||
| 217 | * | ||
| 218 | * 1) Switch from a user space task (potential attacker) | ||
| 219 | * which has TIF_SPEC_IB set to a user space task | ||
| 220 | * (potential victim) which has TIF_SPEC_IB not set. | ||
| 221 | * | ||
| 222 | * 2) Switch from a user space task (potential attacker) | ||
| 223 | * which has TIF_SPEC_IB not set to a user space task | ||
| 224 | * (potential victim) which has TIF_SPEC_IB set. | ||
| 225 | * | ||
| 226 | * This could be done by unconditionally issuing IBPB when | ||
| 227 | * a task which has TIF_SPEC_IB set is either scheduled in | ||
| 228 | * or out. Though that results in two flushes when: | ||
| 229 | * | ||
| 230 | * - the same user space task is scheduled out and later | ||
| 231 | * scheduled in again and only a kernel thread ran in | ||
| 232 | * between. | ||
| 233 | * | ||
| 234 | * - a user space task belonging to the same process is | ||
| 235 | * scheduled in after a kernel thread ran in between | ||
| 236 | * | ||
| 237 | * - a user space task belonging to the same process is | ||
| 238 | * scheduled in immediately. | ||
| 239 | * | ||
| 240 | * Optimize this with reasonably small overhead for the | ||
| 241 | * above cases. Mangle the TIF_SPEC_IB bit into the mm | ||
| 242 | * pointer of the incoming task which is stored in | ||
| 243 | * cpu_tlbstate.last_user_mm_ibpb for comparison. | ||
| 244 | */ | ||
| 245 | next_mm = mm_mangle_tif_spec_ib(next); | ||
| 246 | prev_mm = this_cpu_read(cpu_tlbstate.last_user_mm_ibpb); | ||
| 247 | |||
| 248 | /* | ||
| 249 | * Issue IBPB only if the mm's are different and one or | ||
| 250 | * both have the IBPB bit set. | ||
| 251 | */ | ||
| 252 | if (next_mm != prev_mm && | ||
| 253 | (next_mm | prev_mm) & LAST_USER_MM_IBPB) | ||
| 254 | indirect_branch_prediction_barrier(); | ||
| 255 | |||
| 256 | this_cpu_write(cpu_tlbstate.last_user_mm_ibpb, next_mm); | ||
| 257 | } | ||
| 258 | |||
| 259 | if (static_branch_unlikely(&switch_mm_always_ibpb)) { | ||
| 260 | /* | ||
| 261 | * Only flush when switching to a user space task with a | ||
| 262 | * different context than the user space task which ran | ||
| 263 | * last on this CPU. | ||
| 264 | */ | ||
| 265 | if (this_cpu_read(cpu_tlbstate.last_user_mm) != next->mm) { | ||
| 266 | indirect_branch_prediction_barrier(); | ||
| 267 | this_cpu_write(cpu_tlbstate.last_user_mm, next->mm); | ||
| 268 | } | ||
| 269 | } | ||
| 195 | } | 270 | } |
| 196 | 271 | ||
| 197 | void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, | 272 | void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, |
| @@ -292,22 +367,12 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, | |||
| 292 | new_asid = prev_asid; | 367 | new_asid = prev_asid; |
| 293 | need_flush = true; | 368 | need_flush = true; |
| 294 | } else { | 369 | } else { |
| 295 | u64 last_ctx_id = this_cpu_read(cpu_tlbstate.last_ctx_id); | ||
| 296 | |||
| 297 | /* | 370 | /* |
| 298 | * Avoid user/user BTB poisoning by flushing the branch | 371 | * Avoid user/user BTB poisoning by flushing the branch |
| 299 | * predictor when switching between processes. This stops | 372 | * predictor when switching between processes. This stops |
| 300 | * one process from doing Spectre-v2 attacks on another. | 373 | * one process from doing Spectre-v2 attacks on another. |
| 301 | * | ||
| 302 | * As an optimization, flush indirect branches only when | ||
| 303 | * switching into a processes that can't be ptrace by the | ||
| 304 | * current one (as in such case, attacker has much more | ||
| 305 | * convenient way how to tamper with the next process than | ||
| 306 | * branch buffer poisoning). | ||
| 307 | */ | 374 | */ |
| 308 | if (static_cpu_has(X86_FEATURE_USE_IBPB) && | 375 | cond_ibpb(tsk); |
| 309 | ibpb_needed(tsk, last_ctx_id)) | ||
| 310 | indirect_branch_prediction_barrier(); | ||
| 311 | 376 | ||
| 312 | if (IS_ENABLED(CONFIG_VMAP_STACK)) { | 377 | if (IS_ENABLED(CONFIG_VMAP_STACK)) { |
| 313 | /* | 378 | /* |
| @@ -365,14 +430,6 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, | |||
| 365 | trace_tlb_flush_rcuidle(TLB_FLUSH_ON_TASK_SWITCH, 0); | 430 | trace_tlb_flush_rcuidle(TLB_FLUSH_ON_TASK_SWITCH, 0); |
| 366 | } | 431 | } |
| 367 | 432 | ||
| 368 | /* | ||
| 369 | * Record last user mm's context id, so we can avoid | ||
| 370 | * flushing branch buffer with IBPB if we switch back | ||
| 371 | * to the same user. | ||
| 372 | */ | ||
| 373 | if (next != &init_mm) | ||
| 374 | this_cpu_write(cpu_tlbstate.last_ctx_id, next->context.ctx_id); | ||
| 375 | |||
| 376 | /* Make sure we write CR3 before loaded_mm. */ | 433 | /* Make sure we write CR3 before loaded_mm. */ |
| 377 | barrier(); | 434 | barrier(); |
| 378 | 435 | ||
| @@ -441,7 +498,7 @@ void initialize_tlbstate_and_flush(void) | |||
| 441 | write_cr3(build_cr3(mm->pgd, 0)); | 498 | write_cr3(build_cr3(mm->pgd, 0)); |
| 442 | 499 | ||
| 443 | /* Reinitialize tlbstate. */ | 500 | /* Reinitialize tlbstate. */ |
| 444 | this_cpu_write(cpu_tlbstate.last_ctx_id, mm->context.ctx_id); | 501 | this_cpu_write(cpu_tlbstate.last_user_mm_ibpb, LAST_USER_MM_IBPB); |
| 445 | this_cpu_write(cpu_tlbstate.loaded_mm_asid, 0); | 502 | this_cpu_write(cpu_tlbstate.loaded_mm_asid, 0); |
| 446 | this_cpu_write(cpu_tlbstate.next_asid, 1); | 503 | this_cpu_write(cpu_tlbstate.next_asid, 1); |
| 447 | this_cpu_write(cpu_tlbstate.ctxs[0].ctx_id, mm->context.ctx_id); | 504 | this_cpu_write(cpu_tlbstate.ctxs[0].ctx_id, mm->context.ctx_id); |
