aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>2015-05-12 17:50:05 -0400
committerCatalin Marinas <catalin.marinas@arm.com>2015-05-21 09:24:26 -0400
commit05981277a4de1ad631a4b2c39c4fbc1db69b6f23 (patch)
treec6b224570f92de5e767abb5accb847b619ebbd50 /arch
parent5b09a094f2fb768c76c8d4a82503df6fc7e1df63 (diff)
arm64: Use common outgoing-CPU-notification code
This commit removes the open-coded CPU-offline notification with new common code. In particular, this change avoids calling scheduler code using RCU from an offline CPU that RCU is ignoring. This is a minimal change. A more intrusive change might invoke the cpu_check_up_prepare() and cpu_set_state_online() functions at CPU-online time, which would allow onlining throw an error if the CPU did not go offline properly. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: linux-arm-kernel@lists.infradead.org Acked-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/arm64/kernel/smp.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index b698208848e9..65f1a7f72697 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -254,15 +254,13 @@ static int op_cpu_kill(unsigned int cpu)
254 return cpu_ops[cpu]->cpu_kill(cpu); 254 return cpu_ops[cpu]->cpu_kill(cpu);
255} 255}
256 256
257static DECLARE_COMPLETION(cpu_died);
258
259/* 257/*
260 * called on the thread which is asking for a CPU to be shutdown - 258 * called on the thread which is asking for a CPU to be shutdown -
261 * waits until shutdown has completed, or it is timed out. 259 * waits until shutdown has completed, or it is timed out.
262 */ 260 */
263void __cpu_die(unsigned int cpu) 261void __cpu_die(unsigned int cpu)
264{ 262{
265 if (!wait_for_completion_timeout(&cpu_died, msecs_to_jiffies(5000))) { 263 if (!cpu_wait_death(cpu, 5)) {
266 pr_crit("CPU%u: cpu didn't die\n", cpu); 264 pr_crit("CPU%u: cpu didn't die\n", cpu);
267 return; 265 return;
268 } 266 }
@@ -295,7 +293,7 @@ void cpu_die(void)
295 local_irq_disable(); 293 local_irq_disable();
296 294
297 /* Tell __cpu_die() that this CPU is now safe to dispose of */ 295 /* Tell __cpu_die() that this CPU is now safe to dispose of */
298 complete(&cpu_died); 296 (void)cpu_report_death();
299 297
300 /* 298 /*
301 * Actually shutdown the CPU. This must never fail. The specific hotplug 299 * Actually shutdown the CPU. This must never fail. The specific hotplug