aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/kvm/mmu.c
diff options
context:
space:
mode:
authorKarimAllah Ahmed <karahmed@amazon.de>2019-01-31 15:24:44 -0500
committerPaolo Bonzini <pbonzini@redhat.com>2019-04-30 15:49:46 -0400
commit0c55671f84fffe591e8435c93a8c83286fd6b8eb (patch)
tree19ffa33fdc2f35cadd344f601b60810b3758fcd1 /arch/x86/kvm/mmu.c
parente0bf2665ca26c1f6d6909de29bd382e7a5ee41e7 (diff)
kvm, x86: Properly check whether a pfn is an MMIO or not
pfn_valid check is not sufficient because it only checks if a page has a struct page or not, if "mem=" was passed to the kernel some valid pages won't have a struct page. This means that if guests were assigned valid memory that lies after the mem= boundary it will be passed uncached to the guest no matter what the guest caching attributes are for this memory. Introduce a new function e820__mapped_raw_any which is equivalent to e820__mapped_any but uses the original e820 unmodified and use it to identify real *RAM*. Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86/kvm/mmu.c')
-rw-r--r--arch/x86/kvm/mmu.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index e10962dfc203..b1f6451022e5 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -44,6 +44,7 @@
44#include <asm/page.h> 44#include <asm/page.h>
45#include <asm/pat.h> 45#include <asm/pat.h>
46#include <asm/cmpxchg.h> 46#include <asm/cmpxchg.h>
47#include <asm/e820/api.h>
47#include <asm/io.h> 48#include <asm/io.h>
48#include <asm/vmx.h> 49#include <asm/vmx.h>
49#include <asm/kvm_page_track.h> 50#include <asm/kvm_page_track.h>
@@ -2892,7 +2893,9 @@ static bool kvm_is_mmio_pfn(kvm_pfn_t pfn)
2892 */ 2893 */
2893 (!pat_enabled() || pat_pfn_immune_to_uc_mtrr(pfn)); 2894 (!pat_enabled() || pat_pfn_immune_to_uc_mtrr(pfn));
2894 2895
2895 return true; 2896 return !e820__mapped_raw_any(pfn_to_hpa(pfn),
2897 pfn_to_hpa(pfn + 1) - 1,
2898 E820_TYPE_RAM);
2896} 2899}
2897 2900
2898/* Bits which may be returned by set_spte() */ 2901/* Bits which may be returned by set_spte() */