x86/dumpstack: Remove raw stack dump

For mostly historical reasons, the x86 oops dump shows the raw stack
values:

  ...
  [registers]
  Stack:
   ffff880079af7350 ffff880079905400 0000000000000000 ffffc900008f3ae0
   ffffffffa0196610 0000000000000001 00010000ffffffff 0000000087654321
   0000000000000002 0000000000000000 0000000000000000 0000000000000000
  Call Trace:
  ...

This seems to be an artifact from long ago, and probably isn't needed
anymore.  It generally just adds noise to the dump, and it can be
actively harmful because it leaks kernel addresses.

Linus says:

  "The stack dump actually goes back to forever, and it used to be
   useful back in 1992 or so. But it used to be useful mainly because
   stacks were simpler and we didn't have very good call traces anyway. I
   definitely remember having used them - I just do not remember having
   used them in the last ten+ years.

   Of course, it's still true that if you can trigger an oops, you've
   likely already lost the security game, but since the stack dump is so
   useless, let's aim to just remove it and make games like the above
   harder."

This also removes the related 'kstack=' cmdline option and the
'kstack_depth_to_print' sysctl.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/e83bd50df52d8fe88e94d2566426ae40d813bf8f.1477405374.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

1 files changed, 1 insertions, 32 deletions

diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c
index 06eb322b5f9f..90cf460d50bd 100644
--- a/arch/x86/kernel/dumpstack_32.c
+++ b/arch/x86/kernel/dumpstack_32.c
@@ -121,36 +121,6 @@ unknown:
         return -EINVAL;
 }
 
-void show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
-                        unsigned long *sp, char *log_lvl)
-{
-        unsigned long *stack;
-        int i;
-
-        if (!try_get_task_stack(task))
-                return;
-
-        sp = sp ? : get_stack_pointer(task, regs);
-
-        stack = sp;
-        for (i = 0; i < kstack_depth_to_print; i++) {
-                if (kstack_end(stack))
-                        break;
-                if ((i % STACKSLOTS_PER_LINE) == 0) {
-                        if (i != 0)
-                                pr_cont("\n");
-                        printk("%s %08lx", log_lvl, *stack++);
-                } else
-                        pr_cont(" %08lx", *stack++);
-                touch_nmi_watchdog();
-        }
-        pr_cont("\n");
-        show_trace_log_lvl(task, regs, sp, log_lvl);
-
-        put_task_stack(task);
-}
-
-
 void show_regs(struct pt_regs *regs)
 {
         int i;
@@ -168,8 +138,7 @@ void show_regs(struct pt_regs *regs)
                 unsigned char c;
                 u8 *ip;
 
-                pr_emerg("Stack:\n");
-                show_stack_log_lvl(current, regs, NULL, KERN_EMERG);
+                show_trace_log_lvl(current, regs, NULL, KERN_EMERG);
 
                 pr_emerg("Code:");