aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/kernel/apic/apic.c
diff options
context:
space:
mode:
authorSeiji Aguchi <seiji.aguchi@hds.com>2013-06-20 11:46:53 -0400
committerH. Peter Anvin <hpa@linux.intel.com>2013-06-21 01:25:34 -0400
commitcf910e83ae23692fdeefc7e506e504c4c468d38a (patch)
tree6e99fecdfd579bd7046488fb3c79e837d46eea08 /arch/x86/kernel/apic/apic.c
parent629f4f9d59a27d8e58aa612e886e6a9a63ea7aeb (diff)
x86, trace: Add irq vector tracepoints
[Purpose of this patch] As Vaibhav explained in the thread below, tracepoints for irq vectors are useful. http://www.spinics.net/lists/mm-commits/msg85707.html <snip> The current interrupt traces from irq_handler_entry and irq_handler_exit provide when an interrupt is handled. They provide good data about when the system has switched to kernel space and how it affects the currently running processes. There are some IRQ vectors which trigger the system into kernel space, which are not handled in generic IRQ handlers. Tracing such events gives us the information about IRQ interaction with other system events. The trace also tells where the system is spending its time. We want to know which cores are handling interrupts and how they are affecting other processes in the system. Also, the trace provides information about when the cores are idle and which interrupts are changing that state. <snip> On the other hand, my usecase is tracing just local timer event and getting a value of instruction pointer. I suggested to add an argument local timer event to get instruction pointer before. But there is another way to get it with external module like systemtap. So, I don't need to add any argument to irq vector tracepoints now. [Patch Description] Vaibhav's patch shared a trace point ,irq_vector_entry/irq_vector_exit, in all events. But there is an above use case to trace specific irq_vector rather than tracing all events. In this case, we are concerned about overhead due to unwanted events. So, add following tracepoints instead of introducing irq_vector_entry/exit. so that we can enable them independently. - local_timer_vector - reschedule_vector - call_function_vector - call_function_single_vector - irq_work_entry_vector - error_apic_vector - thermal_apic_vector - threshold_apic_vector - spurious_apic_vector - x86_platform_ipi_vector Also, introduce a logic switching IDT at enabling/disabling time so that a time penalty makes a zero when tracepoints are disabled. Detailed explanations are as follows. - Create trace irq handlers with entering_irq()/exiting_irq(). - Create a new IDT, trace_idt_table, at boot time by adding a logic to _set_gate(). It is just a copy of original idt table. - Register the new handlers for tracpoints to the new IDT by introducing macros to alloc_intr_gate() called at registering time of irq_vector handlers. - Add checking, whether irq vector tracing is on/off, into load_current_idt(). This has to be done below debug checking for these reasons. - Switching to debug IDT may be kicked while tracing is enabled. - On the other hands, switching to trace IDT is kicked only when debugging is disabled. In addition, the new IDT is created only when CONFIG_TRACING is enabled to avoid being used for other purposes. Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com> Link: http://lkml.kernel.org/r/51C323ED.5050708@hds.com Signed-off-by: H. Peter Anvin <hpa@linux.intel.com> Cc: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'arch/x86/kernel/apic/apic.c')
-rw-r--r--arch/x86/kernel/apic/apic.c42
1 files changed, 42 insertions, 0 deletions
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 59ee76fe1c53..61ced40e9c2c 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -55,6 +55,9 @@
55#include <asm/tsc.h> 55#include <asm/tsc.h>
56#include <asm/hypervisor.h> 56#include <asm/hypervisor.h>
57 57
58#define CREATE_TRACE_POINTS
59#include <asm/trace/irq_vectors.h>
60
58unsigned int num_processors; 61unsigned int num_processors;
59 62
60unsigned disabled_cpus __cpuinitdata; 63unsigned disabled_cpus __cpuinitdata;
@@ -931,6 +934,27 @@ void __irq_entry smp_apic_timer_interrupt(struct pt_regs *regs)
931 set_irq_regs(old_regs); 934 set_irq_regs(old_regs);
932} 935}
933 936
937void __irq_entry smp_trace_apic_timer_interrupt(struct pt_regs *regs)
938{
939 struct pt_regs *old_regs = set_irq_regs(regs);
940
941 /*
942 * NOTE! We'd better ACK the irq immediately,
943 * because timer handling can be slow.
944 *
945 * update_process_times() expects us to have done irq_enter().
946 * Besides, if we don't timer interrupts ignore the global
947 * interrupt lock, which is the WrongThing (tm) to do.
948 */
949 entering_ack_irq();
950 trace_local_timer_entry(LOCAL_TIMER_VECTOR);
951 local_apic_timer_interrupt();
952 trace_local_timer_exit(LOCAL_TIMER_VECTOR);
953 exiting_irq();
954
955 set_irq_regs(old_regs);
956}
957
934int setup_profiling_timer(unsigned int multiplier) 958int setup_profiling_timer(unsigned int multiplier)
935{ 959{
936 return -EINVAL; 960 return -EINVAL;
@@ -1931,6 +1955,15 @@ void smp_spurious_interrupt(struct pt_regs *regs)
1931 exiting_irq(); 1955 exiting_irq();
1932} 1956}
1933 1957
1958void smp_trace_spurious_interrupt(struct pt_regs *regs)
1959{
1960 entering_irq();
1961 trace_spurious_apic_entry(SPURIOUS_APIC_VECTOR);
1962 __smp_spurious_interrupt();
1963 trace_spurious_apic_exit(SPURIOUS_APIC_VECTOR);
1964 exiting_irq();
1965}
1966
1934/* 1967/*
1935 * This interrupt should never happen with our APIC/SMP architecture 1968 * This interrupt should never happen with our APIC/SMP architecture
1936 */ 1969 */
@@ -1978,6 +2011,15 @@ void smp_error_interrupt(struct pt_regs *regs)
1978 exiting_irq(); 2011 exiting_irq();
1979} 2012}
1980 2013
2014void smp_trace_error_interrupt(struct pt_regs *regs)
2015{
2016 entering_irq();
2017 trace_error_apic_entry(ERROR_APIC_VECTOR);
2018 __smp_error_interrupt(regs);
2019 trace_error_apic_exit(ERROR_APIC_VECTOR);
2020 exiting_irq();
2021}
2022
1981/** 2023/**
1982 * connect_bsp_APIC - attach the APIC to the interrupt system 2024 * connect_bsp_APIC - attach the APIC to the interrupt system
1983 */ 2025 */