diff options
author | Michal Hocko <mhocko@suse.com> | 2016-06-24 17:49:14 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-06-24 20:23:52 -0400 |
commit | 45eeff260d40ff02af3d5b8e2919033ee59f9ff6 (patch) | |
tree | e487da80c8d2776815f65dadb930075941f56178 /arch/sparc/include | |
parent | 2379a23e34b58520dfc8f4909f116a08393138e4 (diff) |
sparc: get rid of superfluous __GFP_REPEAT
__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.
{pud,pmd}_alloc_one is using __GFP_REPEAT but it always allocates from
pgtable_cache which is initialzed to PAGE_SIZE objects. This means that
this flag has never been actually useful here because it has always been
used only for PAGE_ALLOC_COSTLY requests.
Link: http://lkml.kernel.org/r/1464599699-30131-13-git-send-email-mhocko@kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/sparc/include')
-rw-r--r-- | arch/sparc/include/asm/pgalloc_64.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/arch/sparc/include/asm/pgalloc_64.h b/arch/sparc/include/asm/pgalloc_64.h index 5e3187185b4a..3529f1378cd8 100644 --- a/arch/sparc/include/asm/pgalloc_64.h +++ b/arch/sparc/include/asm/pgalloc_64.h | |||
@@ -41,8 +41,7 @@ static inline void __pud_populate(pud_t *pud, pmd_t *pmd) | |||
41 | 41 | ||
42 | static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr) | 42 | static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr) |
43 | { | 43 | { |
44 | return kmem_cache_alloc(pgtable_cache, | 44 | return kmem_cache_alloc(pgtable_cache, GFP_KERNEL); |
45 | GFP_KERNEL|__GFP_REPEAT); | ||
46 | } | 45 | } |
47 | 46 | ||
48 | static inline void pud_free(struct mm_struct *mm, pud_t *pud) | 47 | static inline void pud_free(struct mm_struct *mm, pud_t *pud) |
@@ -52,8 +51,7 @@ static inline void pud_free(struct mm_struct *mm, pud_t *pud) | |||
52 | 51 | ||
53 | static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr) | 52 | static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr) |
54 | { | 53 | { |
55 | return kmem_cache_alloc(pgtable_cache, | 54 | return kmem_cache_alloc(pgtable_cache, GFP_KERNEL); |
56 | GFP_KERNEL|__GFP_REPEAT); | ||
57 | } | 55 | } |
58 | 56 | ||
59 | static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) | 57 | static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) |