diff options
author | Dominik Dingel <dingel@linux.vnet.ibm.com> | 2016-01-11 05:47:12 -0500 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2016-01-19 06:14:01 -0500 |
commit | a9d7ab97812cf2cf9fd7c980205ae35f58c52cf5 (patch) | |
tree | f49227f42f564a4d435ea5ae989e6f1b645c76cb /arch/s390/mm | |
parent | a200dcb34693084e56496960d855afdeaaf9578f (diff) |
s390/mm: use TASK_MAX_SIZE where applicable
To improve readability we can use TASK_MAX_SIZE when we just check for the
upper limit. All places explicitly dealing with 3 vs 4 level pgtables
were left unchanged.
Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
Reviewed-By: Sascha Silbe <silbe@linux.vnet.ibm.com>
Diffstat (limited to 'arch/s390/mm')
-rw-r--r-- | arch/s390/mm/mmap.c | 12 | ||||
-rw-r--r-- | arch/s390/mm/pgtable.c | 2 |
2 files changed, 7 insertions, 7 deletions
diff --git a/arch/s390/mm/mmap.c b/arch/s390/mm/mmap.c index ea01477b4aa6..45c4daa49930 100644 --- a/arch/s390/mm/mmap.c +++ b/arch/s390/mm/mmap.c | |||
@@ -169,12 +169,12 @@ arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0, | |||
169 | 169 | ||
170 | int s390_mmap_check(unsigned long addr, unsigned long len, unsigned long flags) | 170 | int s390_mmap_check(unsigned long addr, unsigned long len, unsigned long flags) |
171 | { | 171 | { |
172 | if (is_compat_task() || (TASK_SIZE >= (1UL << 53))) | 172 | if (is_compat_task() || TASK_SIZE >= TASK_MAX_SIZE) |
173 | return 0; | 173 | return 0; |
174 | if (!(flags & MAP_FIXED)) | 174 | if (!(flags & MAP_FIXED)) |
175 | addr = 0; | 175 | addr = 0; |
176 | if ((addr + len) >= TASK_SIZE) | 176 | if ((addr + len) >= TASK_SIZE) |
177 | return crst_table_upgrade(current->mm, 1UL << 53); | 177 | return crst_table_upgrade(current->mm, TASK_MAX_SIZE); |
178 | return 0; | 178 | return 0; |
179 | } | 179 | } |
180 | 180 | ||
@@ -189,9 +189,9 @@ s390_get_unmapped_area(struct file *filp, unsigned long addr, | |||
189 | area = arch_get_unmapped_area(filp, addr, len, pgoff, flags); | 189 | area = arch_get_unmapped_area(filp, addr, len, pgoff, flags); |
190 | if (!(area & ~PAGE_MASK)) | 190 | if (!(area & ~PAGE_MASK)) |
191 | return area; | 191 | return area; |
192 | if (area == -ENOMEM && !is_compat_task() && TASK_SIZE < (1UL << 53)) { | 192 | if (area == -ENOMEM && !is_compat_task() && TASK_SIZE < TASK_MAX_SIZE) { |
193 | /* Upgrade the page table to 4 levels and retry. */ | 193 | /* Upgrade the page table to 4 levels and retry. */ |
194 | rc = crst_table_upgrade(mm, 1UL << 53); | 194 | rc = crst_table_upgrade(mm, TASK_MAX_SIZE); |
195 | if (rc) | 195 | if (rc) |
196 | return (unsigned long) rc; | 196 | return (unsigned long) rc; |
197 | area = arch_get_unmapped_area(filp, addr, len, pgoff, flags); | 197 | area = arch_get_unmapped_area(filp, addr, len, pgoff, flags); |
@@ -211,9 +211,9 @@ s390_get_unmapped_area_topdown(struct file *filp, const unsigned long addr, | |||
211 | area = arch_get_unmapped_area_topdown(filp, addr, len, pgoff, flags); | 211 | area = arch_get_unmapped_area_topdown(filp, addr, len, pgoff, flags); |
212 | if (!(area & ~PAGE_MASK)) | 212 | if (!(area & ~PAGE_MASK)) |
213 | return area; | 213 | return area; |
214 | if (area == -ENOMEM && !is_compat_task() && TASK_SIZE < (1UL << 53)) { | 214 | if (area == -ENOMEM && !is_compat_task() && TASK_SIZE < TASK_MAX_SIZE) { |
215 | /* Upgrade the page table to 4 levels and retry. */ | 215 | /* Upgrade the page table to 4 levels and retry. */ |
216 | rc = crst_table_upgrade(mm, 1UL << 53); | 216 | rc = crst_table_upgrade(mm, TASK_MAX_SIZE); |
217 | if (rc) | 217 | if (rc) |
218 | return (unsigned long) rc; | 218 | return (unsigned long) rc; |
219 | area = arch_get_unmapped_area_topdown(filp, addr, len, | 219 | area = arch_get_unmapped_area_topdown(filp, addr, len, |
diff --git a/arch/s390/mm/pgtable.c b/arch/s390/mm/pgtable.c index a809fa8e6f8b..5109827883ac 100644 --- a/arch/s390/mm/pgtable.c +++ b/arch/s390/mm/pgtable.c | |||
@@ -55,7 +55,7 @@ int crst_table_upgrade(struct mm_struct *mm, unsigned long limit) | |||
55 | unsigned long entry; | 55 | unsigned long entry; |
56 | int flush; | 56 | int flush; |
57 | 57 | ||
58 | BUG_ON(limit > (1UL << 53)); | 58 | BUG_ON(limit > TASK_MAX_SIZE); |
59 | flush = 0; | 59 | flush = 0; |
60 | repeat: | 60 | repeat: |
61 | table = crst_table_alloc(mm); | 61 | table = crst_table_alloc(mm); |