diff options
author | Paul Burton <paul.burton@imgtec.com> | 2017-03-30 17:27:02 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2017-04-12 18:47:04 -0400 |
commit | 72f941af88a543e6a038c75b8467903b7812239c (patch) | |
tree | 610bba4faa1aafe67707498f4a1bbf60b9f1b39e /arch/mips/mm/fault.c | |
parent | e64889823d58305a5ddb2828ae0a988c59e87d7e (diff) |
MIPS: Remove confusing else statement in __do_page_fault()
Commit 41c594ab65fc ("[MIPS] MT: Improved multithreading support.")
added an else case to an if statement in do_page_fault() (which has
since gained 2 leading underscores) for some unclear reason. If the
condition in the if statement evaluates true then we execute a goto &
branch elsewhere anyway, so the else has no effect. Combined with an #if
0 block with misleading indentation introduced in the same commit it
makes the code less clear than it could be.
Remove the unnecessary else statement & de-indent the printk within
the #if 0 block in order to make the code easier for humans to parse.
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: trivial@kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/15842/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/mm/fault.c')
-rw-r--r-- | arch/mips/mm/fault.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/arch/mips/mm/fault.c b/arch/mips/mm/fault.c index 3bef306cdfdb..4f8f5bf46977 100644 --- a/arch/mips/mm/fault.c +++ b/arch/mips/mm/fault.c | |||
@@ -267,19 +267,19 @@ do_sigbus: | |||
267 | /* Kernel mode? Handle exceptions or die */ | 267 | /* Kernel mode? Handle exceptions or die */ |
268 | if (!user_mode(regs)) | 268 | if (!user_mode(regs)) |
269 | goto no_context; | 269 | goto no_context; |
270 | else | 270 | |
271 | /* | 271 | /* |
272 | * Send a sigbus, regardless of whether we were in kernel | 272 | * Send a sigbus, regardless of whether we were in kernel |
273 | * or user mode. | 273 | * or user mode. |
274 | */ | 274 | */ |
275 | #if 0 | 275 | #if 0 |
276 | printk("do_page_fault() #3: sending SIGBUS to %s for " | 276 | printk("do_page_fault() #3: sending SIGBUS to %s for " |
277 | "invalid %s\n%0*lx (epc == %0*lx, ra == %0*lx)\n", | 277 | "invalid %s\n%0*lx (epc == %0*lx, ra == %0*lx)\n", |
278 | tsk->comm, | 278 | tsk->comm, |
279 | write ? "write access to" : "read access from", | 279 | write ? "write access to" : "read access from", |
280 | field, address, | 280 | field, address, |
281 | field, (unsigned long) regs->cp0_epc, | 281 | field, (unsigned long) regs->cp0_epc, |
282 | field, (unsigned long) regs->regs[31]); | 282 | field, (unsigned long) regs->regs[31]); |
283 | #endif | 283 | #endif |
284 | current->thread.trap_nr = (regs->cp0_cause >> 2) & 0x1f; | 284 | current->thread.trap_nr = (regs->cp0_cause >> 2) & 0x1f; |
285 | tsk->thread.cp0_badvaddr = address; | 285 | tsk->thread.cp0_badvaddr = address; |