diff options
author | Matt Redfearn <matt.redfearn@imgtec.com> | 2016-09-07 05:45:19 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2016-10-04 10:13:57 -0400 |
commit | 4b6401365a6ccc53de820209cb328507a2103d30 (patch) | |
tree | c0aff3b09632c91c738b48d625edd9f9168025b0 /arch/mips/kernel | |
parent | 77451997237fa7e8ba4f5e2f0fcd99898f78ff9b (diff) |
MIPS: SMP: Wrap call to mips_cpc_lock_other in mips_cm_lock_other
All calls to mips_cpc_lock_other should be wrapped in
mips_cm_lock_other. This only matters if the system has CM3 and is using
cpu idle, since otherwise a) the CPC lock is sufficent for CM < 3 and b)
any systems with CM > 3 have not been able to use cpu idle until now.
Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Reviewed-by: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: Qais Yousef <qsyousef@gmail.com>
Patchwork: https://patchwork.linux-mips.org/patch/14227/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/kernel')
-rw-r--r-- | arch/mips/kernel/smp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c index b0baf48951fa..cb02df215365 100644 --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c | |||
@@ -192,9 +192,11 @@ void mips_smp_send_ipi_mask(const struct cpumask *mask, unsigned int action) | |||
192 | continue; | 192 | continue; |
193 | 193 | ||
194 | while (!cpumask_test_cpu(cpu, &cpu_coherent_mask)) { | 194 | while (!cpumask_test_cpu(cpu, &cpu_coherent_mask)) { |
195 | mips_cm_lock_other(core, 0); | ||
195 | mips_cpc_lock_other(core); | 196 | mips_cpc_lock_other(core); |
196 | write_cpc_co_cmd(CPC_Cx_CMD_PWRUP); | 197 | write_cpc_co_cmd(CPC_Cx_CMD_PWRUP); |
197 | mips_cpc_unlock_other(); | 198 | mips_cpc_unlock_other(); |
199 | mips_cm_unlock_other(); | ||
198 | } | 200 | } |
199 | } | 201 | } |
200 | } | 202 | } |