diff options
author | Sonny Rao <sonnyrao@chromium.org> | 2014-11-24 02:02:44 -0500 |
---|---|---|
committer | Olof Johansson <olof@lixom.net> | 2014-12-05 02:30:26 -0500 |
commit | 0b46b8a718c6e90910a1b1b0fe797be3c167e186 (patch) | |
tree | eca0d7cd13798df4bc81afe88f9686b9a3e1aaa6 /arch/arm64 | |
parent | f114040e3ea6e07372334ade75d1ee0775c355e1 (diff) |
clocksource: arch_timer: Fix code to use physical timers when requested
This is a bug fix for using physical arch timers when
the arch_timer_use_virtual boolean is false. It restores the
arch_counter_get_cntpct() function after removal in
0d651e4e "clocksource: arch_timer: use virtual counters"
We need this on certain ARMv7 systems which are architected like this:
* The firmware doesn't know and doesn't care about hypervisor mode and
we don't want to add the complexity of hypervisor there.
* The firmware isn't involved in SMP bringup or resume.
* The ARCH timer come up with an uninitialized offset between the
virtual and physical counters. Each core gets a different random
offset.
* The device boots in "Secure SVC" mode.
* Nothing has touched the reset value of CNTHCTL.PL1PCEN or
CNTHCTL.PL1PCTEN (both default to 1 at reset)
One example of such as system is RK3288 where it is much simpler to
use the physical counter since there's nobody managing the offset and
each time a core goes down and comes back up it will get reinitialized
to some other random value.
Fixes: 0d651e4e65e9 ("clocksource: arch_timer: use virtual counters")
Cc: stable@vger.kernel.org
Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
Diffstat (limited to 'arch/arm64')
-rw-r--r-- | arch/arm64/include/asm/arch_timer.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h index f19097134b02..b1fa4e614718 100644 --- a/arch/arm64/include/asm/arch_timer.h +++ b/arch/arm64/include/asm/arch_timer.h | |||
@@ -104,6 +104,15 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl) | |||
104 | asm volatile("msr cntkctl_el1, %0" : : "r" (cntkctl)); | 104 | asm volatile("msr cntkctl_el1, %0" : : "r" (cntkctl)); |
105 | } | 105 | } |
106 | 106 | ||
107 | static inline u64 arch_counter_get_cntpct(void) | ||
108 | { | ||
109 | /* | ||
110 | * AArch64 kernel and user space mandate the use of CNTVCT. | ||
111 | */ | ||
112 | BUG(); | ||
113 | return 0; | ||
114 | } | ||
115 | |||
107 | static inline u64 arch_counter_get_cntvct(void) | 116 | static inline u64 arch_counter_get_cntvct(void) |
108 | { | 117 | { |
109 | u64 cval; | 118 | u64 cval; |