diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2014-10-28 07:26:42 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2014-11-21 10:24:50 -0500 |
commit | 4ed89f2228061422ce5f62545fd0b6f6648bd2cc (patch) | |
tree | 0f37768acf995006a4299d80122a3f924e5c5763 /arch/arm/mm/fault.c | |
parent | c2459d35f5b8de077fde859b8c96a23f309b9ab2 (diff) |
ARM: convert printk(KERN_* to pr_*
Convert many (but not all) printk(KERN_* to pr_* to simplify the code.
We take the opportunity to join some printk lines together so we don't
split the message across several lines, and we also add a few levels
to some messages which were previously missing them.
Tested-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mm/fault.c')
-rw-r--r-- | arch/arm/mm/fault.c | 31 |
1 files changed, 15 insertions, 16 deletions
diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c index eb8830a4c5ed..a982dc3190df 100644 --- a/arch/arm/mm/fault.c +++ b/arch/arm/mm/fault.c | |||
@@ -63,9 +63,9 @@ void show_pte(struct mm_struct *mm, unsigned long addr) | |||
63 | if (!mm) | 63 | if (!mm) |
64 | mm = &init_mm; | 64 | mm = &init_mm; |
65 | 65 | ||
66 | printk(KERN_ALERT "pgd = %p\n", mm->pgd); | 66 | pr_alert("pgd = %p\n", mm->pgd); |
67 | pgd = pgd_offset(mm, addr); | 67 | pgd = pgd_offset(mm, addr); |
68 | printk(KERN_ALERT "[%08lx] *pgd=%08llx", | 68 | pr_alert("[%08lx] *pgd=%08llx", |
69 | addr, (long long)pgd_val(*pgd)); | 69 | addr, (long long)pgd_val(*pgd)); |
70 | 70 | ||
71 | do { | 71 | do { |
@@ -77,31 +77,31 @@ void show_pte(struct mm_struct *mm, unsigned long addr) | |||
77 | break; | 77 | break; |
78 | 78 | ||
79 | if (pgd_bad(*pgd)) { | 79 | if (pgd_bad(*pgd)) { |
80 | printk("(bad)"); | 80 | pr_cont("(bad)"); |
81 | break; | 81 | break; |
82 | } | 82 | } |
83 | 83 | ||
84 | pud = pud_offset(pgd, addr); | 84 | pud = pud_offset(pgd, addr); |
85 | if (PTRS_PER_PUD != 1) | 85 | if (PTRS_PER_PUD != 1) |
86 | printk(", *pud=%08llx", (long long)pud_val(*pud)); | 86 | pr_cont(", *pud=%08llx", (long long)pud_val(*pud)); |
87 | 87 | ||
88 | if (pud_none(*pud)) | 88 | if (pud_none(*pud)) |
89 | break; | 89 | break; |
90 | 90 | ||
91 | if (pud_bad(*pud)) { | 91 | if (pud_bad(*pud)) { |
92 | printk("(bad)"); | 92 | pr_cont("(bad)"); |
93 | break; | 93 | break; |
94 | } | 94 | } |
95 | 95 | ||
96 | pmd = pmd_offset(pud, addr); | 96 | pmd = pmd_offset(pud, addr); |
97 | if (PTRS_PER_PMD != 1) | 97 | if (PTRS_PER_PMD != 1) |
98 | printk(", *pmd=%08llx", (long long)pmd_val(*pmd)); | 98 | pr_cont(", *pmd=%08llx", (long long)pmd_val(*pmd)); |
99 | 99 | ||
100 | if (pmd_none(*pmd)) | 100 | if (pmd_none(*pmd)) |
101 | break; | 101 | break; |
102 | 102 | ||
103 | if (pmd_bad(*pmd)) { | 103 | if (pmd_bad(*pmd)) { |
104 | printk("(bad)"); | 104 | pr_cont("(bad)"); |
105 | break; | 105 | break; |
106 | } | 106 | } |
107 | 107 | ||
@@ -110,15 +110,15 @@ void show_pte(struct mm_struct *mm, unsigned long addr) | |||
110 | break; | 110 | break; |
111 | 111 | ||
112 | pte = pte_offset_map(pmd, addr); | 112 | pte = pte_offset_map(pmd, addr); |
113 | printk(", *pte=%08llx", (long long)pte_val(*pte)); | 113 | pr_cont(", *pte=%08llx", (long long)pte_val(*pte)); |
114 | #ifndef CONFIG_ARM_LPAE | 114 | #ifndef CONFIG_ARM_LPAE |
115 | printk(", *ppte=%08llx", | 115 | pr_cont(", *ppte=%08llx", |
116 | (long long)pte_val(pte[PTE_HWTABLE_PTRS])); | 116 | (long long)pte_val(pte[PTE_HWTABLE_PTRS])); |
117 | #endif | 117 | #endif |
118 | pte_unmap(pte); | 118 | pte_unmap(pte); |
119 | } while(0); | 119 | } while(0); |
120 | 120 | ||
121 | printk("\n"); | 121 | pr_cont("\n"); |
122 | } | 122 | } |
123 | #else /* CONFIG_MMU */ | 123 | #else /* CONFIG_MMU */ |
124 | void show_pte(struct mm_struct *mm, unsigned long addr) | 124 | void show_pte(struct mm_struct *mm, unsigned long addr) |
@@ -142,10 +142,9 @@ __do_kernel_fault(struct mm_struct *mm, unsigned long addr, unsigned int fsr, | |||
142 | * No handler, we'll have to terminate things with extreme prejudice. | 142 | * No handler, we'll have to terminate things with extreme prejudice. |
143 | */ | 143 | */ |
144 | bust_spinlocks(1); | 144 | bust_spinlocks(1); |
145 | printk(KERN_ALERT | 145 | pr_alert("Unable to handle kernel %s at virtual address %08lx\n", |
146 | "Unable to handle kernel %s at virtual address %08lx\n", | 146 | (addr < PAGE_SIZE) ? "NULL pointer dereference" : |
147 | (addr < PAGE_SIZE) ? "NULL pointer dereference" : | 147 | "paging request", addr); |
148 | "paging request", addr); | ||
149 | 148 | ||
150 | show_pte(mm, addr); | 149 | show_pte(mm, addr); |
151 | die("Oops", regs, fsr); | 150 | die("Oops", regs, fsr); |
@@ -551,7 +550,7 @@ do_DataAbort(unsigned long addr, unsigned int fsr, struct pt_regs *regs) | |||
551 | if (!inf->fn(addr, fsr & ~FSR_LNX_PF, regs)) | 550 | if (!inf->fn(addr, fsr & ~FSR_LNX_PF, regs)) |
552 | return; | 551 | return; |
553 | 552 | ||
554 | printk(KERN_ALERT "Unhandled fault: %s (0x%03x) at 0x%08lx\n", | 553 | pr_alert("Unhandled fault: %s (0x%03x) at 0x%08lx\n", |
555 | inf->name, fsr, addr); | 554 | inf->name, fsr, addr); |
556 | 555 | ||
557 | info.si_signo = inf->sig; | 556 | info.si_signo = inf->sig; |
@@ -583,7 +582,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs) | |||
583 | if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs)) | 582 | if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs)) |
584 | return; | 583 | return; |
585 | 584 | ||
586 | printk(KERN_ALERT "Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n", | 585 | pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n", |
587 | inf->name, ifsr, addr); | 586 | inf->name, ifsr, addr); |
588 | 587 | ||
589 | info.si_signo = inf->sig; | 588 | info.si_signo = inf->sig; |