diff options
author | Daniel Lezcano <daniel.lezcano@linaro.org> | 2014-11-12 10:03:50 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2014-11-12 15:17:27 -0500 |
commit | b82b6cca488074da3852e8a54fde1d9f74bf1557 (patch) | |
tree | 20db4b6c0d6a0180610fa392f32db7aeea515321 /arch/arm/mach-omap2 | |
parent | 206c5f60a3d902bc4b56dab2de3e88de5eb06108 (diff) |
cpuidle: Invert CPUIDLE_FLAG_TIME_VALID logic
The only place where the time is invalid is when the ACPI_CSTATE_FFH entry
method is not set. Otherwise for all the drivers, the time can be correctly
measured.
Instead of duplicating the CPUIDLE_FLAG_TIME_VALID flag in all the drivers
for all the states, just invert the logic by replacing it by the flag
CPUIDLE_FLAG_TIME_INVALID, hence we can set this flag only for the acpi idle
driver, remove the former flag from all the drivers and invert the logic with
this flag in the different governor.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'arch/arm/mach-omap2')
-rw-r--r-- | arch/arm/mach-omap2/cpuidle34xx.c | 7 | ||||
-rw-r--r-- | arch/arm/mach-omap2/cpuidle44xx.c | 5 |
2 files changed, 2 insertions, 10 deletions
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c index e18709d3b95d..aa7b379e2661 100644 --- a/arch/arm/mach-omap2/cpuidle34xx.c +++ b/arch/arm/mach-omap2/cpuidle34xx.c | |||
@@ -265,7 +265,6 @@ static struct cpuidle_driver omap3_idle_driver = { | |||
265 | .enter = omap3_enter_idle_bm, | 265 | .enter = omap3_enter_idle_bm, |
266 | .exit_latency = 2 + 2, | 266 | .exit_latency = 2 + 2, |
267 | .target_residency = 5, | 267 | .target_residency = 5, |
268 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
269 | .name = "C1", | 268 | .name = "C1", |
270 | .desc = "MPU ON + CORE ON", | 269 | .desc = "MPU ON + CORE ON", |
271 | }, | 270 | }, |
@@ -273,7 +272,6 @@ static struct cpuidle_driver omap3_idle_driver = { | |||
273 | .enter = omap3_enter_idle_bm, | 272 | .enter = omap3_enter_idle_bm, |
274 | .exit_latency = 10 + 10, | 273 | .exit_latency = 10 + 10, |
275 | .target_residency = 30, | 274 | .target_residency = 30, |
276 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
277 | .name = "C2", | 275 | .name = "C2", |
278 | .desc = "MPU ON + CORE ON", | 276 | .desc = "MPU ON + CORE ON", |
279 | }, | 277 | }, |
@@ -281,7 +279,6 @@ static struct cpuidle_driver omap3_idle_driver = { | |||
281 | .enter = omap3_enter_idle_bm, | 279 | .enter = omap3_enter_idle_bm, |
282 | .exit_latency = 50 + 50, | 280 | .exit_latency = 50 + 50, |
283 | .target_residency = 300, | 281 | .target_residency = 300, |
284 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
285 | .name = "C3", | 282 | .name = "C3", |
286 | .desc = "MPU RET + CORE ON", | 283 | .desc = "MPU RET + CORE ON", |
287 | }, | 284 | }, |
@@ -289,7 +286,6 @@ static struct cpuidle_driver omap3_idle_driver = { | |||
289 | .enter = omap3_enter_idle_bm, | 286 | .enter = omap3_enter_idle_bm, |
290 | .exit_latency = 1500 + 1800, | 287 | .exit_latency = 1500 + 1800, |
291 | .target_residency = 4000, | 288 | .target_residency = 4000, |
292 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
293 | .name = "C4", | 289 | .name = "C4", |
294 | .desc = "MPU OFF + CORE ON", | 290 | .desc = "MPU OFF + CORE ON", |
295 | }, | 291 | }, |
@@ -297,7 +293,6 @@ static struct cpuidle_driver omap3_idle_driver = { | |||
297 | .enter = omap3_enter_idle_bm, | 293 | .enter = omap3_enter_idle_bm, |
298 | .exit_latency = 2500 + 7500, | 294 | .exit_latency = 2500 + 7500, |
299 | .target_residency = 12000, | 295 | .target_residency = 12000, |
300 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
301 | .name = "C5", | 296 | .name = "C5", |
302 | .desc = "MPU RET + CORE RET", | 297 | .desc = "MPU RET + CORE RET", |
303 | }, | 298 | }, |
@@ -305,7 +300,6 @@ static struct cpuidle_driver omap3_idle_driver = { | |||
305 | .enter = omap3_enter_idle_bm, | 300 | .enter = omap3_enter_idle_bm, |
306 | .exit_latency = 3000 + 8500, | 301 | .exit_latency = 3000 + 8500, |
307 | .target_residency = 15000, | 302 | .target_residency = 15000, |
308 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
309 | .name = "C6", | 303 | .name = "C6", |
310 | .desc = "MPU OFF + CORE RET", | 304 | .desc = "MPU OFF + CORE RET", |
311 | }, | 305 | }, |
@@ -313,7 +307,6 @@ static struct cpuidle_driver omap3_idle_driver = { | |||
313 | .enter = omap3_enter_idle_bm, | 307 | .enter = omap3_enter_idle_bm, |
314 | .exit_latency = 10000 + 30000, | 308 | .exit_latency = 10000 + 30000, |
315 | .target_residency = 30000, | 309 | .target_residency = 30000, |
316 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
317 | .name = "C7", | 310 | .name = "C7", |
318 | .desc = "MPU OFF + CORE OFF", | 311 | .desc = "MPU OFF + CORE OFF", |
319 | }, | 312 | }, |
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index 2498ab025fa2..01e398a868bc 100644 --- a/arch/arm/mach-omap2/cpuidle44xx.c +++ b/arch/arm/mach-omap2/cpuidle44xx.c | |||
@@ -196,7 +196,6 @@ static struct cpuidle_driver omap4_idle_driver = { | |||
196 | /* C1 - CPU0 ON + CPU1 ON + MPU ON */ | 196 | /* C1 - CPU0 ON + CPU1 ON + MPU ON */ |
197 | .exit_latency = 2 + 2, | 197 | .exit_latency = 2 + 2, |
198 | .target_residency = 5, | 198 | .target_residency = 5, |
199 | .flags = CPUIDLE_FLAG_TIME_VALID, | ||
200 | .enter = omap_enter_idle_simple, | 199 | .enter = omap_enter_idle_simple, |
201 | .name = "C1", | 200 | .name = "C1", |
202 | .desc = "CPUx ON, MPUSS ON" | 201 | .desc = "CPUx ON, MPUSS ON" |
@@ -205,7 +204,7 @@ static struct cpuidle_driver omap4_idle_driver = { | |||
205 | /* C2 - CPU0 OFF + CPU1 OFF + MPU CSWR */ | 204 | /* C2 - CPU0 OFF + CPU1 OFF + MPU CSWR */ |
206 | .exit_latency = 328 + 440, | 205 | .exit_latency = 328 + 440, |
207 | .target_residency = 960, | 206 | .target_residency = 960, |
208 | .flags = CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_COUPLED, | 207 | .flags = CPUIDLE_FLAG_COUPLED, |
209 | .enter = omap_enter_idle_coupled, | 208 | .enter = omap_enter_idle_coupled, |
210 | .name = "C2", | 209 | .name = "C2", |
211 | .desc = "CPUx OFF, MPUSS CSWR", | 210 | .desc = "CPUx OFF, MPUSS CSWR", |
@@ -214,7 +213,7 @@ static struct cpuidle_driver omap4_idle_driver = { | |||
214 | /* C3 - CPU0 OFF + CPU1 OFF + MPU OSWR */ | 213 | /* C3 - CPU0 OFF + CPU1 OFF + MPU OSWR */ |
215 | .exit_latency = 460 + 518, | 214 | .exit_latency = 460 + 518, |
216 | .target_residency = 1100, | 215 | .target_residency = 1100, |
217 | .flags = CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_COUPLED, | 216 | .flags = CPUIDLE_FLAG_COUPLED, |
218 | .enter = omap_enter_idle_coupled, | 217 | .enter = omap_enter_idle_coupled, |
219 | .name = "C3", | 218 | .name = "C3", |
220 | .desc = "CPUx OFF, MPUSS OSWR", | 219 | .desc = "CPUx OFF, MPUSS OSWR", |