diff options
author | Miklos Szeredi <mszeredi@redhat.com> | 2018-11-01 16:31:39 -0400 |
---|---|---|
committer | Miklos Szeredi <mszeredi@redhat.com> | 2018-11-01 16:31:39 -0400 |
commit | d47748e5ae5af6572e520cc9767bbe70c22ea498 (patch) | |
tree | ae33bdfffaaa6c1e9297d33f39dff2ddee4ddb24 /Documentation/filesystems | |
parent | 5e1275808630ea3b2c97c776f40e475017535f72 (diff) |
ovl: automatically enable redirect_dir on metacopy=on
Current behavior is to automatically disable metacopy if redirect_dir is
not enabled and proceed with the mount.
If "metacopy=on" mount option was given, then this behavior can confuse the
user: no mount failure, yet metacopy is disabled.
This patch makes metacopy=on imply redirect_dir=on.
The converse is also true: turning off full redirect with redirect_dir=
{off|follow|nofollow} will disable metacopy.
If both metacopy=on and redirect_dir={off|follow|nofollow} is specified,
then mount will fail, since there's no way to correctly resolve the
conflict.
Reported-by: Daniel Walsh <dwalsh@redhat.com>
Fixes: d5791044d2e5 ("ovl: Provide a mount option metacopy=on/off...")
Cc: <stable@vger.kernel.org> # v4.19
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'Documentation/filesystems')
-rw-r--r-- | Documentation/filesystems/overlayfs.txt | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/Documentation/filesystems/overlayfs.txt b/Documentation/filesystems/overlayfs.txt index 51c136c821bf..eef7d9d259e8 100644 --- a/Documentation/filesystems/overlayfs.txt +++ b/Documentation/filesystems/overlayfs.txt | |||
@@ -286,6 +286,12 @@ pointed by REDIRECT. This should not be possible on local system as setting | |||
286 | "trusted." xattrs will require CAP_SYS_ADMIN. But it should be possible | 286 | "trusted." xattrs will require CAP_SYS_ADMIN. But it should be possible |
287 | for untrusted layers like from a pen drive. | 287 | for untrusted layers like from a pen drive. |
288 | 288 | ||
289 | Note: redirect_dir={off|nofollow|follow(*)} conflicts with metacopy=on, and | ||
290 | results in an error. | ||
291 | |||
292 | (*) redirect_dir=follow only conflicts with metacopy=on if upperdir=... is | ||
293 | given. | ||
294 | |||
289 | Sharing and copying layers | 295 | Sharing and copying layers |
290 | -------------------------- | 296 | -------------------------- |
291 | 297 | ||