diff options
| author | J. Bruce Fields <bfields@citi.umich.edu> | 2008-02-13 18:03:20 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-13 19:21:18 -0500 |
| commit | df24d9a6a9014010513d6af1105f4de05c504a4b (patch) | |
| tree | 5d1d444a158c8b93dd8ccf66ced758b02d62d00c /Documentation/SubmitChecklist | |
| parent | 064d9efe947542097be669581f82d6b097e81d1a (diff) | |
Documentation: prune redundant SubmitChecklist items
Kernel style is mentioned twice, and the git apply trick is a bit redundant
given the checkpatch.pl recommendation (which also checks for bad
whitespace).
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation/SubmitChecklist')
| -rw-r--r-- | Documentation/SubmitChecklist | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/Documentation/SubmitChecklist b/Documentation/SubmitChecklist index 34e06d2f194f..da10e0714241 100644 --- a/Documentation/SubmitChecklist +++ b/Documentation/SubmitChecklist | |||
| @@ -20,7 +20,11 @@ kernel patches. | |||
| 20 | 4: ppc64 is a good architecture for cross-compilation checking because it | 20 | 4: ppc64 is a good architecture for cross-compilation checking because it |
| 21 | tends to use `unsigned long' for 64-bit quantities. | 21 | tends to use `unsigned long' for 64-bit quantities. |
| 22 | 22 | ||
| 23 | 5: Matches kernel coding style(!) | 23 | 5: Check your patch for general style as detailed in |
| 24 | Documentation/CodingStyle. Check for trivial violations with the | ||
| 25 | patch style checker prior to submission (scripts/checkpatch.pl). | ||
| 26 | You should be able to justify all violations that remain in | ||
| 27 | your patch. | ||
| 24 | 28 | ||
| 25 | 6: Any new or modified CONFIG options don't muck up the config menu. | 29 | 6: Any new or modified CONFIG options don't muck up the config menu. |
| 26 | 30 | ||
| @@ -79,13 +83,3 @@ kernel patches. | |||
| 79 | 23: Tested after it has been merged into the -mm patchset to make sure | 83 | 23: Tested after it has been merged into the -mm patchset to make sure |
| 80 | that it still works with all of the other queued patches and various | 84 | that it still works with all of the other queued patches and various |
| 81 | changes in the VM, VFS, and other subsystems. | 85 | changes in the VM, VFS, and other subsystems. |
| 82 | |||
| 83 | 24: Avoid whitespace damage such as indenting with spaces or whitespace | ||
| 84 | at the end of lines. You can test this by feeding the patch to | ||
| 85 | "git apply --check --whitespace=error-all" | ||
| 86 | |||
| 87 | 25: Check your patch for general style as detailed in | ||
| 88 | Documentation/CodingStyle. Check for trivial violations with the | ||
| 89 | patch style checker prior to submission (scripts/checkpatch.pl). | ||
| 90 | You should be able to justify all violations that remain in | ||
| 91 | your patch. | ||
