diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2015-06-04 13:19:34 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-06-04 13:19:34 -0400 |
commit | ff25ea8f4eeea252bfcaf65289fa57ba6de080dd (patch) | |
tree | fc945fd4e974972c7920e9949d1c3e7d4172ceb2 | |
parent | 8a7deb362b764cd557380a3c753f0118304eaa77 (diff) | |
parent | 429770823d961187c39df490d49683c467b10065 (diff) |
Merge branch 'fixes' of git://git.infradead.org/users/vkoul/slave-dma
Pull dmaengine fixes from Vinod Koul:
"We have two small fixes:
- pl330 termination hang fix by Krzysztof
- hsu memory leak fix by Peter"
* 'fixes' of git://git.infradead.org/users/vkoul/slave-dma:
dmaengine: hsu: Fix memory leak when stopping a running transfer
dmaengine: pl330: Fix hang on dmaengine_terminate_all on certain boards
-rw-r--r-- | drivers/dma/hsu/hsu.c | 5 | ||||
-rw-r--r-- | drivers/dma/pl330.c | 3 |
2 files changed, 7 insertions, 1 deletions
diff --git a/drivers/dma/hsu/hsu.c b/drivers/dma/hsu/hsu.c index 9b84def7a353..f42f71e37e73 100644 --- a/drivers/dma/hsu/hsu.c +++ b/drivers/dma/hsu/hsu.c | |||
@@ -384,7 +384,10 @@ static int hsu_dma_terminate_all(struct dma_chan *chan) | |||
384 | spin_lock_irqsave(&hsuc->vchan.lock, flags); | 384 | spin_lock_irqsave(&hsuc->vchan.lock, flags); |
385 | 385 | ||
386 | hsu_dma_stop_channel(hsuc); | 386 | hsu_dma_stop_channel(hsuc); |
387 | hsuc->desc = NULL; | 387 | if (hsuc->desc) { |
388 | hsu_dma_desc_free(&hsuc->desc->vdesc); | ||
389 | hsuc->desc = NULL; | ||
390 | } | ||
388 | 391 | ||
389 | vchan_get_all_descriptors(&hsuc->vchan, &head); | 392 | vchan_get_all_descriptors(&hsuc->vchan, &head); |
390 | spin_unlock_irqrestore(&hsuc->vchan.lock, flags); | 393 | spin_unlock_irqrestore(&hsuc->vchan.lock, flags); |
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index a7d9d3029b14..340f9e607cd8 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c | |||
@@ -2127,6 +2127,7 @@ static int pl330_terminate_all(struct dma_chan *chan) | |||
2127 | struct pl330_dmac *pl330 = pch->dmac; | 2127 | struct pl330_dmac *pl330 = pch->dmac; |
2128 | LIST_HEAD(list); | 2128 | LIST_HEAD(list); |
2129 | 2129 | ||
2130 | pm_runtime_get_sync(pl330->ddma.dev); | ||
2130 | spin_lock_irqsave(&pch->lock, flags); | 2131 | spin_lock_irqsave(&pch->lock, flags); |
2131 | spin_lock(&pl330->lock); | 2132 | spin_lock(&pl330->lock); |
2132 | _stop(pch->thread); | 2133 | _stop(pch->thread); |
@@ -2151,6 +2152,8 @@ static int pl330_terminate_all(struct dma_chan *chan) | |||
2151 | list_splice_tail_init(&pch->work_list, &pl330->desc_pool); | 2152 | list_splice_tail_init(&pch->work_list, &pl330->desc_pool); |
2152 | list_splice_tail_init(&pch->completed_list, &pl330->desc_pool); | 2153 | list_splice_tail_init(&pch->completed_list, &pl330->desc_pool); |
2153 | spin_unlock_irqrestore(&pch->lock, flags); | 2154 | spin_unlock_irqrestore(&pch->lock, flags); |
2155 | pm_runtime_mark_last_busy(pl330->ddma.dev); | ||
2156 | pm_runtime_put_autosuspend(pl330->ddma.dev); | ||
2154 | 2157 | ||
2155 | return 0; | 2158 | return 0; |
2156 | } | 2159 | } |