diff options
author | Arnd Bergmann <arnd@arndb.de> | 2017-07-21 12:17:45 -0400 |
---|---|---|
committer | Boris Ostrovsky <boris.ostrovsky@oracle.com> | 2017-08-31 09:45:55 -0400 |
commit | fefcfb9935be0208ff522563239f11a04f98c27d (patch) | |
tree | 13364815524f1c956b20c0f85453f14b142a2dbd | |
parent | a0e4fd14ba0b90b6fcea9c0f7f6de6886479427d (diff) |
xen/pvcalls: use WARN_ON(1) instead of __WARN()
__WARN() is an internal helper that is only available on
some architectures, but causes a build error e.g. on ARM64
in some configurations:
drivers/xen/pvcalls-back.c: In function 'set_backend_state':
drivers/xen/pvcalls-back.c:1097:5: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration]
Unfortunately, there is no equivalent of BUG() that takes no
arguments, but WARN_ON(1) is commonly used in other drivers
and works on all configurations.
Fixes: 7160378206b2 ("xen/pvcalls: xenbus state handling")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
-rw-r--r-- | drivers/xen/pvcalls-back.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index 3201a0c5dbcf..b209cd44bb8d 100644 --- a/drivers/xen/pvcalls-back.c +++ b/drivers/xen/pvcalls-back.c | |||
@@ -1098,7 +1098,7 @@ static void set_backend_state(struct xenbus_device *dev, | |||
1098 | xenbus_switch_state(dev, XenbusStateClosing); | 1098 | xenbus_switch_state(dev, XenbusStateClosing); |
1099 | break; | 1099 | break; |
1100 | default: | 1100 | default: |
1101 | __WARN(); | 1101 | WARN_ON(1); |
1102 | } | 1102 | } |
1103 | break; | 1103 | break; |
1104 | case XenbusStateInitWait: | 1104 | case XenbusStateInitWait: |
@@ -1113,7 +1113,7 @@ static void set_backend_state(struct xenbus_device *dev, | |||
1113 | xenbus_switch_state(dev, XenbusStateClosing); | 1113 | xenbus_switch_state(dev, XenbusStateClosing); |
1114 | break; | 1114 | break; |
1115 | default: | 1115 | default: |
1116 | __WARN(); | 1116 | WARN_ON(1); |
1117 | } | 1117 | } |
1118 | break; | 1118 | break; |
1119 | case XenbusStateConnected: | 1119 | case XenbusStateConnected: |
@@ -1127,7 +1127,7 @@ static void set_backend_state(struct xenbus_device *dev, | |||
1127 | xenbus_switch_state(dev, XenbusStateClosing); | 1127 | xenbus_switch_state(dev, XenbusStateClosing); |
1128 | break; | 1128 | break; |
1129 | default: | 1129 | default: |
1130 | __WARN(); | 1130 | WARN_ON(1); |
1131 | } | 1131 | } |
1132 | break; | 1132 | break; |
1133 | case XenbusStateClosing: | 1133 | case XenbusStateClosing: |
@@ -1138,11 +1138,11 @@ static void set_backend_state(struct xenbus_device *dev, | |||
1138 | xenbus_switch_state(dev, XenbusStateClosed); | 1138 | xenbus_switch_state(dev, XenbusStateClosed); |
1139 | break; | 1139 | break; |
1140 | default: | 1140 | default: |
1141 | __WARN(); | 1141 | WARN_ON(1); |
1142 | } | 1142 | } |
1143 | break; | 1143 | break; |
1144 | default: | 1144 | default: |
1145 | __WARN(); | 1145 | WARN_ON(1); |
1146 | } | 1146 | } |
1147 | } | 1147 | } |
1148 | } | 1148 | } |