aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDexuan Cui <decui@microsoft.com>2018-09-23 17:10:41 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-10-02 18:36:11 -0400
commitfe857bb40fb6788afe6b12b1df50b94e2d363c89 (patch)
treecf7cb6e587bbf20096d4c7921286c9c734e046e2
parenta007734618fee1bf35556c04fa498d41d42c7301 (diff)
Drivers: hv: vmbus: Fix the descriptions of some function parameters
No functional change. Added descriptions for some parameters. Fixed some typos. Removed some out-of-date comments. Signed-off-by: Dexuan Cui <decui@microsoft.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: linux-doc@vger.kernel.org Cc: K. Y. Srinivasan <kys@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Stephen Hemminger <sthemmin@microsoft.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/hv/channel.c24
-rw-r--r--drivers/hv/channel_mgmt.c23
2 files changed, 22 insertions, 25 deletions
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index ddadb7efd1cc..de8193f3b838 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -743,15 +743,16 @@ EXPORT_SYMBOL_GPL(vmbus_close);
743 743
744/** 744/**
745 * vmbus_sendpacket() - Send the specified buffer on the given channel 745 * vmbus_sendpacket() - Send the specified buffer on the given channel
746 * @channel: Pointer to vmbus_channel structure. 746 * @channel: Pointer to vmbus_channel structure
747 * @buffer: Pointer to the buffer you want to receive the data into. 747 * @buffer: Pointer to the buffer you want to send the data from.
748 * @bufferlen: Maximum size of what the the buffer will hold 748 * @bufferlen: Maximum size of what the buffer holds.
749 * @requestid: Identifier of the request 749 * @requestid: Identifier of the request
750 * @type: Type of packet that is being send e.g. negotiate, time 750 * @type: Type of packet that is being sent e.g. negotiate, time
751 * packet etc. 751 * packet etc.
752 * @flags: 0 or VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED
752 * 753 *
753 * Sends data in @buffer directly to hyper-v via the vmbus 754 * Sends data in @buffer directly to Hyper-V via the vmbus.
754 * This will send the data unparsed to hyper-v. 755 * This will send the data unparsed to Hyper-V.
755 * 756 *
756 * Mainly used by Hyper-V drivers. 757 * Mainly used by Hyper-V drivers.
757 */ 758 */
@@ -884,12 +885,13 @@ int vmbus_sendpacket_mpb_desc(struct vmbus_channel *channel,
884EXPORT_SYMBOL_GPL(vmbus_sendpacket_mpb_desc); 885EXPORT_SYMBOL_GPL(vmbus_sendpacket_mpb_desc);
885 886
886/** 887/**
887 * vmbus_recvpacket() - Retrieve the user packet on the specified channel 888 * __vmbus_recvpacket() - Retrieve the user packet on the specified channel
888 * @channel: Pointer to vmbus_channel structure. 889 * @channel: Pointer to vmbus_channel structure
889 * @buffer: Pointer to the buffer you want to receive the data into. 890 * @buffer: Pointer to the buffer you want to receive the data into.
890 * @bufferlen: Maximum size of what the the buffer will hold 891 * @bufferlen: Maximum size of what the buffer can hold.
891 * @buffer_actual_len: The actual size of the data after it was received 892 * @buffer_actual_len: The actual size of the data after it was received.
892 * @requestid: Identifier of the request 893 * @requestid: Identifier of the request
894 * @raw: true means keep the vmpacket_descriptor header in the received data.
893 * 895 *
894 * Receives directly from the hyper-v vmbus and puts the data it received 896 * Receives directly from the hyper-v vmbus and puts the data it received
895 * into Buffer. This will receive the data unparsed from hyper-v. 897 * into Buffer. This will receive the data unparsed from hyper-v.
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index b7c48ebdf6a1..6f3e6af5e891 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -198,24 +198,19 @@ static u16 hv_get_dev_type(const struct vmbus_channel *channel)
198} 198}
199 199
200/** 200/**
201 * vmbus_prep_negotiate_resp() - Create default response for Hyper-V Negotiate message 201 * vmbus_prep_negotiate_resp() - Create default response for Negotiate message
202 * @icmsghdrp: Pointer to msg header structure 202 * @icmsghdrp: Pointer to msg header structure
203 * @icmsg_negotiate: Pointer to negotiate message structure
204 * @buf: Raw buffer channel data 203 * @buf: Raw buffer channel data
204 * @fw_version: The framework versions we can support.
205 * @fw_vercnt: The size of @fw_version.
206 * @srv_version: The service versions we can support.
207 * @srv_vercnt: The size of @srv_version.
208 * @nego_fw_version: The selected framework version.
209 * @nego_srv_version: The selected service version.
205 * 210 *
206 * @icmsghdrp is of type &struct icmsg_hdr. 211 * Note: Versions are given in decreasing order.
207 * Set up and fill in default negotiate response message.
208 *
209 * The fw_version and fw_vercnt specifies the framework version that
210 * we can support.
211 *
212 * The srv_version and srv_vercnt specifies the service
213 * versions we can support.
214 *
215 * Versions are given in decreasing order.
216 *
217 * nego_fw_version and nego_srv_version store the selected protocol versions.
218 * 212 *
213 * Set up and fill in default negotiate response message.
219 * Mainly used by Hyper-V drivers. 214 * Mainly used by Hyper-V drivers.
220 */ 215 */
221bool vmbus_prep_negotiate_resp(struct icmsg_hdr *icmsghdrp, 216bool vmbus_prep_negotiate_resp(struct icmsg_hdr *icmsghdrp,