diff options
author | Maciej W. Rozycki <macro@linux-mips.org> | 2018-10-02 09:23:45 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-10-02 14:31:54 -0400 |
commit | fe3a83af6a50199bf250fa331e94216912f79395 (patch) | |
tree | d5f7e5231f2a98d1f484bce833ca50e3ce1f9300 | |
parent | 657ade07df72847f591ccdb36bd9b91ed0edbac3 (diff) |
declance: Fix continuation with the adapter identification message
Fix a commit 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing
continuation lines") regression with the `declance' driver, which caused
the adapter identification message to be split between two lines, e.g.:
declance.c: v0.011 by Linux MIPS DECstation task force
tc6: PMAD-AA
, addr = 08:00:2b:1b:2a:6a, irq = 14
tc6: registered as eth0.
Address that properly, by printing identification with a single call,
making the messages now look like:
declance.c: v0.011 by Linux MIPS DECstation task force
tc6: PMAD-AA, addr = 08:00:2b:1b:2a:6a, irq = 14
tc6: registered as eth0.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Fixes: 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/amd/declance.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c index 116997a8b593..00332a1ea84b 100644 --- a/drivers/net/ethernet/amd/declance.c +++ b/drivers/net/ethernet/amd/declance.c | |||
@@ -1031,6 +1031,7 @@ static int dec_lance_probe(struct device *bdev, const int type) | |||
1031 | int i, ret; | 1031 | int i, ret; |
1032 | unsigned long esar_base; | 1032 | unsigned long esar_base; |
1033 | unsigned char *esar; | 1033 | unsigned char *esar; |
1034 | const char *desc; | ||
1034 | 1035 | ||
1035 | if (dec_lance_debug && version_printed++ == 0) | 1036 | if (dec_lance_debug && version_printed++ == 0) |
1036 | printk(version); | 1037 | printk(version); |
@@ -1216,19 +1217,20 @@ static int dec_lance_probe(struct device *bdev, const int type) | |||
1216 | */ | 1217 | */ |
1217 | switch (type) { | 1218 | switch (type) { |
1218 | case ASIC_LANCE: | 1219 | case ASIC_LANCE: |
1219 | printk("%s: IOASIC onboard LANCE", name); | 1220 | desc = "IOASIC onboard LANCE"; |
1220 | break; | 1221 | break; |
1221 | case PMAD_LANCE: | 1222 | case PMAD_LANCE: |
1222 | printk("%s: PMAD-AA", name); | 1223 | desc = "PMAD-AA"; |
1223 | break; | 1224 | break; |
1224 | case PMAX_LANCE: | 1225 | case PMAX_LANCE: |
1225 | printk("%s: PMAX onboard LANCE", name); | 1226 | desc = "PMAX onboard LANCE"; |
1226 | break; | 1227 | break; |
1227 | } | 1228 | } |
1228 | for (i = 0; i < 6; i++) | 1229 | for (i = 0; i < 6; i++) |
1229 | dev->dev_addr[i] = esar[i * 4]; | 1230 | dev->dev_addr[i] = esar[i * 4]; |
1230 | 1231 | ||
1231 | printk(", addr = %pM, irq = %d\n", dev->dev_addr, dev->irq); | 1232 | printk("%s: %s, addr = %pM, irq = %d\n", |
1233 | name, desc, dev->dev_addr, dev->irq); | ||
1232 | 1234 | ||
1233 | dev->netdev_ops = &lance_netdev_ops; | 1235 | dev->netdev_ops = &lance_netdev_ops; |
1234 | dev->watchdog_timeo = 5*HZ; | 1236 | dev->watchdog_timeo = 5*HZ; |