aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Airlie <airlied@redhat.com>2019-04-04 23:17:14 -0400
committerDave Airlie <airlied@redhat.com>2019-04-23 23:45:48 -0400
commitfd96e0dba19c53c2d66f2a398716bb74df8ca85e (patch)
tree2349213182c26d0a77c31027ab19a49f7e615c8b
parent331ca3a3d6a75f9e88b3545a4815502dfce308d4 (diff)
drm/udl: introduce a macro to convert dev to udl.
This just makes it easier to later embed drm into udl. Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190405031715.5959-3-airlied@gmail.com
-rw-r--r--drivers/gpu/drm/udl/udl_drv.h2
-rw-r--r--drivers/gpu/drm/udl/udl_fb.c10
-rw-r--r--drivers/gpu/drm/udl/udl_gem.c2
-rw-r--r--drivers/gpu/drm/udl/udl_main.c12
4 files changed, 14 insertions, 12 deletions
diff --git a/drivers/gpu/drm/udl/udl_drv.h b/drivers/gpu/drm/udl/udl_drv.h
index 4ae67d882eae..b3e08e876d62 100644
--- a/drivers/gpu/drm/udl/udl_drv.h
+++ b/drivers/gpu/drm/udl/udl_drv.h
@@ -71,6 +71,8 @@ struct udl_device {
71 atomic_t cpu_kcycles_used; /* transpired during pixel processing */ 71 atomic_t cpu_kcycles_used; /* transpired during pixel processing */
72}; 72};
73 73
74#define to_udl(x) ((x)->dev_private)
75
74struct udl_gem_object { 76struct udl_gem_object {
75 struct drm_gem_object base; 77 struct drm_gem_object base;
76 struct page **pages; 78 struct page **pages;
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index f8ff5a6f559e..16593d4f02b4 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu/drm/udl/udl_fb.c
@@ -82,7 +82,7 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y,
82 int width, int height) 82 int width, int height)
83{ 83{
84 struct drm_device *dev = fb->base.dev; 84 struct drm_device *dev = fb->base.dev;
85 struct udl_device *udl = dev->dev_private; 85 struct udl_device *udl = to_udl(dev);
86 int i, ret; 86 int i, ret;
87 char *cmd; 87 char *cmd;
88 cycles_t start_cycles, end_cycles; 88 cycles_t start_cycles, end_cycles;
@@ -210,7 +210,7 @@ static int udl_fb_open(struct fb_info *info, int user)
210{ 210{
211 struct udl_fbdev *ufbdev = info->par; 211 struct udl_fbdev *ufbdev = info->par;
212 struct drm_device *dev = ufbdev->ufb.base.dev; 212 struct drm_device *dev = ufbdev->ufb.base.dev;
213 struct udl_device *udl = dev->dev_private; 213 struct udl_device *udl = to_udl(dev);
214 214
215 /* If the USB device is gone, we don't accept new opens */ 215 /* If the USB device is gone, we don't accept new opens */
216 if (drm_dev_is_unplugged(udl->ddev)) 216 if (drm_dev_is_unplugged(udl->ddev))
@@ -437,7 +437,7 @@ static void udl_fbdev_destroy(struct drm_device *dev,
437 437
438int udl_fbdev_init(struct drm_device *dev) 438int udl_fbdev_init(struct drm_device *dev)
439{ 439{
440 struct udl_device *udl = dev->dev_private; 440 struct udl_device *udl = to_udl(dev);
441 int bpp_sel = fb_bpp; 441 int bpp_sel = fb_bpp;
442 struct udl_fbdev *ufbdev; 442 struct udl_fbdev *ufbdev;
443 int ret; 443 int ret;
@@ -476,7 +476,7 @@ free:
476 476
477void udl_fbdev_cleanup(struct drm_device *dev) 477void udl_fbdev_cleanup(struct drm_device *dev)
478{ 478{
479 struct udl_device *udl = dev->dev_private; 479 struct udl_device *udl = to_udl(dev);
480 if (!udl->fbdev) 480 if (!udl->fbdev)
481 return; 481 return;
482 482
@@ -487,7 +487,7 @@ void udl_fbdev_cleanup(struct drm_device *dev)
487 487
488void udl_fbdev_unplug(struct drm_device *dev) 488void udl_fbdev_unplug(struct drm_device *dev)
489{ 489{
490 struct udl_device *udl = dev->dev_private; 490 struct udl_device *udl = to_udl(dev);
491 struct udl_fbdev *ufbdev; 491 struct udl_fbdev *ufbdev;
492 if (!udl->fbdev) 492 if (!udl->fbdev)
493 return; 493 return;
diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
index bb7b58407039..3b3e17652bb2 100644
--- a/drivers/gpu/drm/udl/udl_gem.c
+++ b/drivers/gpu/drm/udl/udl_gem.c
@@ -203,7 +203,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
203{ 203{
204 struct udl_gem_object *gobj; 204 struct udl_gem_object *gobj;
205 struct drm_gem_object *obj; 205 struct drm_gem_object *obj;
206 struct udl_device *udl = dev->dev_private; 206 struct udl_device *udl = to_udl(dev);
207 int ret = 0; 207 int ret = 0;
208 208
209 mutex_lock(&udl->gem_lock); 209 mutex_lock(&udl->gem_lock);
diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
index 1f8ef34ade24..862c099d7c4c 100644
--- a/drivers/gpu/drm/udl/udl_main.c
+++ b/drivers/gpu/drm/udl/udl_main.c
@@ -30,7 +30,7 @@
30static int udl_parse_vendor_descriptor(struct drm_device *dev, 30static int udl_parse_vendor_descriptor(struct drm_device *dev,
31 struct usb_device *usbdev) 31 struct usb_device *usbdev)
32{ 32{
33 struct udl_device *udl = dev->dev_private; 33 struct udl_device *udl = to_udl(dev);
34 char *desc; 34 char *desc;
35 char *buf; 35 char *buf;
36 char *desc_end; 36 char *desc_end;
@@ -166,7 +166,7 @@ void udl_urb_completion(struct urb *urb)
166 166
167static void udl_free_urb_list(struct drm_device *dev) 167static void udl_free_urb_list(struct drm_device *dev)
168{ 168{
169 struct udl_device *udl = dev->dev_private; 169 struct udl_device *udl = to_udl(dev);
170 int count = udl->urbs.count; 170 int count = udl->urbs.count;
171 struct list_head *node; 171 struct list_head *node;
172 struct urb_node *unode; 172 struct urb_node *unode;
@@ -199,7 +199,7 @@ static void udl_free_urb_list(struct drm_device *dev)
199 199
200static int udl_alloc_urb_list(struct drm_device *dev, int count, size_t size) 200static int udl_alloc_urb_list(struct drm_device *dev, int count, size_t size)
201{ 201{
202 struct udl_device *udl = dev->dev_private; 202 struct udl_device *udl = to_udl(dev);
203 struct urb *urb; 203 struct urb *urb;
204 struct urb_node *unode; 204 struct urb_node *unode;
205 char *buf; 205 char *buf;
@@ -263,7 +263,7 @@ retry:
263 263
264struct urb *udl_get_urb(struct drm_device *dev) 264struct urb *udl_get_urb(struct drm_device *dev)
265{ 265{
266 struct udl_device *udl = dev->dev_private; 266 struct udl_device *udl = to_udl(dev);
267 int ret = 0; 267 int ret = 0;
268 struct list_head *entry; 268 struct list_head *entry;
269 struct urb_node *unode; 269 struct urb_node *unode;
@@ -296,7 +296,7 @@ error:
296 296
297int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len) 297int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len)
298{ 298{
299 struct udl_device *udl = dev->dev_private; 299 struct udl_device *udl = to_udl(dev);
300 int ret; 300 int ret;
301 301
302 BUG_ON(len > udl->urbs.size); 302 BUG_ON(len > udl->urbs.size);
@@ -371,7 +371,7 @@ int udl_drop_usb(struct drm_device *dev)
371 371
372void udl_driver_unload(struct drm_device *dev) 372void udl_driver_unload(struct drm_device *dev)
373{ 373{
374 struct udl_device *udl = dev->dev_private; 374 struct udl_device *udl = to_udl(dev);
375 375
376 drm_kms_helper_poll_fini(dev); 376 drm_kms_helper_poll_fini(dev);
377 377