Merge tag 'linux-can-fixes-for-4.15-20171208' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can

Marc Kleine-Budde says:

====================
pull-request: can 2017-12-08

this is a pull request of 6 patches for net/master.

Martin Kelly provides 5 patches for various USB based CAN drivers, that
properly cancel the URBs on adapter unplug, so that the driver doesn't
end up in an endless loop. Stephane Grosjean provides a patch to restart
the tx queue if zero length packages are transmitted.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>

6 files changed, 12 insertions, 6 deletions

diff --git a/drivers/net/can/peak_canfd/peak_canfd.c b/drivers/net/can/peak_canfd/peak_canfd.c
index 85268be0c913..55513411a82e 100644
--- a/drivers/net/can/peak_canfd/peak_canfd.c
+++ b/drivers/net/can/peak_canfd/peak_canfd.c
@@ -258,21 +258,18 @@ static int pucan_handle_can_rx(struct peak_canfd_priv *priv,
         /* if this frame is an echo, */
         if ((rx_msg_flags & PUCAN_MSG_LOOPED_BACK) &&
             !(rx_msg_flags & PUCAN_MSG_SELF_RECEIVE)) {
-                int n;
                 unsigned long flags;
 
                 spin_lock_irqsave(&priv->echo_lock, flags);
-                n = can_get_echo_skb(priv->ndev, msg->client);
+                can_get_echo_skb(priv->ndev, msg->client);
                 spin_unlock_irqrestore(&priv->echo_lock, flags);
 
                 /* count bytes of the echo instead of skb */
                 stats->tx_bytes += cf_len;
                 stats->tx_packets++;
 
-                if (n) {
-                        /* restart tx queue only if a slot is free */
-                        netif_wake_queue(priv->ndev);
-                }
+                /* restart tx queue (a slot is free) */
+                netif_wake_queue(priv->ndev);
 
                 return 0;
         }
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index b3d02759c226..b00358297424 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -288,6 +288,8 @@ static void ems_usb_read_interrupt_callback(struct urb *urb)
 
         case -ECONNRESET: /* unlink */
         case -ENOENT:
+        case -EPIPE:
+        case -EPROTO:
         case -ESHUTDOWN:
                 return;
 
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index 9fdb0f0bfa06..c6dcf93675c0 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -393,6 +393,8 @@ static void esd_usb2_read_bulk_callback(struct urb *urb)
                 break;
 
         case -ENOENT:
+        case -EPIPE:
+        case -EPROTO:
         case -ESHUTDOWN:
                 return;
 
diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c
index f95945915d20..63587b8e6825 100644
--- a/drivers/net/can/usb/kvaser_usb.c
+++ b/drivers/net/can/usb/kvaser_usb.c
@@ -1326,6 +1326,8 @@ static void kvaser_usb_read_bulk_callback(struct urb *urb)
         case 0:
                 break;
         case -ENOENT:
+        case -EPIPE:
+        case -EPROTO:
         case -ESHUTDOWN:
                 return;
         default:
diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
index ef417dcddbf7..8d8c2086424d 100644
--- a/drivers/net/can/usb/mcba_usb.c
+++ b/drivers/net/can/usb/mcba_usb.c
@@ -593,6 +593,7 @@ static void mcba_usb_read_bulk_callback(struct urb *urb)
 
         case -ENOENT:
         case -EPIPE:
+        case -EPROTO:
         case -ESHUTDOWN:
                 return;
 
diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c
index d000cb62d6ae..27861c417c94 100644
--- a/drivers/net/can/usb/usb_8dev.c
+++ b/drivers/net/can/usb/usb_8dev.c
@@ -524,6 +524,8 @@ static void usb_8dev_read_bulk_callback(struct urb *urb)
                 break;
 
         case -ENOENT:
+        case -EPIPE:
+        case -EPROTO:
         case -ESHUTDOWN:
                 return;