aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-07-19 20:37:13 -0400
committerDave Chinner <david@fromorbit.com>2016-07-19 20:37:13 -0400
commitfbc21f33cda0a8e13ebd71fe2e23a21d4b79afbb (patch)
tree10c37d3ce264a198fc9f42449f2ce49c5280db92
parent7f1b62457b58f9bb586a1b2ff7fe271b56196bd2 (diff)
xfs: don't allow negative error tags
Errors go from zero which means no error to XFS_ERRTAG_MAX (22). My static checker complains that xfs_errortag_add() puts an upper bound on this but not a lower bound. Let's fix it by making it unsigned. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
-rw-r--r--fs/xfs/xfs_error.c2
-rw-r--r--fs/xfs/xfs_error.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
index 88693a98fac5..acd941314a4b 100644
--- a/fs/xfs/xfs_error.c
+++ b/fs/xfs/xfs_error.c
@@ -55,7 +55,7 @@ xfs_error_test(int error_tag, int *fsidp, char *expression,
55} 55}
56 56
57int 57int
58xfs_errortag_add(int error_tag, xfs_mount_t *mp) 58xfs_errortag_add(unsigned int error_tag, xfs_mount_t *mp)
59{ 59{
60 int i; 60 int i;
61 int len; 61 int len;
diff --git a/fs/xfs/xfs_error.h b/fs/xfs/xfs_error.h
index 4ed3042a0f16..2e4f67f68856 100644
--- a/fs/xfs/xfs_error.h
+++ b/fs/xfs/xfs_error.h
@@ -128,7 +128,7 @@ extern int xfs_error_test(int, int *, char *, int, char *, unsigned long);
128 xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \ 128 xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \
129 (rf)))) 129 (rf))))
130 130
131extern int xfs_errortag_add(int error_tag, struct xfs_mount *mp); 131extern int xfs_errortag_add(unsigned int error_tag, struct xfs_mount *mp);
132extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud); 132extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud);
133#else 133#else
134#define XFS_TEST_ERROR(expr, mp, tag, rf) (expr) 134#define XFS_TEST_ERROR(expr, mp, tag, rf) (expr)