diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2015-02-02 16:55:53 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2015-02-03 07:05:04 -0500 |
commit | fad06016433bb1e890ce7d170079351099518489 (patch) | |
tree | 35064daf11b2020c9e11fe62635573c567b9f034 | |
parent | 214f1aff3f33bc86cc85ece4080d9518af688fb1 (diff) |
sata_mv: Delete unnecessary checks before the function call "phy_power_off"
The phy_power_off() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r-- | drivers/ata/sata_mv.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index f9a0e34eb111..f8c33e3772b8 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c | |||
@@ -4185,8 +4185,7 @@ err: | |||
4185 | clk_disable_unprepare(hpriv->port_clks[port]); | 4185 | clk_disable_unprepare(hpriv->port_clks[port]); |
4186 | clk_put(hpriv->port_clks[port]); | 4186 | clk_put(hpriv->port_clks[port]); |
4187 | } | 4187 | } |
4188 | if (hpriv->port_phys[port]) | 4188 | phy_power_off(hpriv->port_phys[port]); |
4189 | phy_power_off(hpriv->port_phys[port]); | ||
4190 | } | 4189 | } |
4191 | 4190 | ||
4192 | return rc; | 4191 | return rc; |
@@ -4216,8 +4215,7 @@ static int mv_platform_remove(struct platform_device *pdev) | |||
4216 | clk_disable_unprepare(hpriv->port_clks[port]); | 4215 | clk_disable_unprepare(hpriv->port_clks[port]); |
4217 | clk_put(hpriv->port_clks[port]); | 4216 | clk_put(hpriv->port_clks[port]); |
4218 | } | 4217 | } |
4219 | if (hpriv->port_phys[port]) | 4218 | phy_power_off(hpriv->port_phys[port]); |
4220 | phy_power_off(hpriv->port_phys[port]); | ||
4221 | } | 4219 | } |
4222 | return 0; | 4220 | return 0; |
4223 | } | 4221 | } |