diff options
author | Mariusz Skamra <mariuszx.skamra@intel.com> | 2017-05-26 06:15:59 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-06-03 05:08:04 -0400 |
commit | fa72e6afa795dbb35d0cc6332606e83e4415e45e (patch) | |
tree | 53092ad9c42474e38982c96adb4b12b2abe5a26a | |
parent | bab3548078237706f53baafe43ae58257225549d (diff) |
usb: Make use of ktime_* comparison functions
Start using ktime_* compare functions to make the code backportable.
Now that may be a bit tricky due to recent change of ktime_t.
Signed-off-by: Mariusz Skamra <mariuszx.skamra@intel.com>
Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/usb/chipidea/otg_fsm.c | 8 | ||||
-rw-r--r-- | drivers/usb/host/ehci-timer.c | 2 | ||||
-rw-r--r-- | drivers/usb/host/fotg210-hcd.c | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/chipidea/otg_fsm.c index 93e24ce61a3a..949183ede16f 100644 --- a/drivers/usb/chipidea/otg_fsm.c +++ b/drivers/usb/chipidea/otg_fsm.c | |||
@@ -234,7 +234,7 @@ static void ci_otg_add_timer(struct ci_hdrc *ci, enum otg_fsm_timer t) | |||
234 | ktime_set(timer_sec, timer_nsec)); | 234 | ktime_set(timer_sec, timer_nsec)); |
235 | ci->enabled_otg_timer_bits |= (1 << t); | 235 | ci->enabled_otg_timer_bits |= (1 << t); |
236 | if ((ci->next_otg_timer == NUM_OTG_FSM_TIMERS) || | 236 | if ((ci->next_otg_timer == NUM_OTG_FSM_TIMERS) || |
237 | (ci->hr_timeouts[ci->next_otg_timer] > | 237 | ktime_after(ci->hr_timeouts[ci->next_otg_timer], |
238 | ci->hr_timeouts[t])) { | 238 | ci->hr_timeouts[t])) { |
239 | ci->next_otg_timer = t; | 239 | ci->next_otg_timer = t; |
240 | hrtimer_start_range_ns(&ci->otg_fsm_hrtimer, | 240 | hrtimer_start_range_ns(&ci->otg_fsm_hrtimer, |
@@ -269,7 +269,7 @@ static void ci_otg_del_timer(struct ci_hdrc *ci, enum otg_fsm_timer t) | |||
269 | for_each_set_bit(cur_timer, &enabled_timer_bits, | 269 | for_each_set_bit(cur_timer, &enabled_timer_bits, |
270 | NUM_OTG_FSM_TIMERS) { | 270 | NUM_OTG_FSM_TIMERS) { |
271 | if ((next_timer == NUM_OTG_FSM_TIMERS) || | 271 | if ((next_timer == NUM_OTG_FSM_TIMERS) || |
272 | (ci->hr_timeouts[next_timer] < | 272 | ktime_before(ci->hr_timeouts[next_timer], |
273 | ci->hr_timeouts[cur_timer])) | 273 | ci->hr_timeouts[cur_timer])) |
274 | next_timer = cur_timer; | 274 | next_timer = cur_timer; |
275 | } | 275 | } |
@@ -397,13 +397,13 @@ static enum hrtimer_restart ci_otg_hrtimer_func(struct hrtimer *t) | |||
397 | 397 | ||
398 | now = ktime_get(); | 398 | now = ktime_get(); |
399 | for_each_set_bit(cur_timer, &enabled_timer_bits, NUM_OTG_FSM_TIMERS) { | 399 | for_each_set_bit(cur_timer, &enabled_timer_bits, NUM_OTG_FSM_TIMERS) { |
400 | if (now >= ci->hr_timeouts[cur_timer]) { | 400 | if (ktime_compare(now, ci->hr_timeouts[cur_timer]) >= 0) { |
401 | ci->enabled_otg_timer_bits &= ~(1 << cur_timer); | 401 | ci->enabled_otg_timer_bits &= ~(1 << cur_timer); |
402 | if (otg_timer_handlers[cur_timer]) | 402 | if (otg_timer_handlers[cur_timer]) |
403 | ret = otg_timer_handlers[cur_timer](ci); | 403 | ret = otg_timer_handlers[cur_timer](ci); |
404 | } else { | 404 | } else { |
405 | if ((next_timer == NUM_OTG_FSM_TIMERS) || | 405 | if ((next_timer == NUM_OTG_FSM_TIMERS) || |
406 | (ci->hr_timeouts[cur_timer] < | 406 | ktime_before(ci->hr_timeouts[cur_timer], |
407 | ci->hr_timeouts[next_timer])) | 407 | ci->hr_timeouts[next_timer])) |
408 | next_timer = cur_timer; | 408 | next_timer = cur_timer; |
409 | } | 409 | } |
diff --git a/drivers/usb/host/ehci-timer.c b/drivers/usb/host/ehci-timer.c index 3893b5bafd87..0b6cdb723192 100644 --- a/drivers/usb/host/ehci-timer.c +++ b/drivers/usb/host/ehci-timer.c | |||
@@ -424,7 +424,7 @@ static enum hrtimer_restart ehci_hrtimer_func(struct hrtimer *t) | |||
424 | */ | 424 | */ |
425 | now = ktime_get(); | 425 | now = ktime_get(); |
426 | for_each_set_bit(e, &events, EHCI_HRTIMER_NUM_EVENTS) { | 426 | for_each_set_bit(e, &events, EHCI_HRTIMER_NUM_EVENTS) { |
427 | if (now >= ehci->hr_timeouts[e]) | 427 | if (ktime_compare(now, ehci->hr_timeouts[e]) >= 0) |
428 | event_handlers[e](ehci); | 428 | event_handlers[e](ehci); |
429 | else | 429 | else |
430 | ehci_enable_event(ehci, e, false); | 430 | ehci_enable_event(ehci, e, false); |
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index ced08dc229ad..457cc6525abd 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c | |||
@@ -1380,7 +1380,7 @@ static enum hrtimer_restart fotg210_hrtimer_func(struct hrtimer *t) | |||
1380 | */ | 1380 | */ |
1381 | now = ktime_get(); | 1381 | now = ktime_get(); |
1382 | for_each_set_bit(e, &events, FOTG210_HRTIMER_NUM_EVENTS) { | 1382 | for_each_set_bit(e, &events, FOTG210_HRTIMER_NUM_EVENTS) { |
1383 | if (now >= fotg210->hr_timeouts[e]) | 1383 | if (ktime_compare(now, fotg210->hr_timeouts[e]) >= 0) |
1384 | event_handlers[e](fotg210); | 1384 | event_handlers[e](fotg210); |
1385 | else | 1385 | else |
1386 | fotg210_enable_event(fotg210, e, false); | 1386 | fotg210_enable_event(fotg210, e, false); |