aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2019-01-09 07:15:23 -0500
committerJan Kara <jack@suse.cz>2019-02-18 06:41:16 -0500
commitf7db89accc9c51d8f765d79b8e9557cc623ec20e (patch)
tree1336c33ed4134be538d6d5b9ef1be634a6ae3cf1
parent8c5544666c9d88046bfd60aa7d5fea5c6d3d59bd (diff)
fsnotify: Create function to remove event from notification list
Create function to remove event from the notification list. Later it will be used from more places. Reviewed-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r--fs/notify/notification.c20
-rw-r--r--include/linux/fsnotify_backend.h3
2 files changed, 16 insertions, 7 deletions
diff --git a/fs/notify/notification.c b/fs/notify/notification.c
index 027d5d5bb90e..5f3a54d444b5 100644
--- a/fs/notify/notification.c
+++ b/fs/notify/notification.c
@@ -141,6 +141,18 @@ queue:
141 return ret; 141 return ret;
142} 142}
143 143
144void fsnotify_remove_queued_event(struct fsnotify_group *group,
145 struct fsnotify_event *event)
146{
147 assert_spin_locked(&group->notification_lock);
148 /*
149 * We need to init list head for the case of overflow event so that
150 * check in fsnotify_add_event() works
151 */
152 list_del_init(&event->list);
153 group->q_len--;
154}
155
144/* 156/*
145 * Remove and return the first event from the notification list. It is the 157 * Remove and return the first event from the notification list. It is the
146 * responsibility of the caller to destroy the obtained event 158 * responsibility of the caller to destroy the obtained event
@@ -155,13 +167,7 @@ struct fsnotify_event *fsnotify_remove_first_event(struct fsnotify_group *group)
155 167
156 event = list_first_entry(&group->notification_list, 168 event = list_first_entry(&group->notification_list,
157 struct fsnotify_event, list); 169 struct fsnotify_event, list);
158 /* 170 fsnotify_remove_queued_event(group, event);
159 * We need to init list head for the case of overflow event so that
160 * check in fsnotify_add_event() works
161 */
162 list_del_init(&event->list);
163 group->q_len--;
164
165 return event; 171 return event;
166} 172}
167 173
diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
index 7b93f15b4944..dfc28fcb4de8 100644
--- a/include/linux/fsnotify_backend.h
+++ b/include/linux/fsnotify_backend.h
@@ -422,6 +422,9 @@ extern bool fsnotify_notify_queue_is_empty(struct fsnotify_group *group);
422extern struct fsnotify_event *fsnotify_peek_first_event(struct fsnotify_group *group); 422extern struct fsnotify_event *fsnotify_peek_first_event(struct fsnotify_group *group);
423/* return AND dequeue the first event on the notification queue */ 423/* return AND dequeue the first event on the notification queue */
424extern struct fsnotify_event *fsnotify_remove_first_event(struct fsnotify_group *group); 424extern struct fsnotify_event *fsnotify_remove_first_event(struct fsnotify_group *group);
425/* Remove event queued in the notification list */
426extern void fsnotify_remove_queued_event(struct fsnotify_group *group,
427 struct fsnotify_event *event);
425 428
426/* functions used to manipulate the marks attached to inodes */ 429/* functions used to manipulate the marks attached to inodes */
427 430