diff options
| author | Arseny Maslennikov <ar@cs.msu.ru> | 2019-03-09 10:43:06 -0500 |
|---|---|---|
| committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-03-16 23:56:23 -0400 |
| commit | f6d9db6355227656108cb93dd8c74d9a9904c5fb (patch) | |
| tree | 82c6300dcadeb4a6aecfcc93e2107b3082ff180c | |
| parent | da9cfb87a44da61f2403c4312916befcb6b6d7e8 (diff) | |
kbuild: deb-pkg: avoid implicit effects
* The man page for dpkg-source(1) notes:
> -b, --build directory [format-specific-parameters]
> Build a source package (--build since dpkg 1.17.14).
> <...>
>
> dpkg-source will build the source package with the first
> format found in this ordered list: the format indicated
> with the --format command line option, the format
> indicated in debian/source/format, “1.0”. The fallback
> to “1.0” is deprecated and will be removed at some point
> in the future, you should always document the desired
> source format in debian/source/format. See section
> SOURCE PACKAGE FORMATS for an extensive description of
> the various source package formats.
Thus it would be more foolproof to explicitly use 1.0 (as we always
did) than to rely on dpkg-source's defaults.
* In a similar vein, debian/rules is not made executable by mkdebian,
and dpkg-source warns about that but still silently fixes the file.
Let's be explicit once again.
Signed-off-by: Arseny Maslennikov <ar@cs.msu.ru>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
| -rwxr-xr-x | scripts/package/mkdebian | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian index 8068328a079c..8351584cb24e 100755 --- a/scripts/package/mkdebian +++ b/scripts/package/mkdebian | |||
| @@ -132,7 +132,9 @@ else | |||
| 132 | echo >&2 "Install lsb-release or set \$KDEB_CHANGELOG_DIST explicitly" | 132 | echo >&2 "Install lsb-release or set \$KDEB_CHANGELOG_DIST explicitly" |
| 133 | fi | 133 | fi |
| 134 | 134 | ||
| 135 | mkdir -p debian/ | 135 | mkdir -p debian/source/ |
| 136 | echo "1.0" > debian/source/format | ||
| 137 | |||
| 136 | echo $debarch > debian/arch | 138 | echo $debarch > debian/arch |
| 137 | extra_build_depends=", $(if_enabled_echo CONFIG_UNWINDER_ORC libelf-dev)" | 139 | extra_build_depends=", $(if_enabled_echo CONFIG_UNWINDER_ORC libelf-dev)" |
| 138 | extra_build_depends="$extra_build_depends, $(if_enabled_echo CONFIG_SYSTEM_TRUSTED_KEYRING libssl-dev:native)" | 140 | extra_build_depends="$extra_build_depends, $(if_enabled_echo CONFIG_SYSTEM_TRUSTED_KEYRING libssl-dev:native)" |
| @@ -223,5 +225,6 @@ clean: | |||
| 223 | 225 | ||
| 224 | binary: binary-arch | 226 | binary: binary-arch |
| 225 | EOF | 227 | EOF |
| 228 | chmod +x debian/rules | ||
| 226 | 229 | ||
| 227 | exit 0 | 230 | exit 0 |
