diff options
author | Maxim Patlasov <MPatlasov@parallels.com> | 2014-07-30 19:08:21 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-07-30 20:16:13 -0400 |
commit | f6789593d5cea42a4ecb1cbeab6a23ade5ebbba7 (patch) | |
tree | e9f7837a54e53106f2f76dde8fdd8e22def0258f | |
parent | 26bcd8b72563b4c54892c4c2a409f6656fb8ae8b (diff) |
mm/page-writeback.c: fix divide by zero in bdi_dirty_limits()
Under memory pressure, it is possible for dirty_thresh, calculated by
global_dirty_limits() in balance_dirty_pages(), to equal zero. Then, if
strictlimit is true, bdi_dirty_limits() tries to resolve the proportion:
bdi_bg_thresh : bdi_thresh = background_thresh : dirty_thresh
by dividing by zero.
Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com>
Acked-by: Rik van Riel <riel@redhat.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | mm/page-writeback.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 518e2c3f4c75..e0c943014eb7 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c | |||
@@ -1306,9 +1306,9 @@ static inline void bdi_dirty_limits(struct backing_dev_info *bdi, | |||
1306 | *bdi_thresh = bdi_dirty_limit(bdi, dirty_thresh); | 1306 | *bdi_thresh = bdi_dirty_limit(bdi, dirty_thresh); |
1307 | 1307 | ||
1308 | if (bdi_bg_thresh) | 1308 | if (bdi_bg_thresh) |
1309 | *bdi_bg_thresh = div_u64((u64)*bdi_thresh * | 1309 | *bdi_bg_thresh = dirty_thresh ? div_u64((u64)*bdi_thresh * |
1310 | background_thresh, | 1310 | background_thresh, |
1311 | dirty_thresh); | 1311 | dirty_thresh) : 0; |
1312 | 1312 | ||
1313 | /* | 1313 | /* |
1314 | * In order to avoid the stacked BDI deadlock we need | 1314 | * In order to avoid the stacked BDI deadlock we need |