diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2016-06-13 20:26:49 -0400 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2016-06-15 14:26:41 -0400 |
| commit | f52a4c74efbb61195490535e9d65d964c4ebfee3 (patch) | |
| tree | c10ce11ac682d4f76858c3b1a4f95070adc82682 | |
| parent | db06d759d6cf903aeda8c107fd3abd366dd80200 (diff) | |
ata: fix return value check in ahci_seattle_get_port_info()
In case of error, the function devm_kzalloc() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Brijesh Singh <brijesh.singh@amd.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
| -rw-r--r-- | drivers/ata/ahci_seattle.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/ahci_seattle.c b/drivers/ata/ahci_seattle.c index 6e702ab57220..1d31c0c0fc20 100644 --- a/drivers/ata/ahci_seattle.c +++ b/drivers/ata/ahci_seattle.c | |||
| @@ -137,7 +137,7 @@ static const struct ata_port_info *ahci_seattle_get_port_info( | |||
| 137 | u32 val; | 137 | u32 val; |
| 138 | 138 | ||
| 139 | plat_data = devm_kzalloc(dev, sizeof(*plat_data), GFP_KERNEL); | 139 | plat_data = devm_kzalloc(dev, sizeof(*plat_data), GFP_KERNEL); |
| 140 | if (IS_ERR(plat_data)) | 140 | if (!plat_data) |
| 141 | return &ahci_port_info; | 141 | return &ahci_port_info; |
| 142 | 142 | ||
| 143 | plat_data->sgpio_ctrl = devm_ioremap_resource(dev, | 143 | plat_data->sgpio_ctrl = devm_ioremap_resource(dev, |