diff options
author | Tejun Heo <tj@kernel.org> | 2015-06-24 19:58:21 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-06-24 20:49:45 -0400 |
commit | f4b90b70b7a4f5c29c442399ffd531332356e1f5 (patch) | |
tree | 30a0b611127c4219bd57622e1d6f32600492459e | |
parent | d1dc6f1bcf1e998e7ce65fc120da371ab047a999 (diff) |
memcg: remove unused mem_cgroup->oom_wakeups
Since commit 4942642080ea ("mm: memcg: handle non-error OOM situations
more gracefully"), nobody uses mem_cgroup->oom_wakeups. Remove it.
While at it, also fold memcg_wakeup_oom() into memcg_oom_recover() which
is its only user. This cleanup was suggested by Michal.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Michal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | mm/memcontrol.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 8da44a083397..6a5f5d59f7d7 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c | |||
@@ -287,7 +287,6 @@ struct mem_cgroup { | |||
287 | 287 | ||
288 | bool oom_lock; | 288 | bool oom_lock; |
289 | atomic_t under_oom; | 289 | atomic_t under_oom; |
290 | atomic_t oom_wakeups; | ||
291 | 290 | ||
292 | int swappiness; | 291 | int swappiness; |
293 | /* OOM-Killer disable */ | 292 | /* OOM-Killer disable */ |
@@ -1850,17 +1849,10 @@ static int memcg_oom_wake_function(wait_queue_t *wait, | |||
1850 | return autoremove_wake_function(wait, mode, sync, arg); | 1849 | return autoremove_wake_function(wait, mode, sync, arg); |
1851 | } | 1850 | } |
1852 | 1851 | ||
1853 | static void memcg_wakeup_oom(struct mem_cgroup *memcg) | ||
1854 | { | ||
1855 | atomic_inc(&memcg->oom_wakeups); | ||
1856 | /* for filtering, pass "memcg" as argument. */ | ||
1857 | __wake_up(&memcg_oom_waitq, TASK_NORMAL, 0, memcg); | ||
1858 | } | ||
1859 | |||
1860 | static void memcg_oom_recover(struct mem_cgroup *memcg) | 1852 | static void memcg_oom_recover(struct mem_cgroup *memcg) |
1861 | { | 1853 | { |
1862 | if (memcg && atomic_read(&memcg->under_oom)) | 1854 | if (memcg && atomic_read(&memcg->under_oom)) |
1863 | memcg_wakeup_oom(memcg); | 1855 | __wake_up(&memcg_oom_waitq, TASK_NORMAL, 0, memcg); |
1864 | } | 1856 | } |
1865 | 1857 | ||
1866 | static void mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int order) | 1858 | static void mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int order) |