diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-07-03 14:53:49 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-07-06 09:45:56 -0400 |
commit | f47805a2af3ba83881ca52434bbbc6e9886b72fd (patch) | |
tree | 4767c0ca7db8fa23377a8f5a7a52bff1c7e972e5 | |
parent | 8b3ce7576598b8e3b746beb9e8d10c33bcc64edd (diff) |
perf evsel: Rename set_filter to apply_filter
We need to be able to go on constructing a complex filter in multiple
stages, since we can only set one filter per event.
For instance, we need to be able, in 'perf trace' to filter by the
'common_pid' field all the time, if only for the tracer itself, to
avoid a feedback loop, and, in addition, we may want to filter the
raw_syscalls:sys_{enter,exit} events by its 'id' filter, when using
'perf trace -e open,close' or 'perf trace -e !open,close', i.e. when
we are interested in just a subset of syscalls or when we are not
interested in it.
So we will have:
perf_evsel__set_filter(evsel, char *filter)
Replaces whatever is in evsel->filter.
perf_evsel__append_filter(evsel, const char *op, char *filter)
Appends, using op ("&&" or "||") with what is in evsel->filter.
perf_evsel__apply_filter(evsel, filter):
That actually applies a filter, be it the one being
constructed in evsel->filter, or any other, for tools
with more specific ways to build the filter, issuing
the appropriate ioctl for all the evsel fds.
The same changes will be made to the evlist__{set,apply} variants to
keep everything consistent.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-2s5z9xtpnc2lwio3cv5x0jek@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/util/evlist.c | 4 | ||||
-rw-r--r-- | tools/perf/util/evsel.c | 4 | ||||
-rw-r--r-- | tools/perf/util/evsel.h | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 6cfdee68e763..51913284e8e3 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c | |||
@@ -1161,7 +1161,7 @@ int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **e | |||
1161 | if (evsel->filter == NULL) | 1161 | if (evsel->filter == NULL) |
1162 | continue; | 1162 | continue; |
1163 | 1163 | ||
1164 | err = perf_evsel__set_filter(evsel, ncpus, nthreads, evsel->filter); | 1164 | err = perf_evsel__apply_filter(evsel, ncpus, nthreads, evsel->filter); |
1165 | if (err) { | 1165 | if (err) { |
1166 | *err_evsel = evsel; | 1166 | *err_evsel = evsel; |
1167 | break; | 1167 | break; |
@@ -1179,7 +1179,7 @@ int perf_evlist__set_filter(struct perf_evlist *evlist, const char *filter) | |||
1179 | nthreads = thread_map__nr(evlist->threads); | 1179 | nthreads = thread_map__nr(evlist->threads); |
1180 | 1180 | ||
1181 | evlist__for_each(evlist, evsel) { | 1181 | evlist__for_each(evlist, evsel) { |
1182 | err = perf_evsel__set_filter(evsel, ncpus, nthreads, filter); | 1182 | err = perf_evsel__apply_filter(evsel, ncpus, nthreads, filter); |
1183 | if (err) | 1183 | if (err) |
1184 | break; | 1184 | break; |
1185 | } | 1185 | } |
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 2936b3080722..667677495fb0 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c | |||
@@ -815,8 +815,8 @@ static int perf_evsel__run_ioctl(struct perf_evsel *evsel, int ncpus, int nthrea | |||
815 | return 0; | 815 | return 0; |
816 | } | 816 | } |
817 | 817 | ||
818 | int perf_evsel__set_filter(struct perf_evsel *evsel, int ncpus, int nthreads, | 818 | int perf_evsel__apply_filter(struct perf_evsel *evsel, int ncpus, int nthreads, |
819 | const char *filter) | 819 | const char *filter) |
820 | { | 820 | { |
821 | return perf_evsel__run_ioctl(evsel, ncpus, nthreads, | 821 | return perf_evsel__run_ioctl(evsel, ncpus, nthreads, |
822 | PERF_EVENT_IOC_SET_FILTER, | 822 | PERF_EVENT_IOC_SET_FILTER, |
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 4a7ed5656cf0..a3ebb83d767e 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h | |||
@@ -182,8 +182,8 @@ void __perf_evsel__reset_sample_bit(struct perf_evsel *evsel, | |||
182 | void perf_evsel__set_sample_id(struct perf_evsel *evsel, | 182 | void perf_evsel__set_sample_id(struct perf_evsel *evsel, |
183 | bool use_sample_identifier); | 183 | bool use_sample_identifier); |
184 | 184 | ||
185 | int perf_evsel__set_filter(struct perf_evsel *evsel, int ncpus, int nthreads, | 185 | int perf_evsel__apply_filter(struct perf_evsel *evsel, int ncpus, int nthreads, |
186 | const char *filter); | 186 | const char *filter); |
187 | int perf_evsel__enable(struct perf_evsel *evsel, int ncpus, int nthreads); | 187 | int perf_evsel__enable(struct perf_evsel *evsel, int ncpus, int nthreads); |
188 | 188 | ||
189 | int perf_evsel__open_per_cpu(struct perf_evsel *evsel, | 189 | int perf_evsel__open_per_cpu(struct perf_evsel *evsel, |