aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMasami Hiramatsu <mhiramat@kernel.org>2017-02-13 10:03:38 -0500
committerJon Medhurst <tixy@linaro.org>2017-03-21 12:24:18 -0400
commitf3fbd7ec62dec1528fb8044034e2885f2b257941 (patch)
tree5e14e41e31c5716f061c3c6b04c5d333880b5b3c
parent4495c08e84729385774601b5146d51d9e5849f81 (diff)
arm: kprobes: Allow to handle reentered kprobe on single-stepping
This is arm port of commit 6a5022a56ac3 ("kprobes/x86: Allow to handle reentered kprobe on single-stepping") Since the FIQ handlers can interrupt in the single stepping (or preparing the single stepping, do_debug etc.), we should consider a kprobe is hit in the NMI handler. Even in that case, the kprobe is allowed to be reentered as same as the kprobes hit in kprobe handlers (KPROBE_HIT_ACTIVE or KPROBE_HIT_SSDONE). The real issue will happen when a kprobe hit while another reentered kprobe is processing (KPROBE_REENTER), because we already consumed a saved-area for the previous kprobe. Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: Jon Medhurst <tixy@linaro.org>
-rw-r--r--arch/arm/probes/kprobes/core.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/arch/arm/probes/kprobes/core.c b/arch/arm/probes/kprobes/core.c
index b6dc9d838a9a..35148b46c4f5 100644
--- a/arch/arm/probes/kprobes/core.c
+++ b/arch/arm/probes/kprobes/core.c
@@ -271,6 +271,7 @@ void __kprobes kprobe_handler(struct pt_regs *regs)
271 switch (kcb->kprobe_status) { 271 switch (kcb->kprobe_status) {
272 case KPROBE_HIT_ACTIVE: 272 case KPROBE_HIT_ACTIVE:
273 case KPROBE_HIT_SSDONE: 273 case KPROBE_HIT_SSDONE:
274 case KPROBE_HIT_SS:
274 /* A pre- or post-handler probe got us here. */ 275 /* A pre- or post-handler probe got us here. */
275 kprobes_inc_nmissed_count(p); 276 kprobes_inc_nmissed_count(p);
276 save_previous_kprobe(kcb); 277 save_previous_kprobe(kcb);
@@ -279,6 +280,11 @@ void __kprobes kprobe_handler(struct pt_regs *regs)
279 singlestep(p, regs, kcb); 280 singlestep(p, regs, kcb);
280 restore_previous_kprobe(kcb); 281 restore_previous_kprobe(kcb);
281 break; 282 break;
283 case KPROBE_REENTER:
284 /* A nested probe was hit in FIQ, it is a BUG */
285 pr_warn("Unrecoverable kprobe detected at %p.\n",
286 p->addr);
287 /* fall through */
282 default: 288 default:
283 /* impossible cases */ 289 /* impossible cases */
284 BUG(); 290 BUG();