diff options
author | Christian Engelmayer <cengelma@gmx.at> | 2015-09-18 18:32:24 -0400 |
---|---|---|
committer | Thomas Hellstrom <thellstrom@vmware.com> | 2015-09-24 03:22:00 -0400 |
commit | f3b8c0caca02001565cb14b845bf90f59dea8213 (patch) | |
tree | 47b01f4020935139db1b586814f23abaedeb437a | |
parent | 49558b471369e790650df8706b5608fee27af42c (diff) |
drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty()
Function vmw_kms_helper_dirty() uses the uninitialized variable ret as
return value. Make the result deterministic and directly return as the
variable is unused anyway. Detected by Coverity CID 1324255.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
-rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 61fb7f3de311..15a6c01cd016 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | |||
@@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, | |||
1685 | struct drm_crtc *crtc; | 1685 | struct drm_crtc *crtc; |
1686 | u32 num_units = 0; | 1686 | u32 num_units = 0; |
1687 | u32 i, k; | 1687 | u32 i, k; |
1688 | int ret; | ||
1689 | 1688 | ||
1690 | dirty->dev_priv = dev_priv; | 1689 | dirty->dev_priv = dev_priv; |
1691 | 1690 | ||
@@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, | |||
1711 | if (!dirty->cmd) { | 1710 | if (!dirty->cmd) { |
1712 | DRM_ERROR("Couldn't reserve fifo space " | 1711 | DRM_ERROR("Couldn't reserve fifo space " |
1713 | "for dirty blits.\n"); | 1712 | "for dirty blits.\n"); |
1714 | return ret; | 1713 | return -ENOMEM; |
1715 | } | 1714 | } |
1716 | memset(dirty->cmd, 0, dirty->fifo_reserve_size); | 1715 | memset(dirty->cmd, 0, dirty->fifo_reserve_size); |
1717 | } | 1716 | } |