diff options
author | Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> | 2018-07-04 04:14:47 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-07-06 21:44:09 -0400 |
commit | f3146f3774c8657b25326313ce807a5d4eac1d40 (patch) | |
tree | c55007e7edb124720610c1b87a573ca7cacff37d | |
parent | 4c10628afda78dbf5dffc13360b576370ee98aab (diff) |
sh_eth: remove useless serialization in sh_eth_get_link_ksettings()
phy_ethtool_ksettings_get() call does not modify device state or device
driver state, hence there is no need to utilize a driver specific
spinlock.
Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 50ff18870be2..152edd1e9a23 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c | |||
@@ -2043,15 +2043,10 @@ static int sh_eth_phy_start(struct net_device *ndev) | |||
2043 | static int sh_eth_get_link_ksettings(struct net_device *ndev, | 2043 | static int sh_eth_get_link_ksettings(struct net_device *ndev, |
2044 | struct ethtool_link_ksettings *cmd) | 2044 | struct ethtool_link_ksettings *cmd) |
2045 | { | 2045 | { |
2046 | struct sh_eth_private *mdp = netdev_priv(ndev); | ||
2047 | unsigned long flags; | ||
2048 | |||
2049 | if (!ndev->phydev) | 2046 | if (!ndev->phydev) |
2050 | return -ENODEV; | 2047 | return -ENODEV; |
2051 | 2048 | ||
2052 | spin_lock_irqsave(&mdp->lock, flags); | ||
2053 | phy_ethtool_ksettings_get(ndev->phydev, cmd); | 2049 | phy_ethtool_ksettings_get(ndev->phydev, cmd); |
2054 | spin_unlock_irqrestore(&mdp->lock, flags); | ||
2055 | 2050 | ||
2056 | return 0; | 2051 | return 0; |
2057 | } | 2052 | } |