aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVasundhara Volam <vasundhara-v.volam@broadcom.com>2019-10-21 01:34:28 -0400
committerJakub Kicinski <jakub.kicinski@netronome.com>2019-10-22 16:15:39 -0400
commitf255ed1c4e4c5ed8171b6e81dce1297df1f1b60c (patch)
treec48d2f5cf2228f7ab77007c85667c551748ded43
parentc6a9e7aa2e8b15402022a15625284069d4fd6df0 (diff)
bnxt_en: Minor formatting changes in FW devlink_health_reporter
Minor formatting changes to diagnose cb for FW devlink health reporter. Suggested-by: Jiri Pirko <jiri@mellanox.com> Cc: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
-rw-r--r--drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index bd4b9f31614e..7151244f8c7d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -29,25 +29,20 @@ static int bnxt_fw_reporter_diagnose(struct devlink_health_reporter *reporter,
29 val = bnxt_fw_health_readl(bp, BNXT_FW_HEALTH_REG); 29 val = bnxt_fw_health_readl(bp, BNXT_FW_HEALTH_REG);
30 health_status = val & 0xffff; 30 health_status = val & 0xffff;
31 31
32 if (health_status == BNXT_FW_STATUS_HEALTHY) { 32 if (health_status < BNXT_FW_STATUS_HEALTHY) {
33 rc = devlink_fmsg_string_pair_put(fmsg, "FW status", 33 rc = devlink_fmsg_string_pair_put(fmsg, "Description",
34 "Healthy;"); 34 "Not yet completed initialization");
35 if (rc)
36 return rc;
37 } else if (health_status < BNXT_FW_STATUS_HEALTHY) {
38 rc = devlink_fmsg_string_pair_put(fmsg, "FW status",
39 "Not yet completed initialization;");
40 if (rc) 35 if (rc)
41 return rc; 36 return rc;
42 } else if (health_status > BNXT_FW_STATUS_HEALTHY) { 37 } else if (health_status > BNXT_FW_STATUS_HEALTHY) {
43 rc = devlink_fmsg_string_pair_put(fmsg, "FW status", 38 rc = devlink_fmsg_string_pair_put(fmsg, "Description",
44 "Encountered fatal error and cannot recover;"); 39 "Encountered fatal error and cannot recover");
45 if (rc) 40 if (rc)
46 return rc; 41 return rc;
47 } 42 }
48 43
49 if (val >> 16) { 44 if (val >> 16) {
50 rc = devlink_fmsg_u32_pair_put(fmsg, "Error", val >> 16); 45 rc = devlink_fmsg_u32_pair_put(fmsg, "Error code", val >> 16);
51 if (rc) 46 if (rc)
52 return rc; 47 return rc;
53 } 48 }