aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHaishuang Yan <yanhaishuang@cmss.chinamobile.com>2017-06-14 22:29:30 -0400
committerDavid S. Miller <davem@davemloft.net>2017-06-16 12:01:29 -0400
commitf1925ca50deb48eddafc01bc12c2a17bfbf54425 (patch)
tree3afadacefe7943286568cee13fc7a1382642d540
parent469f87e158628fe66dcbbce9dd5e7b7acfe934a9 (diff)
ip6_tunnel: fix potential issue in __ip6_tnl_rcv
When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call dst_release to free it in error code path. Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") CC: Alexei Starovoitov <ast@fb.com> Tested-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/ip6_tunnel.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index c3581973f5d7..035c0496b92a 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -858,6 +858,8 @@ static int __ip6_tnl_rcv(struct ip6_tnl *tunnel, struct sk_buff *skb,
858 return 0; 858 return 0;
859 859
860drop: 860drop:
861 if (tun_dst)
862 dst_release((struct dst_entry *)tun_dst);
861 kfree_skb(skb); 863 kfree_skb(skb);
862 return 0; 864 return 0;
863} 865}