aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Sterba <dsterba@suse.com>2015-10-08 05:37:06 -0400
committerDavid Sterba <dsterba@suse.com>2015-10-08 07:08:03 -0400
commitf14d104dbdb5044dac9acd0e983ffb60f706c746 (patch)
treea1fae623eade7120397723d6edef6a99356997f5
parent9464732266862f6044e4708dca6c4b2a83dd937b (diff)
btrfs: switch more printks to our helpers
Convert the simple cases, not all functions provide a way to reach the fs_info. Also skipped debugging messages (print-tree, integrity checker and pr_debug) and messages that are printed from possibly unfinished mount. Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r--fs/btrfs/disk-io.c12
-rw-r--r--fs/btrfs/extent_io.c18
-rw-r--r--fs/btrfs/ioctl.c6
-rw-r--r--fs/btrfs/root-tree.c5
-rw-r--r--fs/btrfs/send.c2
-rw-r--r--fs/btrfs/volumes.c3
6 files changed, 25 insertions, 21 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 72553cd9ed14..5bc94d2d5699 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2347,8 +2347,7 @@ static int btrfs_replay_log(struct btrfs_fs_info *fs_info,
2347 u64 bytenr = btrfs_super_log_root(disk_super); 2347 u64 bytenr = btrfs_super_log_root(disk_super);
2348 2348
2349 if (fs_devices->rw_devices == 0) { 2349 if (fs_devices->rw_devices == 0) {
2350 printk(KERN_WARNING "BTRFS: log replay required " 2350 btrfs_warn(fs_info, "log replay required on RO media");
2351 "on RO media\n");
2352 return -EIO; 2351 return -EIO;
2353 } 2352 }
2354 2353
@@ -2363,12 +2362,12 @@ static int btrfs_replay_log(struct btrfs_fs_info *fs_info,
2363 log_tree_root->node = read_tree_block(tree_root, bytenr, 2362 log_tree_root->node = read_tree_block(tree_root, bytenr,
2364 fs_info->generation + 1); 2363 fs_info->generation + 1);
2365 if (IS_ERR(log_tree_root->node)) { 2364 if (IS_ERR(log_tree_root->node)) {
2366 printk(KERN_ERR "BTRFS: failed to read log tree\n"); 2365 btrfs_warn(fs_info, "failed to read log tree");
2367 ret = PTR_ERR(log_tree_root->node); 2366 ret = PTR_ERR(log_tree_root->node);
2368 kfree(log_tree_root); 2367 kfree(log_tree_root);
2369 return ret; 2368 return ret;
2370 } else if (!extent_buffer_uptodate(log_tree_root->node)) { 2369 } else if (!extent_buffer_uptodate(log_tree_root->node)) {
2371 printk(KERN_ERR "BTRFS: failed to read log tree\n"); 2370 btrfs_err(fs_info, "failed to read log tree");
2372 free_extent_buffer(log_tree_root->node); 2371 free_extent_buffer(log_tree_root->node);
2373 kfree(log_tree_root); 2372 kfree(log_tree_root);
2374 return -EIO; 2373 return -EIO;
@@ -3294,8 +3293,9 @@ static int write_dev_supers(struct btrfs_device *device,
3294 bh = __getblk(device->bdev, bytenr / 4096, 3293 bh = __getblk(device->bdev, bytenr / 4096,
3295 BTRFS_SUPER_INFO_SIZE); 3294 BTRFS_SUPER_INFO_SIZE);
3296 if (!bh) { 3295 if (!bh) {
3297 printk(KERN_ERR "BTRFS: couldn't get super " 3296 btrfs_err(device->dev_root->fs_info,
3298 "buffer head for bytenr %Lu\n", bytenr); 3297 "couldn't get super buffer head for bytenr %llu",
3298 bytenr);
3299 errors++; 3299 errors++;
3300 continue; 3300 continue;
3301 } 3301 }
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index bb318b4e5dd0..c7a33913188b 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -5563,13 +5563,15 @@ void memcpy_extent_buffer(struct extent_buffer *dst, unsigned long dst_offset,
5563 unsigned long src_i; 5563 unsigned long src_i;
5564 5564
5565 if (src_offset + len > dst->len) { 5565 if (src_offset + len > dst->len) {
5566 printk(KERN_ERR "BTRFS: memmove bogus src_offset %lu move " 5566 btrfs_err(dst->fs_info,
5567 "len %lu dst len %lu\n", src_offset, len, dst->len); 5567 "memmove bogus src_offset %lu move "
5568 "len %lu dst len %lu", src_offset, len, dst->len);
5568 BUG_ON(1); 5569 BUG_ON(1);
5569 } 5570 }
5570 if (dst_offset + len > dst->len) { 5571 if (dst_offset + len > dst->len) {
5571 printk(KERN_ERR "BTRFS: memmove bogus dst_offset %lu move " 5572 btrfs_err(dst->fs_info,
5572 "len %lu dst len %lu\n", dst_offset, len, dst->len); 5573 "memmove bogus dst_offset %lu move "
5574 "len %lu dst len %lu", dst_offset, len, dst->len);
5573 BUG_ON(1); 5575 BUG_ON(1);
5574 } 5576 }
5575 5577
@@ -5609,13 +5611,13 @@ void memmove_extent_buffer(struct extent_buffer *dst, unsigned long dst_offset,
5609 unsigned long src_i; 5611 unsigned long src_i;
5610 5612
5611 if (src_offset + len > dst->len) { 5613 if (src_offset + len > dst->len) {
5612 printk(KERN_ERR "BTRFS: memmove bogus src_offset %lu move " 5614 btrfs_err(dst->fs_info, "memmove bogus src_offset %lu move "
5613 "len %lu len %lu\n", src_offset, len, dst->len); 5615 "len %lu len %lu", src_offset, len, dst->len);
5614 BUG_ON(1); 5616 BUG_ON(1);
5615 } 5617 }
5616 if (dst_offset + len > dst->len) { 5618 if (dst_offset + len > dst->len) {
5617 printk(KERN_ERR "BTRFS: memmove bogus dst_offset %lu move " 5619 btrfs_err(dst->fs_info, "memmove bogus dst_offset %lu move "
5618 "len %lu len %lu\n", dst_offset, len, dst->len); 5620 "len %lu len %lu", dst_offset, len, dst->len);
5619 BUG_ON(1); 5621 BUG_ON(1);
5620 } 5622 }
5621 if (dst_offset < src_offset) { 5623 if (dst_offset < src_offset) {
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 8e9105af723e..2e520c635709 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -1342,7 +1342,7 @@ int btrfs_defrag_file(struct inode *inode, struct file *file,
1342 break; 1342 break;
1343 1343
1344 if (btrfs_defrag_cancelled(root->fs_info)) { 1344 if (btrfs_defrag_cancelled(root->fs_info)) {
1345 printk(KERN_DEBUG "BTRFS: defrag_file cancelled\n"); 1345 btrfs_debug(root->fs_info, "defrag_file cancelled");
1346 ret = -EAGAIN; 1346 ret = -EAGAIN;
1347 break; 1347 break;
1348 } 1348 }
@@ -2081,7 +2081,7 @@ static noinline int search_ioctl(struct inode *inode,
2081 key.offset = (u64)-1; 2081 key.offset = (u64)-1;
2082 root = btrfs_read_fs_root_no_name(info, &key); 2082 root = btrfs_read_fs_root_no_name(info, &key);
2083 if (IS_ERR(root)) { 2083 if (IS_ERR(root)) {
2084 printk(KERN_ERR "BTRFS: could not find root %llu\n", 2084 btrfs_err(info, "could not find root %llu",
2085 sk->tree_id); 2085 sk->tree_id);
2086 btrfs_free_path(path); 2086 btrfs_free_path(path);
2087 return -ENOENT; 2087 return -ENOENT;
@@ -2221,7 +2221,7 @@ static noinline int btrfs_search_path_in_tree(struct btrfs_fs_info *info,
2221 key.offset = (u64)-1; 2221 key.offset = (u64)-1;
2222 root = btrfs_read_fs_root_no_name(info, &key); 2222 root = btrfs_read_fs_root_no_name(info, &key);
2223 if (IS_ERR(root)) { 2223 if (IS_ERR(root)) {
2224 printk(KERN_ERR "BTRFS: could not find root %llu\n", tree_id); 2224 btrfs_err(info, "could not find root %llu", tree_id);
2225 ret = -ENOENT; 2225 ret = -ENOENT;
2226 goto out; 2226 goto out;
2227 } 2227 }
diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
index 360a728a639f..42267d37bb94 100644
--- a/fs/btrfs/root-tree.c
+++ b/fs/btrfs/root-tree.c
@@ -45,12 +45,13 @@ static void btrfs_read_root_item(struct extent_buffer *eb, int slot,
45 if (!need_reset && btrfs_root_generation(item) 45 if (!need_reset && btrfs_root_generation(item)
46 != btrfs_root_generation_v2(item)) { 46 != btrfs_root_generation_v2(item)) {
47 if (btrfs_root_generation_v2(item) != 0) { 47 if (btrfs_root_generation_v2(item) != 0) {
48 printk(KERN_WARNING "BTRFS: mismatching " 48 btrfs_warn(eb->fs_info,
49 "mismatching "
49 "generation and generation_v2 " 50 "generation and generation_v2 "
50 "found in root item. This root " 51 "found in root item. This root "
51 "was probably mounted with an " 52 "was probably mounted with an "
52 "older kernel. Resetting all " 53 "older kernel. Resetting all "
53 "new fields.\n"); 54 "new fields.");
54 } 55 }
55 need_reset = 1; 56 need_reset = 1;
56 } 57 }
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index aa72bfd28f7d..4ea07c8cd6c2 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -2562,7 +2562,7 @@ verbose_printk("btrfs: send_create_inode %llu\n", ino);
2562 } else if (S_ISSOCK(mode)) { 2562 } else if (S_ISSOCK(mode)) {
2563 cmd = BTRFS_SEND_C_MKSOCK; 2563 cmd = BTRFS_SEND_C_MKSOCK;
2564 } else { 2564 } else {
2565 printk(KERN_WARNING "btrfs: unexpected inode type %o", 2565 btrfs_warn(sctx->send_root->fs_info, "unexpected inode type %o",
2566 (int)(mode & S_IFMT)); 2566 (int)(mode & S_IFMT));
2567 ret = -ENOTSUPP; 2567 ret = -ENOTSUPP;
2568 goto out; 2568 goto out;
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 4f80986dbf3c..7ad310cc3efb 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2352,7 +2352,8 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
2352 root->fs_info->fsid); 2352 root->fs_info->fsid);
2353 if (kobject_rename(&root->fs_info->fs_devices->super_kobj, 2353 if (kobject_rename(&root->fs_info->fs_devices->super_kobj,
2354 fsid_buf)) 2354 fsid_buf))
2355 pr_warn("BTRFS: sysfs: failed to create fsid for sprout\n"); 2355 btrfs_warn(root->fs_info,
2356 "sysfs: failed to create fsid for sprout");
2356 } 2357 }
2357 2358
2358 root->fs_info->num_tolerated_disk_barrier_failures = 2359 root->fs_info->num_tolerated_disk_barrier_failures =