aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBart Van Assche <bart.vanassche@wdc.com>2017-10-27 10:23:21 -0400
committerJens Axboe <axboe@kernel.dk>2017-10-27 10:23:21 -0400
commitefea2abcb03215f2efadfe994ff7f652aaff196b (patch)
tree5c16510723274dfea91e4f0e9d4100a62e41b360
parent93689a603141ca9237203cebfa6b45775caccdb5 (diff)
virtio_blk: Fix an SG_IO regression
Avoid that submitting an SG_IO ioctl triggers a kernel oops that is preceded by: usercopy: kernel memory overwrite attempt detected to (null) (<null>) (6 bytes) kernel BUG at mm/usercopy.c:72! Reported-by: Dann Frazier <dann.frazier@canonical.com> Fixes: commit ca18d6f769d2 ("block: Make most scsi_req_init() calls implicit") Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Dann Frazier <dann.frazier@canonical.com> Cc: <stable@vger.kernel.org> # v4.13 Reviewed-by: Christoph Hellwig <hch@lst.de> Moved virtblk_initialize_rq() inside CONFIG_VIRTIO_BLK_SCSI. Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--drivers/block/virtio_blk.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 34e17ee799be..68846897d213 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -593,10 +593,22 @@ static int virtblk_map_queues(struct blk_mq_tag_set *set)
593 return blk_mq_virtio_map_queues(set, vblk->vdev, 0); 593 return blk_mq_virtio_map_queues(set, vblk->vdev, 0);
594} 594}
595 595
596#ifdef CONFIG_VIRTIO_BLK_SCSI
597static void virtblk_initialize_rq(struct request *req)
598{
599 struct virtblk_req *vbr = blk_mq_rq_to_pdu(req);
600
601 scsi_req_init(&vbr->sreq);
602}
603#endif
604
596static const struct blk_mq_ops virtio_mq_ops = { 605static const struct blk_mq_ops virtio_mq_ops = {
597 .queue_rq = virtio_queue_rq, 606 .queue_rq = virtio_queue_rq,
598 .complete = virtblk_request_done, 607 .complete = virtblk_request_done,
599 .init_request = virtblk_init_request, 608 .init_request = virtblk_init_request,
609#ifdef CONFIG_VIRTIO_BLK_SCSI
610 .initialize_rq_fn = virtblk_initialize_rq,
611#endif
600 .map_queues = virtblk_map_queues, 612 .map_queues = virtblk_map_queues,
601}; 613};
602 614