diff options
| author | Vincent Chen <vincentc@andestech.com> | 2018-04-24 03:08:46 -0400 |
|---|---|---|
| committer | Greentime Hu <greentime@andestech.com> | 2018-05-23 01:26:22 -0400 |
| commit | efcc4ea872edaeded28245d9b2ca8b9d8181b7cf (patch) | |
| tree | dbe604d6797be13de20072e512f0af99cdc7afce | |
| parent | 1613de8a785d21b3aac73d2a2e640b66d514393b (diff) | |
nds32: Correct flush_dcache_page function
1. Disable local irq before d-cache write-back and invalidate.
The cpu_dcache_wbinval_page function is composed of d-cache
write-back and invalidate. If the local irq is enabled when calling
cpu_dcache_wbinval_page, the content of d-cache is possibly updated
between write-back and invalidate. In this case, the updated data will
be dropped due to the following d-cache invalidation. Therefore, we
disable the local irq before calling cpu_dcache_wbinval_page.
2. Correct the data write-back for page aliasing case.
Only the page whose (page->index << PAGE_SHIFT) is located at the
same page color as page_address(page) needs to execute data write-back
in flush_dcache_page function.
Signed-off-by: Vincent Chen <vincentc@andestech.com>
Reviewed-by: Greentime Hu <greentime@andestech.com>
Signed-off-by: Greentime Hu <greentime@andestech.com>
| -rw-r--r-- | arch/nds32/mm/cacheflush.c | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/arch/nds32/mm/cacheflush.c b/arch/nds32/mm/cacheflush.c index ee44ad96b6ed..02f25ee39c1d 100644 --- a/arch/nds32/mm/cacheflush.c +++ b/arch/nds32/mm/cacheflush.c | |||
| @@ -217,17 +217,20 @@ void flush_dcache_page(struct page *page) | |||
| 217 | if (mapping && !mapping_mapped(mapping)) | 217 | if (mapping && !mapping_mapped(mapping)) |
| 218 | set_bit(PG_dcache_dirty, &page->flags); | 218 | set_bit(PG_dcache_dirty, &page->flags); |
| 219 | else { | 219 | else { |
| 220 | int i, pc; | 220 | unsigned long kaddr, flags; |
| 221 | unsigned long vto, kaddr, flags; | 221 | |
| 222 | kaddr = (unsigned long)page_address(page); | 222 | kaddr = (unsigned long)page_address(page); |
| 223 | cpu_dcache_wbinval_page(kaddr); | ||
| 224 | pc = CACHE_SET(DCACHE) * CACHE_LINE_SIZE(DCACHE) / PAGE_SIZE; | ||
| 225 | local_irq_save(flags); | 223 | local_irq_save(flags); |
| 226 | for (i = 0; i < pc; i++) { | 224 | cpu_dcache_wbinval_page(kaddr); |
| 227 | vto = | 225 | if (mapping) { |
| 228 | kremap0(kaddr + i * PAGE_SIZE, page_to_phys(page)); | 226 | unsigned long vaddr, kto; |
| 229 | cpu_dcache_wbinval_page(vto); | 227 | |
| 230 | kunmap01(vto); | 228 | vaddr = page->index << PAGE_SHIFT; |
| 229 | if (aliasing(vaddr, kaddr)) { | ||
| 230 | kto = kremap0(vaddr, page_to_phys(page)); | ||
| 231 | cpu_dcache_wbinval_page(kto); | ||
| 232 | kunmap01(kto); | ||
| 233 | } | ||
| 231 | } | 234 | } |
| 232 | local_irq_restore(flags); | 235 | local_irq_restore(flags); |
| 233 | } | 236 | } |
