aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Banman <abanman@sgi.com>2016-09-21 12:09:13 -0400
committerIngo Molnar <mingo@kernel.org>2016-09-22 05:16:12 -0400
commitefa59ab3e7526650265f0fd9696ef8be8d88ec13 (patch)
tree686623c7ebf72b8b174f7b4ff74dbe686ffeb649
parent67492c86b33db0a8a056c72293d4802b37ac8ac6 (diff)
x86/platform/uv/BAU: Clean up and update printks
Replace all uses of printk with the appropriate pr_*() function. Signed-off-by: Andrew Banman <abanman@sgi.com> Acked-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Mike Travis <travis@sgi.com> Acked-by: Dimitri Sivanich <sivanich@sgi.com> Acked-by: Thomas Gleixner <tglx@linutronix.de> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: akpm@linux-foundation.org Cc: rja@sgi.com Link: http://lkml.kernel.org/r/1474474161-265604-3-git-send-email-abanman@sgi.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--arch/x86/platform/uv/tlb_uv.c26
1 files changed, 13 insertions, 13 deletions
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index b84c2a22424d..8462fd1583ed 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1497,16 +1497,16 @@ static ssize_t ptc_proc_write(struct file *file, const char __user *user,
1497 } 1497 }
1498 1498
1499 if (kstrtol(optstr, 10, &input_arg) < 0) { 1499 if (kstrtol(optstr, 10, &input_arg) < 0) {
1500 printk(KERN_DEBUG "%s is invalid\n", optstr); 1500 pr_debug("%s is invalid\n", optstr);
1501 return -EINVAL; 1501 return -EINVAL;
1502 } 1502 }
1503 1503
1504 if (input_arg == 0) { 1504 if (input_arg == 0) {
1505 elements = ARRAY_SIZE(stat_description); 1505 elements = ARRAY_SIZE(stat_description);
1506 printk(KERN_DEBUG "# cpu: cpu number\n"); 1506 pr_debug("# cpu: cpu number\n");
1507 printk(KERN_DEBUG "Sender statistics:\n"); 1507 pr_debug("Sender statistics:\n");
1508 for (i = 0; i < elements; i++) 1508 for (i = 0; i < elements; i++)
1509 printk(KERN_DEBUG "%s\n", stat_description[i]); 1509 pr_debug("%s\n", stat_description[i]);
1510 } else if (input_arg == -1) { 1510 } else if (input_arg == -1) {
1511 for_each_present_cpu(cpu) { 1511 for_each_present_cpu(cpu) {
1512 stat = &per_cpu(ptcstats, cpu); 1512 stat = &per_cpu(ptcstats, cpu);
@@ -1554,7 +1554,7 @@ static int parse_tunables_write(struct bau_control *bcp, char *instr,
1554 break; 1554 break;
1555 } 1555 }
1556 if (cnt != e) { 1556 if (cnt != e) {
1557 printk(KERN_INFO "bau tunable error: should be %d values\n", e); 1557 pr_info("bau tunable error: should be %d values\n", e);
1558 return -EINVAL; 1558 return -EINVAL;
1559 } 1559 }
1560 1560
@@ -1571,7 +1571,7 @@ static int parse_tunables_write(struct bau_control *bcp, char *instr,
1571 continue; 1571 continue;
1572 } 1572 }
1573 if (val < 1 || val > bcp->cpus_in_uvhub) { 1573 if (val < 1 || val > bcp->cpus_in_uvhub) {
1574 printk(KERN_DEBUG 1574 pr_debug(
1575 "Error: BAU max concurrent %d is invalid\n", 1575 "Error: BAU max concurrent %d is invalid\n",
1576 val); 1576 val);
1577 return -EINVAL; 1577 return -EINVAL;
@@ -1676,21 +1676,21 @@ static int __init uv_ptc_init(void)
1676 proc_uv_ptc = proc_create(UV_PTC_BASENAME, 0444, NULL, 1676 proc_uv_ptc = proc_create(UV_PTC_BASENAME, 0444, NULL,
1677 &proc_uv_ptc_operations); 1677 &proc_uv_ptc_operations);
1678 if (!proc_uv_ptc) { 1678 if (!proc_uv_ptc) {
1679 printk(KERN_ERR "unable to create %s proc entry\n", 1679 pr_err("unable to create %s proc entry\n",
1680 UV_PTC_BASENAME); 1680 UV_PTC_BASENAME);
1681 return -EINVAL; 1681 return -EINVAL;
1682 } 1682 }
1683 1683
1684 tunables_dir = debugfs_create_dir(UV_BAU_TUNABLES_DIR, NULL); 1684 tunables_dir = debugfs_create_dir(UV_BAU_TUNABLES_DIR, NULL);
1685 if (!tunables_dir) { 1685 if (!tunables_dir) {
1686 printk(KERN_ERR "unable to create debugfs directory %s\n", 1686 pr_err("unable to create debugfs directory %s\n",
1687 UV_BAU_TUNABLES_DIR); 1687 UV_BAU_TUNABLES_DIR);
1688 return -EINVAL; 1688 return -EINVAL;
1689 } 1689 }
1690 tunables_file = debugfs_create_file(UV_BAU_TUNABLES_FILE, 0600, 1690 tunables_file = debugfs_create_file(UV_BAU_TUNABLES_FILE, 0600,
1691 tunables_dir, NULL, &tunables_fops); 1691 tunables_dir, NULL, &tunables_fops);
1692 if (!tunables_file) { 1692 if (!tunables_file) {
1693 printk(KERN_ERR "unable to create debugfs file %s\n", 1693 pr_err("unable to create debugfs file %s\n",
1694 UV_BAU_TUNABLES_FILE); 1694 UV_BAU_TUNABLES_FILE);
1695 return -EINVAL; 1695 return -EINVAL;
1696 } 1696 }
@@ -1944,7 +1944,7 @@ static int __init get_cpu_topology(int base_pnode,
1944 1944
1945 pnode = uv_cpu_hub_info(cpu)->pnode; 1945 pnode = uv_cpu_hub_info(cpu)->pnode;
1946 if ((pnode - base_pnode) >= UV_DISTRIBUTION_SIZE) { 1946 if ((pnode - base_pnode) >= UV_DISTRIBUTION_SIZE) {
1947 printk(KERN_EMERG 1947 pr_emerg(
1948 "cpu %d pnode %d-%d beyond %d; BAU disabled\n", 1948 "cpu %d pnode %d-%d beyond %d; BAU disabled\n",
1949 cpu, pnode, base_pnode, UV_DISTRIBUTION_SIZE); 1949 cpu, pnode, base_pnode, UV_DISTRIBUTION_SIZE);
1950 return 1; 1950 return 1;
@@ -1969,7 +1969,7 @@ static int __init get_cpu_topology(int base_pnode,
1969 sdp->cpu_number[sdp->num_cpus] = cpu; 1969 sdp->cpu_number[sdp->num_cpus] = cpu;
1970 sdp->num_cpus++; 1970 sdp->num_cpus++;
1971 if (sdp->num_cpus > MAX_CPUS_PER_SOCKET) { 1971 if (sdp->num_cpus > MAX_CPUS_PER_SOCKET) {
1972 printk(KERN_EMERG "%d cpus per socket invalid\n", 1972 pr_emerg("%d cpus per socket invalid\n",
1973 sdp->num_cpus); 1973 sdp->num_cpus);
1974 return 1; 1974 return 1;
1975 } 1975 }
@@ -2036,14 +2036,14 @@ static int scan_sock(struct socket_desc *sdp, struct uvhub_desc *bdp,
2036 else if (is_uv3_hub()) 2036 else if (is_uv3_hub())
2037 bcp->uvhub_version = 3; 2037 bcp->uvhub_version = 3;
2038 else { 2038 else {
2039 printk(KERN_EMERG "uvhub version not 1, 2 or 3\n"); 2039 pr_emerg("uvhub version not 1, 2, or 3\n");
2040 return 1; 2040 return 1;
2041 } 2041 }
2042 bcp->uvhub_master = *hmasterp; 2042 bcp->uvhub_master = *hmasterp;
2043 bcp->uvhub_cpu = uv_cpu_blade_processor_id(cpu); 2043 bcp->uvhub_cpu = uv_cpu_blade_processor_id(cpu);
2044 2044
2045 if (bcp->uvhub_cpu >= MAX_CPUS_PER_UVHUB) { 2045 if (bcp->uvhub_cpu >= MAX_CPUS_PER_UVHUB) {
2046 printk(KERN_EMERG "%d cpus per uvhub invalid\n", 2046 pr_emerg("%d cpus per uvhub invalid\n",
2047 bcp->uvhub_cpu); 2047 bcp->uvhub_cpu);
2048 return 1; 2048 return 1;
2049 } 2049 }