diff options
author | Daniel Axtens <dja@axtens.net> | 2018-03-01 01:13:38 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-03-04 17:49:17 -0500 |
commit | ee78bbef8d63202ca0f2485aecf30b8c2b0088cc (patch) | |
tree | fb4656122536f2df9964865d441751c31a0005da | |
parent | 779b7931b27bfa80bac46d0115d229259aef580b (diff) |
net: sched: tbf: handle GSO_BY_FRAGS case in enqueue
tbf_enqueue() checks the size of a packet before enqueuing it.
However, the GSO size check does not consider the GSO_BY_FRAGS
case, and so will drop GSO SCTP packets, causing a massive drop
in throughput.
Use skb_gso_validate_mac_len() instead, as it does consider that
case.
Signed-off-by: Daniel Axtens <dja@axtens.net>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/sched/sch_tbf.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c index 229172d509cc..03225a8df973 100644 --- a/net/sched/sch_tbf.c +++ b/net/sched/sch_tbf.c | |||
@@ -188,7 +188,8 @@ static int tbf_enqueue(struct sk_buff *skb, struct Qdisc *sch, | |||
188 | int ret; | 188 | int ret; |
189 | 189 | ||
190 | if (qdisc_pkt_len(skb) > q->max_size) { | 190 | if (qdisc_pkt_len(skb) > q->max_size) { |
191 | if (skb_is_gso(skb) && skb_gso_mac_seglen(skb) <= q->max_size) | 191 | if (skb_is_gso(skb) && |
192 | skb_gso_validate_mac_len(skb, q->max_size)) | ||
192 | return tbf_segment(skb, sch, to_free); | 193 | return tbf_segment(skb, sch, to_free); |
193 | return qdisc_drop(skb, sch, to_free); | 194 | return qdisc_drop(skb, sch, to_free); |
194 | } | 195 | } |