aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2012-05-16 12:15:56 -0400
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2012-05-16 12:15:56 -0400
commitedf6be245fd34a4438646375cecb11f5feb92646 (patch)
treeca1ddfc1900d5875d5434c6c7f39ca4966ef3baa
parent7c46d0ae29ba880963db283706950de7aa86c0a0 (diff)
UBIFS: rename dumping functions
This commit re-names all functions which dump something from "dbg_dump_*()" to "ubifs_dump_*()". This is done for consistency with UBI and because this way it will be more logical once we remove the debugging sompilation option. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
-rw-r--r--fs/ubifs/commit.c4
-rw-r--r--fs/ubifs/debug.c110
-rw-r--r--fs/ubifs/debug.h99
-rw-r--r--fs/ubifs/file.c2
-rw-r--r--fs/ubifs/io.c12
-rw-r--r--fs/ubifs/journal.c4
-rw-r--r--fs/ubifs/lprops.c8
-rw-r--r--fs/ubifs/lpt.c2
-rw-r--r--fs/ubifs/lpt_commit.c22
-rw-r--r--fs/ubifs/master.c4
-rw-r--r--fs/ubifs/orphan.c4
-rw-r--r--fs/ubifs/recovery.c8
-rw-r--r--fs/ubifs/replay.c4
-rw-r--r--fs/ubifs/sb.c2
-rw-r--r--fs/ubifs/scan.c2
-rw-r--r--fs/ubifs/super.c8
-rw-r--r--fs/ubifs/tnc.c12
-rw-r--r--fs/ubifs/tnc_commit.c12
-rw-r--r--fs/ubifs/tnc_misc.c4
19 files changed, 160 insertions, 163 deletions
diff --git a/fs/ubifs/commit.c b/fs/ubifs/commit.c
index fb3b5c813a30..4f795d1c4866 100644
--- a/fs/ubifs/commit.c
+++ b/fs/ubifs/commit.c
@@ -715,13 +715,13 @@ out:
715 715
716out_dump: 716out_dump:
717 dbg_err("dumping index node (iip=%d)", i->iip); 717 dbg_err("dumping index node (iip=%d)", i->iip);
718 dbg_dump_node(c, idx); 718 ubifs_dump_node(c, idx);
719 list_del(&i->list); 719 list_del(&i->list);
720 kfree(i); 720 kfree(i);
721 if (!list_empty(&list)) { 721 if (!list_empty(&list)) {
722 i = list_entry(list.prev, struct idx_node, list); 722 i = list_entry(list.prev, struct idx_node, list);
723 dbg_err("dumping parent index node"); 723 dbg_err("dumping parent index node");
724 dbg_dump_node(c, &i->idx); 724 ubifs_dump_node(c, &i->idx);
725 } 725 }
726out_free: 726out_free:
727 while (!list_empty(&list)) { 727 while (!list_empty(&list)) {
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 139025ad2ec8..914b4c879938 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -232,7 +232,7 @@ static void dump_ch(const struct ubifs_ch *ch)
232 printk(KERN_ERR "\tlen %u\n", le32_to_cpu(ch->len)); 232 printk(KERN_ERR "\tlen %u\n", le32_to_cpu(ch->len));
233} 233}
234 234
235void dbg_dump_inode(struct ubifs_info *c, const struct inode *inode) 235void ubifs_dump_inode(struct ubifs_info *c, const struct inode *inode)
236{ 236{
237 const struct ubifs_inode *ui = ubifs_inode(inode); 237 const struct ubifs_inode *ui = ubifs_inode(inode);
238 struct qstr nm = { .name = NULL }; 238 struct qstr nm = { .name = NULL };
@@ -300,7 +300,7 @@ void dbg_dump_inode(struct ubifs_info *c, const struct inode *inode)
300 kfree(pdent); 300 kfree(pdent);
301} 301}
302 302
303void dbg_dump_node(const struct ubifs_info *c, const void *node) 303void ubifs_dump_node(const struct ubifs_info *c, const void *node)
304{ 304{
305 int i, n; 305 int i, n;
306 union ubifs_key key; 306 union ubifs_key key;
@@ -603,7 +603,7 @@ void dbg_dump_node(const struct ubifs_info *c, const void *node)
603 spin_unlock(&dbg_lock); 603 spin_unlock(&dbg_lock);
604} 604}
605 605
606void dbg_dump_budget_req(const struct ubifs_budget_req *req) 606void ubifs_dump_budget_req(const struct ubifs_budget_req *req)
607{ 607{
608 spin_lock(&dbg_lock); 608 spin_lock(&dbg_lock);
609 printk(KERN_ERR "Budgeting request: new_ino %d, dirtied_ino %d\n", 609 printk(KERN_ERR "Budgeting request: new_ino %d, dirtied_ino %d\n",
@@ -620,7 +620,7 @@ void dbg_dump_budget_req(const struct ubifs_budget_req *req)
620 spin_unlock(&dbg_lock); 620 spin_unlock(&dbg_lock);
621} 621}
622 622
623void dbg_dump_lstats(const struct ubifs_lp_stats *lst) 623void ubifs_dump_lstats(const struct ubifs_lp_stats *lst)
624{ 624{
625 spin_lock(&dbg_lock); 625 spin_lock(&dbg_lock);
626 printk(KERN_ERR "(pid %d) Lprops statistics: empty_lebs %d, " 626 printk(KERN_ERR "(pid %d) Lprops statistics: empty_lebs %d, "
@@ -634,7 +634,7 @@ void dbg_dump_lstats(const struct ubifs_lp_stats *lst)
634 spin_unlock(&dbg_lock); 634 spin_unlock(&dbg_lock);
635} 635}
636 636
637void dbg_dump_budg(struct ubifs_info *c, const struct ubifs_budg_info *bi) 637void ubifs_dump_budg(struct ubifs_info *c, const struct ubifs_budg_info *bi)
638{ 638{
639 int i; 639 int i;
640 struct rb_node *rb; 640 struct rb_node *rb;
@@ -707,7 +707,7 @@ out_unlock:
707 spin_unlock(&c->space_lock); 707 spin_unlock(&c->space_lock);
708} 708}
709 709
710void dbg_dump_lprop(const struct ubifs_info *c, const struct ubifs_lprops *lp) 710void ubifs_dump_lprop(const struct ubifs_info *c, const struct ubifs_lprops *lp)
711{ 711{
712 int i, spc, dark = 0, dead = 0; 712 int i, spc, dark = 0, dead = 0;
713 struct rb_node *rb; 713 struct rb_node *rb;
@@ -801,7 +801,7 @@ void dbg_dump_lprop(const struct ubifs_info *c, const struct ubifs_lprops *lp)
801 printk(KERN_CONT ")\n"); 801 printk(KERN_CONT ")\n");
802} 802}
803 803
804void dbg_dump_lprops(struct ubifs_info *c) 804void ubifs_dump_lprops(struct ubifs_info *c)
805{ 805{
806 int lnum, err; 806 int lnum, err;
807 struct ubifs_lprops lp; 807 struct ubifs_lprops lp;
@@ -810,20 +810,20 @@ void dbg_dump_lprops(struct ubifs_info *c)
810 printk(KERN_ERR "(pid %d) start dumping LEB properties\n", 810 printk(KERN_ERR "(pid %d) start dumping LEB properties\n",
811 current->pid); 811 current->pid);
812 ubifs_get_lp_stats(c, &lst); 812 ubifs_get_lp_stats(c, &lst);
813 dbg_dump_lstats(&lst); 813 ubifs_dump_lstats(&lst);
814 814
815 for (lnum = c->main_first; lnum < c->leb_cnt; lnum++) { 815 for (lnum = c->main_first; lnum < c->leb_cnt; lnum++) {
816 err = ubifs_read_one_lp(c, lnum, &lp); 816 err = ubifs_read_one_lp(c, lnum, &lp);
817 if (err) 817 if (err)
818 ubifs_err("cannot read lprops for LEB %d", lnum); 818 ubifs_err("cannot read lprops for LEB %d", lnum);
819 819
820 dbg_dump_lprop(c, &lp); 820 ubifs_dump_lprop(c, &lp);
821 } 821 }
822 printk(KERN_ERR "(pid %d) finish dumping LEB properties\n", 822 printk(KERN_ERR "(pid %d) finish dumping LEB properties\n",
823 current->pid); 823 current->pid);
824} 824}
825 825
826void dbg_dump_lpt_info(struct ubifs_info *c) 826void ubifs_dump_lpt_info(struct ubifs_info *c)
827{ 827{
828 int i; 828 int i;
829 829
@@ -862,8 +862,8 @@ void dbg_dump_lpt_info(struct ubifs_info *c)
862 spin_unlock(&dbg_lock); 862 spin_unlock(&dbg_lock);
863} 863}
864 864
865void dbg_dump_sleb(const struct ubifs_info *c, 865void ubifs_dump_sleb(const struct ubifs_info *c,
866 const struct ubifs_scan_leb *sleb, int offs) 866 const struct ubifs_scan_leb *sleb, int offs)
867{ 867{
868 struct ubifs_scan_node *snod; 868 struct ubifs_scan_node *snod;
869 869
@@ -874,11 +874,11 @@ void dbg_dump_sleb(const struct ubifs_info *c,
874 cond_resched(); 874 cond_resched();
875 printk(KERN_ERR "Dumping node at LEB %d:%d len %d\n", sleb->lnum, 875 printk(KERN_ERR "Dumping node at LEB %d:%d len %d\n", sleb->lnum,
876 snod->offs, snod->len); 876 snod->offs, snod->len);
877 dbg_dump_node(c, snod->node); 877 ubifs_dump_node(c, snod->node);
878 } 878 }
879} 879}
880 880
881void dbg_dump_leb(const struct ubifs_info *c, int lnum) 881void ubifs_dump_leb(const struct ubifs_info *c, int lnum)
882{ 882{
883 struct ubifs_scan_leb *sleb; 883 struct ubifs_scan_leb *sleb;
884 struct ubifs_scan_node *snod; 884 struct ubifs_scan_node *snod;
@@ -909,7 +909,7 @@ void dbg_dump_leb(const struct ubifs_info *c, int lnum)
909 cond_resched(); 909 cond_resched();
910 printk(KERN_ERR "Dumping node at LEB %d:%d len %d\n", lnum, 910 printk(KERN_ERR "Dumping node at LEB %d:%d len %d\n", lnum,
911 snod->offs, snod->len); 911 snod->offs, snod->len);
912 dbg_dump_node(c, snod->node); 912 ubifs_dump_node(c, snod->node);
913 } 913 }
914 914
915 printk(KERN_ERR "(pid %d) finish dumping LEB %d\n", 915 printk(KERN_ERR "(pid %d) finish dumping LEB %d\n",
@@ -921,8 +921,8 @@ out:
921 return; 921 return;
922} 922}
923 923
924void dbg_dump_znode(const struct ubifs_info *c, 924void ubifs_dump_znode(const struct ubifs_info *c,
925 const struct ubifs_znode *znode) 925 const struct ubifs_znode *znode)
926{ 926{
927 int n; 927 int n;
928 const struct ubifs_zbranch *zbr; 928 const struct ubifs_zbranch *zbr;
@@ -965,7 +965,7 @@ void dbg_dump_znode(const struct ubifs_info *c,
965 spin_unlock(&dbg_lock); 965 spin_unlock(&dbg_lock);
966} 966}
967 967
968void dbg_dump_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap, int cat) 968void ubifs_dump_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap, int cat)
969{ 969{
970 int i; 970 int i;
971 971
@@ -981,8 +981,8 @@ void dbg_dump_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap, int cat)
981 printk(KERN_ERR "(pid %d) finish dumping heap\n", current->pid); 981 printk(KERN_ERR "(pid %d) finish dumping heap\n", current->pid);
982} 982}
983 983
984void dbg_dump_pnode(struct ubifs_info *c, struct ubifs_pnode *pnode, 984void ubifs_dump_pnode(struct ubifs_info *c, struct ubifs_pnode *pnode,
985 struct ubifs_nnode *parent, int iip) 985 struct ubifs_nnode *parent, int iip)
986{ 986{
987 int i; 987 int i;
988 988
@@ -999,7 +999,7 @@ void dbg_dump_pnode(struct ubifs_info *c, struct ubifs_pnode *pnode,
999 } 999 }
1000} 1000}
1001 1001
1002void dbg_dump_tnc(struct ubifs_info *c) 1002void ubifs_dump_tnc(struct ubifs_info *c)
1003{ 1003{
1004 struct ubifs_znode *znode; 1004 struct ubifs_znode *znode;
1005 int level; 1005 int level;
@@ -1014,7 +1014,7 @@ void dbg_dump_tnc(struct ubifs_info *c)
1014 level = znode->level; 1014 level = znode->level;
1015 printk(KERN_ERR "== Level %d ==\n", level); 1015 printk(KERN_ERR "== Level %d ==\n", level);
1016 } 1016 }
1017 dbg_dump_znode(c, znode); 1017 ubifs_dump_znode(c, znode);
1018 znode = ubifs_tnc_levelorder_next(c->zroot.znode, znode); 1018 znode = ubifs_tnc_levelorder_next(c->zroot.znode, znode);
1019 } 1019 }
1020 printk(KERN_ERR "(pid %d) finish dumping TNC tree\n", current->pid); 1020 printk(KERN_ERR "(pid %d) finish dumping TNC tree\n", current->pid);
@@ -1023,18 +1023,18 @@ void dbg_dump_tnc(struct ubifs_info *c)
1023static int dump_znode(struct ubifs_info *c, struct ubifs_znode *znode, 1023static int dump_znode(struct ubifs_info *c, struct ubifs_znode *znode,
1024 void *priv) 1024 void *priv)
1025{ 1025{
1026 dbg_dump_znode(c, znode); 1026 ubifs_dump_znode(c, znode);
1027 return 0; 1027 return 0;
1028} 1028}
1029 1029
1030/** 1030/**
1031 * dbg_dump_index - dump the on-flash index. 1031 * ubifs_dump_index - dump the on-flash index.
1032 * @c: UBIFS file-system description object 1032 * @c: UBIFS file-system description object
1033 * 1033 *
1034 * This function dumps whole UBIFS indexing B-tree, unlike 'dbg_dump_tnc()' 1034 * This function dumps whole UBIFS indexing B-tree, unlike 'ubifs_dump_tnc()'
1035 * which dumps only in-memory znodes and does not read znodes which from flash. 1035 * which dumps only in-memory znodes and does not read znodes which from flash.
1036 */ 1036 */
1037void dbg_dump_index(struct ubifs_info *c) 1037void ubifs_dump_index(struct ubifs_info *c)
1038{ 1038{
1039 dbg_walk_index(c, NULL, dump_znode, NULL); 1039 dbg_walk_index(c, NULL, dump_znode, NULL);
1040} 1040}
@@ -1120,15 +1120,15 @@ int dbg_check_space_info(struct ubifs_info *c)
1120 1120
1121out: 1121out:
1122 ubifs_msg("saved lprops statistics dump"); 1122 ubifs_msg("saved lprops statistics dump");
1123 dbg_dump_lstats(&d->saved_lst); 1123 ubifs_dump_lstats(&d->saved_lst);
1124 ubifs_msg("saved budgeting info dump"); 1124 ubifs_msg("saved budgeting info dump");
1125 dbg_dump_budg(c, &d->saved_bi); 1125 ubifs_dump_budg(c, &d->saved_bi);
1126 ubifs_msg("saved idx_gc_cnt %d", d->saved_idx_gc_cnt); 1126 ubifs_msg("saved idx_gc_cnt %d", d->saved_idx_gc_cnt);
1127 ubifs_msg("current lprops statistics dump"); 1127 ubifs_msg("current lprops statistics dump");
1128 ubifs_get_lp_stats(c, &lst); 1128 ubifs_get_lp_stats(c, &lst);
1129 dbg_dump_lstats(&lst); 1129 ubifs_dump_lstats(&lst);
1130 ubifs_msg("current budgeting info dump"); 1130 ubifs_msg("current budgeting info dump");
1131 dbg_dump_budg(c, &c->bi); 1131 ubifs_dump_budg(c, &c->bi);
1132 dump_stack(); 1132 dump_stack();
1133 return -EINVAL; 1133 return -EINVAL;
1134} 1134}
@@ -1223,14 +1223,14 @@ int dbg_check_dir(struct ubifs_info *c, const struct inode *dir)
1223 "but calculated size is %llu", dir->i_ino, 1223 "but calculated size is %llu", dir->i_ino,
1224 (unsigned long long)i_size_read(dir), 1224 (unsigned long long)i_size_read(dir),
1225 (unsigned long long)size); 1225 (unsigned long long)size);
1226 dbg_dump_inode(c, dir); 1226 ubifs_dump_inode(c, dir);
1227 dump_stack(); 1227 dump_stack();
1228 return -EINVAL; 1228 return -EINVAL;
1229 } 1229 }
1230 if (dir->i_nlink != nlink) { 1230 if (dir->i_nlink != nlink) {
1231 ubifs_err("directory inode %lu has nlink %u, but calculated " 1231 ubifs_err("directory inode %lu has nlink %u, but calculated "
1232 "nlink is %u", dir->i_ino, dir->i_nlink, nlink); 1232 "nlink is %u", dir->i_ino, dir->i_nlink, nlink);
1233 dbg_dump_inode(c, dir); 1233 ubifs_dump_inode(c, dir);
1234 dump_stack(); 1234 dump_stack();
1235 return -EINVAL; 1235 return -EINVAL;
1236 } 1236 }
@@ -1293,7 +1293,7 @@ static int dbg_check_key_order(struct ubifs_info *c, struct ubifs_zbranch *zbr1,
1293 dbg_err("but it should have key %s according to tnc", 1293 dbg_err("but it should have key %s according to tnc",
1294 dbg_snprintf_key(c, &zbr1->key, key_buf, 1294 dbg_snprintf_key(c, &zbr1->key, key_buf,
1295 DBG_KEY_BUF_LEN)); 1295 DBG_KEY_BUF_LEN));
1296 dbg_dump_node(c, dent1); 1296 ubifs_dump_node(c, dent1);
1297 goto out_free; 1297 goto out_free;
1298 } 1298 }
1299 1299
@@ -1305,7 +1305,7 @@ static int dbg_check_key_order(struct ubifs_info *c, struct ubifs_zbranch *zbr1,
1305 dbg_err("but it should have key %s according to tnc", 1305 dbg_err("but it should have key %s according to tnc",
1306 dbg_snprintf_key(c, &zbr2->key, key_buf, 1306 dbg_snprintf_key(c, &zbr2->key, key_buf,
1307 DBG_KEY_BUF_LEN)); 1307 DBG_KEY_BUF_LEN));
1308 dbg_dump_node(c, dent2); 1308 ubifs_dump_node(c, dent2);
1309 goto out_free; 1309 goto out_free;
1310 } 1310 }
1311 1311
@@ -1324,9 +1324,9 @@ static int dbg_check_key_order(struct ubifs_info *c, struct ubifs_zbranch *zbr1,
1324 dbg_snprintf_key(c, &key, key_buf, DBG_KEY_BUF_LEN)); 1324 dbg_snprintf_key(c, &key, key_buf, DBG_KEY_BUF_LEN));
1325 1325
1326 ubifs_msg("first node at %d:%d\n", zbr1->lnum, zbr1->offs); 1326 ubifs_msg("first node at %d:%d\n", zbr1->lnum, zbr1->offs);
1327 dbg_dump_node(c, dent1); 1327 ubifs_dump_node(c, dent1);
1328 ubifs_msg("second node at %d:%d\n", zbr2->lnum, zbr2->offs); 1328 ubifs_msg("second node at %d:%d\n", zbr2->lnum, zbr2->offs);
1329 dbg_dump_node(c, dent2); 1329 ubifs_dump_node(c, dent2);
1330 1330
1331out_free: 1331out_free:
1332 kfree(dent2); 1332 kfree(dent2);
@@ -1529,10 +1529,10 @@ static int dbg_check_znode(struct ubifs_info *c, struct ubifs_zbranch *zbr)
1529out: 1529out:
1530 ubifs_err("failed, error %d", err); 1530 ubifs_err("failed, error %d", err);
1531 ubifs_msg("dump of the znode"); 1531 ubifs_msg("dump of the znode");
1532 dbg_dump_znode(c, znode); 1532 ubifs_dump_znode(c, znode);
1533 if (zp) { 1533 if (zp) {
1534 ubifs_msg("dump of the parent znode"); 1534 ubifs_msg("dump of the parent znode");
1535 dbg_dump_znode(c, zp); 1535 ubifs_dump_znode(c, zp);
1536 } 1536 }
1537 dump_stack(); 1537 dump_stack();
1538 return -EINVAL; 1538 return -EINVAL;
@@ -1599,9 +1599,9 @@ int dbg_check_tnc(struct ubifs_info *c, int extra)
1599 return err; 1599 return err;
1600 if (err) { 1600 if (err) {
1601 ubifs_msg("first znode"); 1601 ubifs_msg("first znode");
1602 dbg_dump_znode(c, prev); 1602 ubifs_dump_znode(c, prev);
1603 ubifs_msg("second znode"); 1603 ubifs_msg("second znode");
1604 dbg_dump_znode(c, znode); 1604 ubifs_dump_znode(c, znode);
1605 return -EINVAL; 1605 return -EINVAL;
1606 } 1606 }
1607 } 1607 }
@@ -1690,7 +1690,7 @@ int dbg_walk_index(struct ubifs_info *c, dbg_leaf_callback leaf_cb,
1690 if (err) { 1690 if (err) {
1691 ubifs_err("znode checking function returned " 1691 ubifs_err("znode checking function returned "
1692 "error %d", err); 1692 "error %d", err);
1693 dbg_dump_znode(c, znode); 1693 ubifs_dump_znode(c, znode);
1694 goto out_dump; 1694 goto out_dump;
1695 } 1695 }
1696 } 1696 }
@@ -1758,7 +1758,7 @@ out_dump:
1758 else 1758 else
1759 zbr = &c->zroot; 1759 zbr = &c->zroot;
1760 ubifs_msg("dump of znode at LEB %d:%d", zbr->lnum, zbr->offs); 1760 ubifs_msg("dump of znode at LEB %d:%d", zbr->lnum, zbr->offs);
1761 dbg_dump_znode(c, znode); 1761 ubifs_dump_znode(c, znode);
1762out_unlock: 1762out_unlock:
1763 mutex_unlock(&c->tnc_mutex); 1763 mutex_unlock(&c->tnc_mutex);
1764 return err; 1764 return err;
@@ -2194,7 +2194,7 @@ out:
2194 2194
2195out_dump: 2195out_dump:
2196 ubifs_msg("dump of node at LEB %d:%d", zbr->lnum, zbr->offs); 2196 ubifs_msg("dump of node at LEB %d:%d", zbr->lnum, zbr->offs);
2197 dbg_dump_node(c, node); 2197 ubifs_dump_node(c, node);
2198out_free: 2198out_free:
2199 kfree(node); 2199 kfree(node);
2200 return err; 2200 return err;
@@ -2352,7 +2352,7 @@ out_dump:
2352 2352
2353 ubifs_msg("dump of the inode %lu sitting in LEB %d:%d", 2353 ubifs_msg("dump of the inode %lu sitting in LEB %d:%d",
2354 (unsigned long)fscki->inum, zbr->lnum, zbr->offs); 2354 (unsigned long)fscki->inum, zbr->lnum, zbr->offs);
2355 dbg_dump_node(c, ino); 2355 ubifs_dump_node(c, ino);
2356 kfree(ino); 2356 kfree(ino);
2357 return -EINVAL; 2357 return -EINVAL;
2358} 2358}
@@ -2423,12 +2423,12 @@ int dbg_check_data_nodes_order(struct ubifs_info *c, struct list_head *head)
2423 2423
2424 if (sa->type != UBIFS_DATA_NODE) { 2424 if (sa->type != UBIFS_DATA_NODE) {
2425 ubifs_err("bad node type %d", sa->type); 2425 ubifs_err("bad node type %d", sa->type);
2426 dbg_dump_node(c, sa->node); 2426 ubifs_dump_node(c, sa->node);
2427 return -EINVAL; 2427 return -EINVAL;
2428 } 2428 }
2429 if (sb->type != UBIFS_DATA_NODE) { 2429 if (sb->type != UBIFS_DATA_NODE) {
2430 ubifs_err("bad node type %d", sb->type); 2430 ubifs_err("bad node type %d", sb->type);
2431 dbg_dump_node(c, sb->node); 2431 ubifs_dump_node(c, sb->node);
2432 return -EINVAL; 2432 return -EINVAL;
2433 } 2433 }
2434 2434
@@ -2459,8 +2459,8 @@ int dbg_check_data_nodes_order(struct ubifs_info *c, struct list_head *head)
2459 return 0; 2459 return 0;
2460 2460
2461error_dump: 2461error_dump:
2462 dbg_dump_node(c, sa->node); 2462 ubifs_dump_node(c, sa->node);
2463 dbg_dump_node(c, sb->node); 2463 ubifs_dump_node(c, sb->node);
2464 return -EINVAL; 2464 return -EINVAL;
2465} 2465}
2466 2466
@@ -2491,13 +2491,13 @@ int dbg_check_nondata_nodes_order(struct ubifs_info *c, struct list_head *head)
2491 if (sa->type != UBIFS_INO_NODE && sa->type != UBIFS_DENT_NODE && 2491 if (sa->type != UBIFS_INO_NODE && sa->type != UBIFS_DENT_NODE &&
2492 sa->type != UBIFS_XENT_NODE) { 2492 sa->type != UBIFS_XENT_NODE) {
2493 ubifs_err("bad node type %d", sa->type); 2493 ubifs_err("bad node type %d", sa->type);
2494 dbg_dump_node(c, sa->node); 2494 ubifs_dump_node(c, sa->node);
2495 return -EINVAL; 2495 return -EINVAL;
2496 } 2496 }
2497 if (sa->type != UBIFS_INO_NODE && sa->type != UBIFS_DENT_NODE && 2497 if (sa->type != UBIFS_INO_NODE && sa->type != UBIFS_DENT_NODE &&
2498 sa->type != UBIFS_XENT_NODE) { 2498 sa->type != UBIFS_XENT_NODE) {
2499 ubifs_err("bad node type %d", sb->type); 2499 ubifs_err("bad node type %d", sb->type);
2500 dbg_dump_node(c, sb->node); 2500 ubifs_dump_node(c, sb->node);
2501 return -EINVAL; 2501 return -EINVAL;
2502 } 2502 }
2503 2503
@@ -2547,9 +2547,9 @@ int dbg_check_nondata_nodes_order(struct ubifs_info *c, struct list_head *head)
2547 2547
2548error_dump: 2548error_dump:
2549 ubifs_msg("dumping first node"); 2549 ubifs_msg("dumping first node");
2550 dbg_dump_node(c, sa->node); 2550 ubifs_dump_node(c, sa->node);
2551 ubifs_msg("dumping second node"); 2551 ubifs_msg("dumping second node");
2552 dbg_dump_node(c, sb->node); 2552 ubifs_dump_node(c, sb->node);
2553 return -EINVAL; 2553 return -EINVAL;
2554 return 0; 2554 return 0;
2555} 2555}
@@ -2857,16 +2857,16 @@ static ssize_t dfs_file_write(struct file *file, const char __user *u,
2857 * 'ubifs-debug' file-system instead. 2857 * 'ubifs-debug' file-system instead.
2858 */ 2858 */
2859 if (file->f_path.dentry == d->dfs_dump_lprops) { 2859 if (file->f_path.dentry == d->dfs_dump_lprops) {
2860 dbg_dump_lprops(c); 2860 ubifs_dump_lprops(c);
2861 return count; 2861 return count;
2862 } 2862 }
2863 if (file->f_path.dentry == d->dfs_dump_budg) { 2863 if (file->f_path.dentry == d->dfs_dump_budg) {
2864 dbg_dump_budg(c, &c->bi); 2864 ubifs_dump_budg(c, &c->bi);
2865 return count; 2865 return count;
2866 } 2866 }
2867 if (file->f_path.dentry == d->dfs_dump_tnc) { 2867 if (file->f_path.dentry == d->dfs_dump_tnc) {
2868 mutex_lock(&c->tnc_mutex); 2868 mutex_lock(&c->tnc_mutex);
2869 dbg_dump_tnc(c); 2869 ubifs_dump_tnc(c);
2870 mutex_unlock(&c->tnc_mutex); 2870 mutex_unlock(&c->tnc_mutex);
2871 return count; 2871 return count;
2872 } 2872 }
diff --git a/fs/ubifs/debug.h b/fs/ubifs/debug.h
index 6e5d345a0f7e..f89836934871 100644
--- a/fs/ubifs/debug.h
+++ b/fs/ubifs/debug.h
@@ -255,27 +255,27 @@ const char *dbg_get_key_dump(const struct ubifs_info *c,
255 const union ubifs_key *key); 255 const union ubifs_key *key);
256const char *dbg_snprintf_key(const struct ubifs_info *c, 256const char *dbg_snprintf_key(const struct ubifs_info *c,
257 const union ubifs_key *key, char *buffer, int len); 257 const union ubifs_key *key, char *buffer, int len);
258void dbg_dump_inode(struct ubifs_info *c, const struct inode *inode); 258void ubifs_dump_inode(struct ubifs_info *c, const struct inode *inode);
259void dbg_dump_node(const struct ubifs_info *c, const void *node); 259void ubifs_dump_node(const struct ubifs_info *c, const void *node);
260void dbg_dump_lpt_node(const struct ubifs_info *c, void *node, int lnum, 260void ubifs_dump_budget_req(const struct ubifs_budget_req *req);
261 int offs); 261void ubifs_dump_lstats(const struct ubifs_lp_stats *lst);
262void dbg_dump_budget_req(const struct ubifs_budget_req *req); 262void ubifs_dump_budg(struct ubifs_info *c, const struct ubifs_budg_info *bi);
263void dbg_dump_lstats(const struct ubifs_lp_stats *lst); 263void ubifs_dump_lprop(const struct ubifs_info *c,
264void dbg_dump_budg(struct ubifs_info *c, const struct ubifs_budg_info *bi); 264 const struct ubifs_lprops *lp);
265void dbg_dump_lprop(const struct ubifs_info *c, const struct ubifs_lprops *lp); 265void ubifs_dump_lprops(struct ubifs_info *c);
266void dbg_dump_lprops(struct ubifs_info *c); 266void ubifs_dump_lpt_info(struct ubifs_info *c);
267void dbg_dump_lpt_info(struct ubifs_info *c); 267void ubifs_dump_leb(const struct ubifs_info *c, int lnum);
268void dbg_dump_leb(const struct ubifs_info *c, int lnum); 268void ubifs_dump_sleb(const struct ubifs_info *c,
269void dbg_dump_sleb(const struct ubifs_info *c, 269 const struct ubifs_scan_leb *sleb, int offs);
270 const struct ubifs_scan_leb *sleb, int offs); 270void ubifs_dump_znode(const struct ubifs_info *c,
271void dbg_dump_znode(const struct ubifs_info *c, 271 const struct ubifs_znode *znode);
272 const struct ubifs_znode *znode); 272void ubifs_dump_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap,
273void dbg_dump_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap, int cat); 273 int cat);
274void dbg_dump_pnode(struct ubifs_info *c, struct ubifs_pnode *pnode, 274void ubifs_dump_pnode(struct ubifs_info *c, struct ubifs_pnode *pnode,
275 struct ubifs_nnode *parent, int iip); 275 struct ubifs_nnode *parent, int iip);
276void dbg_dump_tnc(struct ubifs_info *c); 276void ubifs_dump_tnc(struct ubifs_info *c);
277void dbg_dump_index(struct ubifs_info *c); 277void ubifs_dump_index(struct ubifs_info *c);
278void dbg_dump_lpt_lebs(const struct ubifs_info *c); 278void ubifs_dump_lpt_lebs(const struct ubifs_info *c);
279 279
280int dbg_walk_index(struct ubifs_info *c, dbg_leaf_callback leaf_cb, 280int dbg_walk_index(struct ubifs_info *c, dbg_leaf_callback leaf_cb,
281 dbg_znode_callback znode_cb, void *priv); 281 dbg_znode_callback znode_cb, void *priv);
@@ -371,42 +371,39 @@ static inline const char *
371dbg_snprintf_key(const struct ubifs_info *c, 371dbg_snprintf_key(const struct ubifs_info *c,
372 const union ubifs_key *key, char *buffer, 372 const union ubifs_key *key, char *buffer,
373 int len) { return ""; } 373 int len) { return ""; }
374static inline void dbg_dump_inode(struct ubifs_info *c, 374static inline void ubifs_dump_inode(struct ubifs_info *c,
375 const struct inode *inode) { return; } 375 const struct inode *inode) { return; }
376static inline void dbg_dump_node(const struct ubifs_info *c, 376static inline void ubifs_dump_node(const struct ubifs_info *c,
377 const void *node) { return; } 377 const void *node) { return; }
378static inline void dbg_dump_lpt_node(const struct ubifs_info *c,
379 void *node, int lnum,
380 int offs) { return; }
381static inline void 378static inline void
382dbg_dump_budget_req(const struct ubifs_budget_req *req) { return; } 379ubifs_dump_budget_req(const struct ubifs_budget_req *req) { return; }
383static inline void 380static inline void
384dbg_dump_lstats(const struct ubifs_lp_stats *lst) { return; } 381ubifs_dump_lstats(const struct ubifs_lp_stats *lst) { return; }
385static inline void 382static inline void
386dbg_dump_budg(struct ubifs_info *c, 383ubifs_dump_budg(struct ubifs_info *c,
387 const struct ubifs_budg_info *bi) { return; } 384 const struct ubifs_budg_info *bi) { return; }
388static inline void dbg_dump_lprop(const struct ubifs_info *c, 385static inline void ubifs_dump_lprop(const struct ubifs_info *c,
389 const struct ubifs_lprops *lp) { return; } 386 const struct ubifs_lprops *lp){ return; }
390static inline void dbg_dump_lprops(struct ubifs_info *c) { return; } 387static inline void ubifs_dump_lprops(struct ubifs_info *c) { return; }
391static inline void dbg_dump_lpt_info(struct ubifs_info *c) { return; } 388static inline void ubifs_dump_lpt_info(struct ubifs_info *c) { return; }
392static inline void dbg_dump_leb(const struct ubifs_info *c, 389static inline void ubifs_dump_leb(const struct ubifs_info *c,
393 int lnum) { return; } 390 int lnum) { return; }
394static inline void 391static inline void
395dbg_dump_sleb(const struct ubifs_info *c, 392ubifs_dump_sleb(const struct ubifs_info *c,
396 const struct ubifs_scan_leb *sleb, int offs) { return; } 393 const struct ubifs_scan_leb *sleb, int offs) { return; }
397static inline void 394static inline void
398dbg_dump_znode(const struct ubifs_info *c, 395ubifs_dump_znode(const struct ubifs_info *c,
399 const struct ubifs_znode *znode) { return; } 396 const struct ubifs_znode *znode) { return; }
400static inline void dbg_dump_heap(struct ubifs_info *c, 397static inline void ubifs_dump_heap(struct ubifs_info *c,
401 struct ubifs_lpt_heap *heap, 398 struct ubifs_lpt_heap *heap,
402 int cat) { return; } 399 int cat) { return; }
403static inline void dbg_dump_pnode(struct ubifs_info *c, 400static inline void ubifs_dump_pnode(struct ubifs_info *c,
404 struct ubifs_pnode *pnode, 401 struct ubifs_pnode *pnode,
405 struct ubifs_nnode *parent, 402 struct ubifs_nnode *parent,
406 int iip) { return; } 403 int iip) { return; }
407static inline void dbg_dump_tnc(struct ubifs_info *c) { return; } 404static inline void ubifs_dump_tnc(struct ubifs_info *c) { return; }
408static inline void dbg_dump_index(struct ubifs_info *c) { return; } 405static inline void ubifs_dump_index(struct ubifs_info *c) { return; }
409static inline void dbg_dump_lpt_lebs(const struct ubifs_info *c) { return; } 406static inline void ubifs_dump_lpt_lebs(const struct ubifs_info *c){ return; }
410 407
411static inline int dbg_walk_index(struct ubifs_info *c, 408static inline int dbg_walk_index(struct ubifs_info *c,
412 dbg_leaf_callback leaf_cb, 409 dbg_leaf_callback leaf_cb,
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 0fe640cc872a..35389ca2d267 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -97,7 +97,7 @@ static int read_block(struct inode *inode, void *addr, unsigned int block,
97dump: 97dump:
98 ubifs_err("bad data node (block %u, inode %lu)", 98 ubifs_err("bad data node (block %u, inode %lu)",
99 block, inode->i_ino); 99 block, inode->i_ino);
100 dbg_dump_node(c, dn); 100 ubifs_dump_node(c, dn);
101 return -EINVAL; 101 return -EINVAL;
102} 102}
103 103
diff --git a/fs/ubifs/io.c b/fs/ubifs/io.c
index 16d4065da7d6..21f0835d78c9 100644
--- a/fs/ubifs/io.c
+++ b/fs/ubifs/io.c
@@ -294,7 +294,7 @@ out_len:
294out: 294out:
295 if (!quiet) { 295 if (!quiet) {
296 ubifs_err("bad node at LEB %d:%d", lnum, offs); 296 ubifs_err("bad node at LEB %d:%d", lnum, offs);
297 dbg_dump_node(c, buf); 297 ubifs_dump_node(c, buf);
298 dump_stack(); 298 dump_stack();
299 } 299 }
300 return err; 300 return err;
@@ -841,9 +841,9 @@ exit:
841out: 841out:
842 ubifs_err("cannot write %d bytes to LEB %d:%d, error %d", 842 ubifs_err("cannot write %d bytes to LEB %d:%d, error %d",
843 len, wbuf->lnum, wbuf->offs, err); 843 len, wbuf->lnum, wbuf->offs, err);
844 dbg_dump_node(c, buf); 844 ubifs_dump_node(c, buf);
845 dump_stack(); 845 dump_stack();
846 dbg_dump_leb(c, wbuf->lnum); 846 ubifs_dump_leb(c, wbuf->lnum);
847 return err; 847 return err;
848} 848}
849 849
@@ -881,7 +881,7 @@ int ubifs_write_node(struct ubifs_info *c, void *buf, int len, int lnum,
881 ubifs_prepare_node(c, buf, len, 1); 881 ubifs_prepare_node(c, buf, len, 1);
882 err = ubifs_leb_write(c, lnum, buf, offs, buf_len, dtype); 882 err = ubifs_leb_write(c, lnum, buf, offs, buf_len, dtype);
883 if (err) 883 if (err)
884 dbg_dump_node(c, buf); 884 ubifs_dump_node(c, buf);
885 885
886 return err; 886 return err;
887} 887}
@@ -960,7 +960,7 @@ int ubifs_read_node_wbuf(struct ubifs_wbuf *wbuf, void *buf, int type, int len,
960 960
961out: 961out:
962 ubifs_err("bad node at LEB %d:%d", lnum, offs); 962 ubifs_err("bad node at LEB %d:%d", lnum, offs);
963 dbg_dump_node(c, buf); 963 ubifs_dump_node(c, buf);
964 dump_stack(); 964 dump_stack();
965 return -EINVAL; 965 return -EINVAL;
966} 966}
@@ -1017,7 +1017,7 @@ int ubifs_read_node(const struct ubifs_info *c, void *buf, int type, int len,
1017out: 1017out:
1018 ubifs_err("bad node at LEB %d:%d, LEB mapping status %d", lnum, offs, 1018 ubifs_err("bad node at LEB %d:%d, LEB mapping status %d", lnum, offs,
1019 ubi_is_mapped(c->ubi, lnum)); 1019 ubi_is_mapped(c->ubi, lnum));
1020 dbg_dump_node(c, buf); 1020 ubifs_dump_node(c, buf);
1021 dump_stack(); 1021 dump_stack();
1022 return -EINVAL; 1022 return -EINVAL;
1023} 1023}
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index bad8b5fe47c7..61cd8535ffd6 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -386,8 +386,8 @@ out:
386 /* This are some budgeting problems, print useful information */ 386 /* This are some budgeting problems, print useful information */
387 down_write(&c->commit_sem); 387 down_write(&c->commit_sem);
388 dump_stack(); 388 dump_stack();
389 dbg_dump_budg(c, &c->bi); 389 ubifs_dump_budg(c, &c->bi);
390 dbg_dump_lprops(c); 390 ubifs_dump_lprops(c);
391 cmt_retries = dbg_check_lprops(c); 391 cmt_retries = dbg_check_lprops(c);
392 up_write(&c->commit_sem); 392 up_write(&c->commit_sem);
393 } 393 }
diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c
index 2e4bc27fb02a..0cf7a18e174c 100644
--- a/fs/ubifs/lprops.c
+++ b/fs/ubifs/lprops.c
@@ -1002,7 +1002,7 @@ out:
1002 if (err) { 1002 if (err) {
1003 dbg_msg("failed cat %d hpos %d err %d", cat, i, err); 1003 dbg_msg("failed cat %d hpos %d err %d", cat, i, err);
1004 dump_stack(); 1004 dump_stack();
1005 dbg_dump_heap(c, heap, cat); 1005 ubifs_dump_heap(c, heap, cat);
1006 } 1006 }
1007} 1007}
1008 1008
@@ -1109,8 +1109,8 @@ static int scan_check_cb(struct ubifs_info *c,
1109 if (IS_ERR(sleb)) { 1109 if (IS_ERR(sleb)) {
1110 ret = PTR_ERR(sleb); 1110 ret = PTR_ERR(sleb);
1111 if (ret == -EUCLEAN) { 1111 if (ret == -EUCLEAN) {
1112 dbg_dump_lprops(c); 1112 ubifs_dump_lprops(c);
1113 dbg_dump_budg(c, &c->bi); 1113 ubifs_dump_budg(c, &c->bi);
1114 } 1114 }
1115 goto out; 1115 goto out;
1116 } 1116 }
@@ -1237,7 +1237,7 @@ out_print:
1237 ubifs_err("bad accounting of LEB %d: free %d, dirty %d flags %#x, " 1237 ubifs_err("bad accounting of LEB %d: free %d, dirty %d flags %#x, "
1238 "should be free %d, dirty %d", 1238 "should be free %d, dirty %d",
1239 lnum, lp->free, lp->dirty, lp->flags, free, dirty); 1239 lnum, lp->free, lp->dirty, lp->flags, free, dirty);
1240 dbg_dump_leb(c, lnum); 1240 ubifs_dump_leb(c, lnum);
1241out_destroy: 1241out_destroy:
1242 ubifs_scan_destroy(sleb); 1242 ubifs_scan_destroy(sleb);
1243 ret = -EINVAL; 1243 ret = -EINVAL;
diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c
index 4b62998697df..b6db389654b0 100644
--- a/fs/ubifs/lpt.c
+++ b/fs/ubifs/lpt.c
@@ -1312,7 +1312,7 @@ static int read_pnode(struct ubifs_info *c, struct ubifs_nnode *parent, int iip)
1312 1312
1313out: 1313out:
1314 ubifs_err("error %d reading pnode at %d:%d", err, lnum, offs); 1314 ubifs_err("error %d reading pnode at %d:%d", err, lnum, offs);
1315 dbg_dump_pnode(c, pnode, parent, iip); 1315 ubifs_dump_pnode(c, pnode, parent, iip);
1316 dump_stack(); 1316 dump_stack();
1317 dbg_msg("calc num: %d", calc_pnode_num_from_parent(c, parent, iip)); 1317 dbg_msg("calc num: %d", calc_pnode_num_from_parent(c, parent, iip));
1318 kfree(pnode); 1318 kfree(pnode);
diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
index cddd6bd214f4..8294d5af87b3 100644
--- a/fs/ubifs/lpt_commit.c
+++ b/fs/ubifs/lpt_commit.c
@@ -327,8 +327,8 @@ no_space:
327 ubifs_err("LPT out of space"); 327 ubifs_err("LPT out of space");
328 dbg_err("LPT out of space at LEB %d:%d needing %d, done_ltab %d, " 328 dbg_err("LPT out of space at LEB %d:%d needing %d, done_ltab %d, "
329 "done_lsave %d", lnum, offs, len, done_ltab, done_lsave); 329 "done_lsave %d", lnum, offs, len, done_ltab, done_lsave);
330 dbg_dump_lpt_info(c); 330 ubifs_dump_lpt_info(c);
331 dbg_dump_lpt_lebs(c); 331 ubifs_dump_lpt_lebs(c);
332 dump_stack(); 332 dump_stack();
333 return err; 333 return err;
334} 334}
@@ -555,8 +555,8 @@ no_space:
555 ubifs_err("LPT out of space mismatch"); 555 ubifs_err("LPT out of space mismatch");
556 dbg_err("LPT out of space mismatch at LEB %d:%d needing %d, done_ltab " 556 dbg_err("LPT out of space mismatch at LEB %d:%d needing %d, done_ltab "
557 "%d, done_lsave %d", lnum, offs, len, done_ltab, done_lsave); 557 "%d, done_lsave %d", lnum, offs, len, done_ltab, done_lsave);
558 dbg_dump_lpt_info(c); 558 ubifs_dump_lpt_info(c);
559 dbg_dump_lpt_lebs(c); 559 ubifs_dump_lpt_lebs(c);
560 dump_stack(); 560 dump_stack();
561 return err; 561 return err;
562} 562}
@@ -1769,8 +1769,8 @@ int dbg_chk_lpt_free_spc(struct ubifs_info *c)
1769 if (free < c->lpt_sz) { 1769 if (free < c->lpt_sz) {
1770 dbg_err("LPT space error: free %lld lpt_sz %lld", 1770 dbg_err("LPT space error: free %lld lpt_sz %lld",
1771 free, c->lpt_sz); 1771 free, c->lpt_sz);
1772 dbg_dump_lpt_info(c); 1772 ubifs_dump_lpt_info(c);
1773 dbg_dump_lpt_lebs(c); 1773 ubifs_dump_lpt_lebs(c);
1774 dump_stack(); 1774 dump_stack();
1775 return -EINVAL; 1775 return -EINVAL;
1776 } 1776 }
@@ -1860,8 +1860,8 @@ int dbg_chk_lpt_sz(struct ubifs_info *c, int action, int len)
1860 err = -EINVAL; 1860 err = -EINVAL;
1861 } 1861 }
1862 if (err) { 1862 if (err) {
1863 dbg_dump_lpt_info(c); 1863 ubifs_dump_lpt_info(c);
1864 dbg_dump_lpt_lebs(c); 1864 ubifs_dump_lpt_lebs(c);
1865 dump_stack(); 1865 dump_stack();
1866 } 1866 }
1867 d->chk_lpt_sz2 = d->chk_lpt_sz; 1867 d->chk_lpt_sz2 = d->chk_lpt_sz;
@@ -1880,7 +1880,7 @@ int dbg_chk_lpt_sz(struct ubifs_info *c, int action, int len)
1880} 1880}
1881 1881
1882/** 1882/**
1883 * dbg_dump_lpt_leb - dump an LPT LEB. 1883 * ubifs_dump_lpt_leb - dump an LPT LEB.
1884 * @c: UBIFS file-system description object 1884 * @c: UBIFS file-system description object
1885 * @lnum: LEB number to dump 1885 * @lnum: LEB number to dump
1886 * 1886 *
@@ -1986,13 +1986,13 @@ out:
1986} 1986}
1987 1987
1988/** 1988/**
1989 * dbg_dump_lpt_lebs - dump LPT lebs. 1989 * ubifs_dump_lpt_lebs - dump LPT lebs.
1990 * @c: UBIFS file-system description object 1990 * @c: UBIFS file-system description object
1991 * 1991 *
1992 * This function dumps all LPT LEBs. The caller has to make sure the LPT is 1992 * This function dumps all LPT LEBs. The caller has to make sure the LPT is
1993 * locked. 1993 * locked.
1994 */ 1994 */
1995void dbg_dump_lpt_lebs(const struct ubifs_info *c) 1995void ubifs_dump_lpt_lebs(const struct ubifs_info *c)
1996{ 1996{
1997 int i; 1997 int i;
1998 1998
diff --git a/fs/ubifs/master.c b/fs/ubifs/master.c
index 278c2382e8c2..9fc282984f94 100644
--- a/fs/ubifs/master.c
+++ b/fs/ubifs/master.c
@@ -241,7 +241,7 @@ static int validate_master(const struct ubifs_info *c)
241 241
242out: 242out:
243 ubifs_err("bad master node at offset %d error %d", c->mst_offs, err); 243 ubifs_err("bad master node at offset %d error %d", c->mst_offs, err);
244 dbg_dump_node(c, c->mst_node); 244 ubifs_dump_node(c, c->mst_node);
245 return -EINVAL; 245 return -EINVAL;
246} 246}
247 247
@@ -317,7 +317,7 @@ int ubifs_read_master(struct ubifs_info *c)
317 if (c->leb_cnt < old_leb_cnt || 317 if (c->leb_cnt < old_leb_cnt ||
318 c->leb_cnt < UBIFS_MIN_LEB_CNT) { 318 c->leb_cnt < UBIFS_MIN_LEB_CNT) {
319 ubifs_err("bad leb_cnt on master node"); 319 ubifs_err("bad leb_cnt on master node");
320 dbg_dump_node(c, c->mst_node); 320 ubifs_dump_node(c, c->mst_node);
321 return -EINVAL; 321 return -EINVAL;
322 } 322 }
323 323
diff --git a/fs/ubifs/orphan.c b/fs/ubifs/orphan.c
index be18de8f4efc..48ac7212e78b 100644
--- a/fs/ubifs/orphan.c
+++ b/fs/ubifs/orphan.c
@@ -569,7 +569,7 @@ static int do_kill_orphans(struct ubifs_info *c, struct ubifs_scan_leb *sleb,
569 if (snod->type != UBIFS_ORPH_NODE) { 569 if (snod->type != UBIFS_ORPH_NODE) {
570 ubifs_err("invalid node type %d in orphan area at " 570 ubifs_err("invalid node type %d in orphan area at "
571 "%d:%d", snod->type, sleb->lnum, snod->offs); 571 "%d:%d", snod->type, sleb->lnum, snod->offs);
572 dbg_dump_node(c, snod->node); 572 ubifs_dump_node(c, snod->node);
573 return -EINVAL; 573 return -EINVAL;
574 } 574 }
575 575
@@ -597,7 +597,7 @@ static int do_kill_orphans(struct ubifs_info *c, struct ubifs_scan_leb *sleb,
597 ubifs_err("out of order commit number %llu in " 597 ubifs_err("out of order commit number %llu in "
598 "orphan node at %d:%d", 598 "orphan node at %d:%d",
599 cmt_no, sleb->lnum, snod->offs); 599 cmt_no, sleb->lnum, snod->offs);
600 dbg_dump_node(c, snod->node); 600 ubifs_dump_node(c, snod->node);
601 return -EINVAL; 601 return -EINVAL;
602 } 602 }
603 dbg_rcvry("out of date LEB %d", sleb->lnum); 603 dbg_rcvry("out of date LEB %d", sleb->lnum);
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 2a935b317232..bbeab617960b 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -363,11 +363,11 @@ out_free:
363 ubifs_err("failed to recover master node"); 363 ubifs_err("failed to recover master node");
364 if (mst1) { 364 if (mst1) {
365 dbg_err("dumping first master node"); 365 dbg_err("dumping first master node");
366 dbg_dump_node(c, mst1); 366 ubifs_dump_node(c, mst1);
367 } 367 }
368 if (mst2) { 368 if (mst2) {
369 dbg_err("dumping second master node"); 369 dbg_err("dumping second master node");
370 dbg_dump_node(c, mst2); 370 ubifs_dump_node(c, mst2);
371 } 371 }
372 vfree(buf2); 372 vfree(buf2);
373 vfree(buf1); 373 vfree(buf1);
@@ -1139,8 +1139,8 @@ static int grab_empty_leb(struct ubifs_info *c)
1139 lnum = ubifs_find_free_leb_for_idx(c); 1139 lnum = ubifs_find_free_leb_for_idx(c);
1140 if (lnum < 0) { 1140 if (lnum < 0) {
1141 dbg_err("could not find an empty LEB"); 1141 dbg_err("could not find an empty LEB");
1142 dbg_dump_lprops(c); 1142 ubifs_dump_lprops(c);
1143 dbg_dump_budg(c, &c->bi); 1143 ubifs_dump_budg(c, &c->bi);
1144 return lnum; 1144 return lnum;
1145 } 1145 }
1146 1146
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c
index b007637f0406..6ce25969b785 100644
--- a/fs/ubifs/replay.c
+++ b/fs/ubifs/replay.c
@@ -686,7 +686,7 @@ out:
686 686
687out_dump: 687out_dump:
688 ubifs_err("bad node is at LEB %d:%d", lnum, snod->offs); 688 ubifs_err("bad node is at LEB %d:%d", lnum, snod->offs);
689 dbg_dump_node(c, snod->node); 689 ubifs_dump_node(c, snod->node);
690 ubifs_scan_destroy(sleb); 690 ubifs_scan_destroy(sleb);
691 return -EINVAL; 691 return -EINVAL;
692} 692}
@@ -958,7 +958,7 @@ out:
958out_dump: 958out_dump:
959 ubifs_err("log error detected while replaying the log at LEB %d:%d", 959 ubifs_err("log error detected while replaying the log at LEB %d:%d",
960 lnum, offs + snod->offs); 960 lnum, offs + snod->offs);
961 dbg_dump_node(c, snod->node); 961 ubifs_dump_node(c, snod->node);
962 ubifs_scan_destroy(sleb); 962 ubifs_scan_destroy(sleb);
963 return -EINVAL; 963 return -EINVAL;
964} 964}
diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c
index 771f7fb6ce92..c51f6a4af0f1 100644
--- a/fs/ubifs/sb.c
+++ b/fs/ubifs/sb.c
@@ -475,7 +475,7 @@ static int validate_sb(struct ubifs_info *c, struct ubifs_sb_node *sup)
475 475
476failed: 476failed:
477 ubifs_err("bad superblock, error %d", err); 477 ubifs_err("bad superblock, error %d", err);
478 dbg_dump_node(c, sup); 478 ubifs_dump_node(c, sup);
479 return -EINVAL; 479 return -EINVAL;
480} 480}
481 481
diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
index 37383e8011b1..ec82a6851032 100644
--- a/fs/ubifs/scan.c
+++ b/fs/ubifs/scan.c
@@ -101,7 +101,7 @@ int ubifs_scan_a_node(const struct ubifs_info *c, void *buf, int len, int lnum,
101 if (!quiet) { 101 if (!quiet) {
102 ubifs_err("bad pad node at LEB %d:%d", 102 ubifs_err("bad pad node at LEB %d:%d",
103 lnum, offs); 103 lnum, offs);
104 dbg_dump_node(c, pad); 104 ubifs_dump_node(c, pad);
105 } 105 }
106 return SCANNED_A_BAD_PAD_NODE; 106 return SCANNED_A_BAD_PAD_NODE;
107 } 107 }
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 76e4e0566ad6..147b7acf4786 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -246,8 +246,8 @@ struct inode *ubifs_iget(struct super_block *sb, unsigned long inum)
246 246
247out_invalid: 247out_invalid:
248 ubifs_err("inode %lu validation failed, error %d", inode->i_ino, err); 248 ubifs_err("inode %lu validation failed, error %d", inode->i_ino, err);
249 dbg_dump_node(c, ino); 249 ubifs_dump_node(c, ino);
250 dbg_dump_inode(c, inode); 250 ubifs_dump_inode(c, inode);
251 err = -EINVAL; 251 err = -EINVAL;
252out_ino: 252out_ino:
253 kfree(ino); 253 kfree(ino);
@@ -1147,8 +1147,8 @@ static int check_free_space(struct ubifs_info *c)
1147 ubifs_assert(c->dark_wm > 0); 1147 ubifs_assert(c->dark_wm > 0);
1148 if (c->lst.total_free + c->lst.total_dirty < c->dark_wm) { 1148 if (c->lst.total_free + c->lst.total_dirty < c->dark_wm) {
1149 ubifs_err("insufficient free space to mount in R/W mode"); 1149 ubifs_err("insufficient free space to mount in R/W mode");
1150 dbg_dump_budg(c, &c->bi); 1150 ubifs_dump_budg(c, &c->bi);
1151 dbg_dump_lprops(c); 1151 ubifs_dump_lprops(c);
1152 return -ENOSPC; 1152 return -ENOSPC;
1153 } 1153 }
1154 return 0; 1154 return 0;
diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
index 2e0bc4efb70e..12c25d925d3f 100644
--- a/fs/ubifs/tnc.c
+++ b/fs/ubifs/tnc.c
@@ -340,7 +340,7 @@ static int lnc_add(struct ubifs_info *c, struct ubifs_zbranch *zbr,
340 err = ubifs_validate_entry(c, dent); 340 err = ubifs_validate_entry(c, dent);
341 if (err) { 341 if (err) {
342 dump_stack(); 342 dump_stack();
343 dbg_dump_node(c, dent); 343 ubifs_dump_node(c, dent);
344 return err; 344 return err;
345 } 345 }
346 346
@@ -373,7 +373,7 @@ static int lnc_add_directly(struct ubifs_info *c, struct ubifs_zbranch *zbr,
373 err = ubifs_validate_entry(c, node); 373 err = ubifs_validate_entry(c, node);
374 if (err) { 374 if (err) {
375 dump_stack(); 375 dump_stack();
376 dbg_dump_node(c, node); 376 ubifs_dump_node(c, node);
377 return err; 377 return err;
378 } 378 }
379 379
@@ -1733,7 +1733,7 @@ out_err:
1733 err = -EINVAL; 1733 err = -EINVAL;
1734out: 1734out:
1735 ubifs_err("bad node at LEB %d:%d", zbr->lnum, zbr->offs); 1735 ubifs_err("bad node at LEB %d:%d", zbr->lnum, zbr->offs);
1736 dbg_dump_node(c, buf); 1736 ubifs_dump_node(c, buf);
1737 dump_stack(); 1737 dump_stack();
1738 return err; 1738 return err;
1739} 1739}
@@ -2403,7 +2403,7 @@ static int tnc_delete(struct ubifs_info *c, struct ubifs_znode *znode, int n)
2403 2403
2404 err = ubifs_add_dirt(c, zbr->lnum, zbr->len); 2404 err = ubifs_add_dirt(c, zbr->lnum, zbr->len);
2405 if (err) { 2405 if (err) {
2406 dbg_dump_znode(c, znode); 2406 ubifs_dump_znode(c, znode);
2407 return err; 2407 return err;
2408 } 2408 }
2409 2409
@@ -2649,7 +2649,7 @@ int ubifs_tnc_remove_range(struct ubifs_info *c, union ubifs_key *from_key,
2649 err = ubifs_add_dirt(c, znode->zbranch[i].lnum, 2649 err = ubifs_add_dirt(c, znode->zbranch[i].lnum,
2650 znode->zbranch[i].len); 2650 znode->zbranch[i].len);
2651 if (err) { 2651 if (err) {
2652 dbg_dump_znode(c, znode); 2652 ubifs_dump_znode(c, znode);
2653 goto out_unlock; 2653 goto out_unlock;
2654 } 2654 }
2655 dbg_tnck(key, "removing key "); 2655 dbg_tnck(key, "removing key ");
@@ -3335,7 +3335,7 @@ out_dump:
3335 (unsigned long)inode->i_ino, size, 3335 (unsigned long)inode->i_ino, size,
3336 ((loff_t)block) << UBIFS_BLOCK_SHIFT); 3336 ((loff_t)block) << UBIFS_BLOCK_SHIFT);
3337 mutex_unlock(&c->tnc_mutex); 3337 mutex_unlock(&c->tnc_mutex);
3338 dbg_dump_inode(c, inode); 3338 ubifs_dump_inode(c, inode);
3339 dump_stack(); 3339 dump_stack();
3340 return -EINVAL; 3340 return -EINVAL;
3341 3341
diff --git a/fs/ubifs/tnc_commit.c b/fs/ubifs/tnc_commit.c
index 4c15f07a8bb2..e8cf891185ec 100644
--- a/fs/ubifs/tnc_commit.c
+++ b/fs/ubifs/tnc_commit.c
@@ -54,9 +54,9 @@ static int make_idx_node(struct ubifs_info *c, struct ubifs_idx_node *idx,
54 br->len = cpu_to_le32(zbr->len); 54 br->len = cpu_to_le32(zbr->len);
55 if (!zbr->lnum || !zbr->len) { 55 if (!zbr->lnum || !zbr->len) {
56 ubifs_err("bad ref in znode"); 56 ubifs_err("bad ref in znode");
57 dbg_dump_znode(c, znode); 57 ubifs_dump_znode(c, znode);
58 if (zbr->znode) 58 if (zbr->znode)
59 dbg_dump_znode(c, zbr->znode); 59 ubifs_dump_znode(c, zbr->znode);
60 } 60 }
61 } 61 }
62 ubifs_prepare_node(c, idx, len, 0); 62 ubifs_prepare_node(c, idx, len, 0);
@@ -388,8 +388,8 @@ static int layout_in_gaps(struct ubifs_info *c, int cnt)
388 * option which forces in-the-gaps is enabled. 388 * option which forces in-the-gaps is enabled.
389 */ 389 */
390 ubifs_warn("out of space"); 390 ubifs_warn("out of space");
391 dbg_dump_budg(c, &c->bi); 391 ubifs_dump_budg(c, &c->bi);
392 dbg_dump_lprops(c); 392 ubifs_dump_lprops(c);
393 } 393 }
394 /* Try to commit anyway */ 394 /* Try to commit anyway */
395 err = 0; 395 err = 0;
@@ -864,9 +864,9 @@ static int write_index(struct ubifs_info *c)
864 br->len = cpu_to_le32(zbr->len); 864 br->len = cpu_to_le32(zbr->len);
865 if (!zbr->lnum || !zbr->len) { 865 if (!zbr->lnum || !zbr->len) {
866 ubifs_err("bad ref in znode"); 866 ubifs_err("bad ref in znode");
867 dbg_dump_znode(c, znode); 867 ubifs_dump_znode(c, znode);
868 if (zbr->znode) 868 if (zbr->znode)
869 dbg_dump_znode(c, zbr->znode); 869 ubifs_dump_znode(c, zbr->znode);
870 } 870 }
871 } 871 }
872 len = ubifs_idx_node_sz(c, znode->child_cnt); 872 len = ubifs_idx_node_sz(c, znode->child_cnt);
diff --git a/fs/ubifs/tnc_misc.c b/fs/ubifs/tnc_misc.c
index dc28fe6ec07a..15212d666b15 100644
--- a/fs/ubifs/tnc_misc.c
+++ b/fs/ubifs/tnc_misc.c
@@ -387,7 +387,7 @@ static int read_znode(struct ubifs_info *c, int lnum, int offs, int len,
387 387
388out_dump: 388out_dump:
389 ubifs_err("bad indexing node at LEB %d:%d, error %d", lnum, offs, err); 389 ubifs_err("bad indexing node at LEB %d:%d, error %d", lnum, offs, err);
390 dbg_dump_node(c, idx); 390 ubifs_dump_node(c, idx);
391 kfree(idx); 391 kfree(idx);
392 return -EINVAL; 392 return -EINVAL;
393} 393}
@@ -486,7 +486,7 @@ int ubifs_tnc_read_node(struct ubifs_info *c, struct ubifs_zbranch *zbr,
486 zbr->lnum, zbr->offs); 486 zbr->lnum, zbr->offs);
487 dbg_tnck(key, "looked for key "); 487 dbg_tnck(key, "looked for key ");
488 dbg_tnck(&key1, "but found node's key "); 488 dbg_tnck(&key1, "but found node's key ");
489 dbg_dump_node(c, node); 489 ubifs_dump_node(c, node);
490 return -EINVAL; 490 return -EINVAL;
491 } 491 }
492 492