diff options
author | Dan Williams <dan.j.williams@intel.com> | 2016-09-21 12:22:33 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2016-09-21 12:35:15 -0400 |
commit | ecfb6d8a041cc2ca80bc69ffc20c00067d190df5 (patch) | |
tree | 24f28c0e055e608a45f95af056254df5a4aa297d | |
parent | 9d15ce9caaf9ecbec74e3be156a4a57451ed16c2 (diff) |
libnvdimm: fix devm_nvdimm_memremap() error path
The internal alloc_nvdimm_map() helper might fail, particularly if the
memory region is already busy. Report request_mem_region() failures and
check for the failure.
Reported-by: Ryan Chen <ryan.chan105@gmail.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r-- | drivers/nvdimm/core.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c index 715583f69d28..4d7bbd2df5c0 100644 --- a/drivers/nvdimm/core.c +++ b/drivers/nvdimm/core.c | |||
@@ -99,8 +99,11 @@ static struct nvdimm_map *alloc_nvdimm_map(struct device *dev, | |||
99 | nvdimm_map->size = size; | 99 | nvdimm_map->size = size; |
100 | kref_init(&nvdimm_map->kref); | 100 | kref_init(&nvdimm_map->kref); |
101 | 101 | ||
102 | if (!request_mem_region(offset, size, dev_name(&nvdimm_bus->dev))) | 102 | if (!request_mem_region(offset, size, dev_name(&nvdimm_bus->dev))) { |
103 | dev_err(&nvdimm_bus->dev, "failed to request %pa + %zd for %s\n", | ||
104 | &offset, size, dev_name(dev)); | ||
103 | goto err_request_region; | 105 | goto err_request_region; |
106 | } | ||
104 | 107 | ||
105 | if (flags) | 108 | if (flags) |
106 | nvdimm_map->mem = memremap(offset, size, flags); | 109 | nvdimm_map->mem = memremap(offset, size, flags); |
@@ -171,6 +174,9 @@ void *devm_nvdimm_memremap(struct device *dev, resource_size_t offset, | |||
171 | kref_get(&nvdimm_map->kref); | 174 | kref_get(&nvdimm_map->kref); |
172 | nvdimm_bus_unlock(dev); | 175 | nvdimm_bus_unlock(dev); |
173 | 176 | ||
177 | if (!nvdimm_map) | ||
178 | return NULL; | ||
179 | |||
174 | if (devm_add_action_or_reset(dev, nvdimm_map_put, nvdimm_map)) | 180 | if (devm_add_action_or_reset(dev, nvdimm_map_put, nvdimm_map)) |
175 | return NULL; | 181 | return NULL; |
176 | 182 | ||