aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBoris Brezillon <boris.brezillon@free-electrons.com>2016-09-16 10:59:12 -0400
committerRichard Weinberger <richard@nod.at>2016-10-02 16:48:14 -0400
commitecbfa8eabae9cd73522d1d3d15869703c263d859 (patch)
tree2b4bc1e8cae4b268ee055ff25a878861b3bd1b0a
parent4c368421bc1a2acc84beafcae37ed3733a4fa4fc (diff)
UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header
scan_pool() does not mark the PEB for scrubing when bitflips are detected in the EC header of a free PEB (VID header region left to 0xff). Make sure we scrub the PEB in this case. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Fixes: dbb7d2a88d2a ("UBI: Add fastmap core") Signed-off-by: Richard Weinberger <richard@nod.at>
-rw-r--r--drivers/mtd/ubi/fastmap.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index ebb65ac6980f..a6ed78d14055 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -498,10 +498,11 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
498 unsigned long long ec = be64_to_cpu(ech->ec); 498 unsigned long long ec = be64_to_cpu(ech->ec);
499 unmap_peb(ai, pnum); 499 unmap_peb(ai, pnum);
500 dbg_bld("Adding PEB to free: %i", pnum); 500 dbg_bld("Adding PEB to free: %i", pnum);
501
501 if (err == UBI_IO_FF_BITFLIPS) 502 if (err == UBI_IO_FF_BITFLIPS)
502 add_aeb(ai, free, pnum, ec, 1); 503 scrub = 1;
503 else 504
504 add_aeb(ai, free, pnum, ec, 0); 505 add_aeb(ai, free, pnum, ec, scrub);
505 continue; 506 continue;
506 } else if (err == 0 || err == UBI_IO_BITFLIPS) { 507 } else if (err == 0 || err == UBI_IO_BITFLIPS) {
507 dbg_bld("Found non empty PEB:%i in pool", pnum); 508 dbg_bld("Found non empty PEB:%i in pool", pnum);